Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033027Openbravo ERPA. Platformpublic2016-05-03 12:352016-05-24 07:51
ReporterJONHM 
Assigned Tocaristu 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0PR16Q1 
Target Version3.0PR16Q2Fixed in Version3.0PR16Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket41779
Regression levelPre packaging ( pi )
Regression date2016-04-08
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/8c53c9e9c26febf892a11cd30f5f5f81342cb2c2 [^]
Triggers an Emergency PackNo
Summary0033027: Cannot export CSV from Widgets
DescriptionAt trying to export CSV from any widget no file is exported nor error window showed
Steps To Reproduce1) As F&B International Group Admin create new widget with data on it
2) Click on the pencil and press "Export as CSV"

*Log shows: ERROR org.openbravo.service.datasource.DataSourceServlet - AccessTableNoView
org.openbravo.client.kernel.OBUserException: AccessTableNoView
Proposed SolutionSince the following changeset[1] 'tabId' is being sent in the request instead of 'tab'. So, before that changeset as the parameter name was not 'tabId' the following check was never true:

if (!hasAccess(request, parameters.get("tabId"))) {

Two possible solutions regarding the renamed parameter (tabId):

a) Take into account undefined value in if clause

b) Prevent sending undefined value from the client side and send null instead

[1] https://code.openbravo.com/erp/devel/pi/rev/8c53c9e9c26febf892a11cd30f5f5f81342cb2c2 [^]
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0032838 closed alostale Cannot export CSV from Widgets 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-23 13:10caristuTypedefect => backport
2016-05-23 13:10caristuTarget Version => 3.0PR16Q2
2016-05-23 13:11caristuAssigned Toalostale => caristu
2016-05-23 13:36caristuNote Added: 0086649
2016-05-23 13:36caristuStatusscheduled => resolved
2016-05-23 13:36caristuFixed in Version => 3.0PR16Q2
2016-05-23 13:36caristuResolutionopen => fixed
2016-05-23 13:37caristuNote Edited: 0086649bug_revision_view_page.php?bugnote_id=0086649#r12202
2016-05-23 13:39caristuReview Assigned Tocaristu => alostale
2016-05-24 07:51alostaleNote Added: 0086691
2016-05-24 07:51alostaleStatusresolved => closed

Notes
(0086649)
caristu   
2016-05-23 13:36   
(edited on: 2016-05-23 13:37)
Repository: erp/backports/3.0PR16Q2
Changeset: a08db06ea86f8190fec16c1fa6961331280d5c24
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon May 23 13:31:02 2016 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR16Q2/rev/a08db06ea86f8190fec16c1fa6961331280d5c24 [^] [^]

fixes issue 33027: Cannot export CSV from Widgets

  The name of the parameter used to sent the tab ID when exporting to CSV changed, this
  affected a check on DataSourceServlet that was always true when exporting widgets until now.

  Created an utility method to check whether a json value can be considered as
  empty which takes into account common cases of null and undefined literals.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonConstants.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonUtils.java
(0086691)
alostale   
2016-05-24 07:51   
code reviewed + tested