Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033025
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] A. Platformmajorhave not tried2016-05-23 13:032016-05-24 07:47
ReportercaristuView Statuspublic 
Assigned Tocaristu 
PriorityimmediateResolutionfixedFixed in Version3.0PR15Q4.7
StatusclosedFix in branchFixed in SCM revision631c15d1fcb6
ProjectionnoneETAnoneTarget Version3.0PR15Q4.7
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033025: Cannot export CSV from Widgets

Description1) As F&B International Group Admin create new widget with data on it
2) Click on the pencil and press "Export as CSV"

*Log shows: ERROR org.openbravo.service.datasource.DataSourceServlet - AccessTableNoView
org.openbravo.client.kernel.OBUserException: AccessTableNoView
Steps To ReproduceSince the following changeset[1] 'tabId' is being sent in the request instead of 'tab'. So, before that changeset as the parameter name was not 'tabId' the following check was never true:

if (!hasAccess(request, parameters.get("tabId"))) {

Two possible solutions regarding the renamed parameter (tabId):

a) Take into account undefined value in if clause

b) Prevent sending undefined value from the client side and send null instead

[1] https://code.openbravo.com/erp/devel/pi/rev/8c53c9e9c26febf892a11cd30f5f5f81342cb2c2 [^] [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0032838 closedalostale Cannot export CSV from Widgets 

-  Notes
(0086647)
hgbot (developer)
2016-05-23 13:09

 Repository: erp/backports/3.0PR15Q4.7
Changeset: 631c15d1fcb622aa69d9387b9c8f0af1ff36a6b1
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon May 23 13:09:02 2016 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q4.7/rev/631c15d1fcb622aa69d9387b9c8f0af1ff36a6b1 [^]

fixes issue 33025: Cannot export CSV from Widgets

  The name of the parameter used to sent the tab ID when exporting to CSV changed, this
  affected a check on DataSourceServlet that was always true when exporting widgets until now.

  Created an utility method to check whether a json value can be considered as
  empty which takes into account common cases of null and undefined literals.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonConstants.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonUtils.java
---
(0086690)
alostale (manager)
2016-05-24 07:47

 code reviewed + tested

- Issue History
Date Modified Username Field Change
2016-05-23 13:03 caristu New Issue
2016-05-23 13:03 caristu Assigned To => caristu
2016-05-23 13:03 caristu Modules => Core
2016-05-23 13:03 caristu Triggers an Emergency Pack => No
2016-05-23 13:04 caristu Relationship added blocks 0032838
2016-05-23 13:09 hgbot Checkin
2016-05-23 13:09 hgbot Note Added: 0086647
2016-05-23 13:09 hgbot Status new => resolved
2016-05-23 13:09 hgbot Resolution open => fixed
2016-05-23 13:09 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q4.7/rev/631c15d1fcb622aa69d9387b9c8f0af1ff36a6b1 [^]
2016-05-23 13:10 caristu Review Assigned To => alostale
2016-05-24 07:47 alostale Note Added: 0086690
2016-05-24 07:47 alostale Status resolved => closed
2016-05-24 07:47 alostale Fixed in Version => 3.0PR15Q4.7

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker