Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033025Openbravo ERPA. Platformpublic2016-05-23 13:032016-05-24 07:47
Reportercaristu 
Assigned Tocaristu 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q4.7Fixed in Version3.0PR15Q4.7 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033025: Cannot export CSV from Widgets
Description1) As F&B International Group Admin create new widget with data on it
2) Click on the pencil and press "Export as CSV"

*Log shows: ERROR org.openbravo.service.datasource.DataSourceServlet - AccessTableNoView
org.openbravo.client.kernel.OBUserException: AccessTableNoView
Steps To ReproduceSince the following changeset[1] 'tabId' is being sent in the request instead of 'tab'. So, before that changeset as the parameter name was not 'tabId' the following check was never true:

if (!hasAccess(request, parameters.get("tabId"))) {

Two possible solutions regarding the renamed parameter (tabId):

a) Take into account undefined value in if clause

b) Prevent sending undefined value from the client side and send null instead

[1] https://code.openbravo.com/erp/devel/pi/rev/8c53c9e9c26febf892a11cd30f5f5f81342cb2c2 [^] [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0032838 closed alostale Cannot export CSV from Widgets 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-23 13:03caristuNew Issue
2016-05-23 13:03caristuAssigned To => caristu
2016-05-23 13:03caristuModules => Core
2016-05-23 13:03caristuTriggers an Emergency Pack => No
2016-05-23 13:04caristuRelationship addedblocks 0032838
2016-05-23 13:09hgbotCheckin
2016-05-23 13:09hgbotNote Added: 0086647
2016-05-23 13:09hgbotStatusnew => resolved
2016-05-23 13:09hgbotResolutionopen => fixed
2016-05-23 13:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q4.7/rev/631c15d1fcb622aa69d9387b9c8f0af1ff36a6b1 [^]
2016-05-23 13:10caristuReview Assigned To => alostale
2016-05-24 07:47alostaleNote Added: 0086690
2016-05-24 07:47alostaleStatusresolved => closed
2016-05-24 07:47alostaleFixed in Version => 3.0PR15Q4.7

Notes
(0086647)
hgbot   
2016-05-23 13:09   
Repository: erp/backports/3.0PR15Q4.7
Changeset: 631c15d1fcb622aa69d9387b9c8f0af1ff36a6b1
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon May 23 13:09:02 2016 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR15Q4.7/rev/631c15d1fcb622aa69d9387b9c8f0af1ff36a6b1 [^]

fixes issue 33025: Cannot export CSV from Widgets

  The name of the parameter used to sent the tab ID when exporting to CSV changed, this
  affected a check on DataSourceServlet that was always true when exporting widgets until now.

  Created an utility method to check whether a json value can be considered as
  empty which takes into account common cases of null and undefined literals.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonConstants.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonUtils.java
---
(0086690)
alostale   
2016-05-24 07:47   
code reviewed + tested