Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0032793
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] C. Securitymajoralways2016-04-27 02:482016-06-17 19:37
ReporterrbianchiniView Statuspublic 
Assigned ToAtulOpenbravo 
PriorityhighResolutionfixedFixed in Version3.0PR16Q3
StatusclosedFix in branchFixed in SCM revision04d238173afa
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version3.0PR16Q1SCM revision 
Review Assigned Toaferraz
Web browserGoogle Chrome
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0032793: Generate duplicate payment plan under some circumstances

DescriptionWhen 2 different users are logged in (in different browsers) openbravo, and both complete a sales order, the sales order might have 2 payment plans. If you want to pay the order, you can pay double amount. If you want to reactivate the order an error is shown "The order has more than one Payment Plan record with related Payment Plan details. Please contact your System Administrator to fix it."
Steps To Reproduce0 - Login with Openbravo user and activate user F&BUser
1 - Go to Alimentos y Supermercados business partner and delete every record in Basic Discount tab
2 - Create a sales order, add a line and let it in draft status
3 - Open other browser and log in ERP with F&BUser
4 - Go to Sales order window and check the sales order created in step 2
5 - With Openbravo user complete the sales order
6 - With F&BUser user, without refresh, complete the same sales order
7 - Go to payment plan tab and check the duplicated payment plan
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 00329823.0PR16Q2 closedAtulOpenbravo Generate duplicate payment plan under some circumstances 
depends on backport 00329833.0PR16Q1.2 closedAtulOpenbravo Generate duplicate payment plan under some circumstances 
depends on backport 00329843.0PR15Q4.7 closedAtulOpenbravo Generate duplicate payment plan under some circumstances 
related to defect 0032837 newTriage Finance Some documents can be processed twice 

-  Notes
(0086068)
AtulOpenbravo (developer)
2016-04-29 08:06
edited on: 2016-05-02 19:14

 - Login with Openbravo user and activate user F&BUser
- Go to "Alimentos y Supermercados" business partner and delete every record in Basic Discount tab.
- Create a sales order, add a line and let it in draft status.
- Open other browser and log in ERP with F&BUser.
- Go to Sales order window and check the sales order created in step 2
  - With Openbravo user complete the sales order.
  - With F&BUser user, without refresh, complete the same sales order.
- Error message is shown "Record cannot be changed because is processed".
(0086140)
psanjuan (manager)
2016-05-02 19:09

 Issue verified.
(0086141)
psanjuan (manager)
2016-05-02 19:13
edited on: 2016-05-02 19:47

 Test Plan

- Login with Openbravo user and activate user F&BUser

- Go to "Alimentos y Supermercados" business partner and delete every record in Basic Discount tab.

- Create a sales order, add a line and let it in draft status.

- Open other browser and log in ERP with F&BUser.

- Go to Sales order window and check the sales order created in step 2
  - With Openbravo user complete the sales order.
  - With F&BUser user, without refresh, complete the same sales order.

- Error message is shown "Record cannot be changed because is processed".

Repeat same test plan as above for:
Sales Quotation - ok
Goods Shipment - not ok. Error shown is: Movement quantity is greater than the ordered quantity in lines 10.
Sales Invoice - ok
Return from customer - ok

Purchase Order - ok
Goods Receipt - not ok, it is processed once more. Message shown is: Process completed successfully.
Purchase Invoice - ok
Return to Vendor - Ok
Return to Vendor Shipment - not ok, it is processed once more. Message shown is: Process completed successfully.
(0086148)
hgbot (developer)
2016-05-03 11:40

 Repository: erp/devel/pi
Changeset: 04d238173afaba3908d38944367d028ee850f41b
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon May 02 16:58:34 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/04d238173afaba3908d38944367d028ee850f41b [^]

Fixes issue 32793: Generate duplicate payment plan under some circumstances

Before processing order, a check is done whether processed flag is N or not.

---
M src-db/database/model/functions/C_ORDER_POST1.xml
---
(0086149)
hgbot (developer)
2016-05-03 11:40

 Repository: erp/devel/pi
Changeset: 2bcf5c3e1da66ebae6a14d2c75d5627ac9e36ccd
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue May 03 11:36:04 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2bcf5c3e1da66ebae6a14d2c75d5627ac9e36ccd [^]

Related to issue 32793: Code review improvements

---
M src-db/database/model/functions/C_ORDER_POST1.xml
---
(0086150)
aferraz (manager)
2016-05-03 11:41

 Code review + Testing OK
(0087509)
hudsonbot (developer)
2016-06-17 19:37

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087510)
hudsonbot (developer)
2016-06-17 19:37

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-04-27 02:48 rbianchini New Issue
2016-04-27 02:48 rbianchini Assigned To => platform
2016-04-27 02:48 rbianchini Web browser => Google Chrome
2016-04-27 02:48 rbianchini Modules => Core
2016-04-27 02:48 rbianchini Resolution time => 1462244400
2016-04-27 02:48 rbianchini Triggers an Emergency Pack => No
2016-04-27 09:49 caristu Web browser Google Chrome => Google Chrome
2016-04-27 09:49 caristu Resolution time 1462244400 => 1462226400
2016-04-27 09:49 caristu Assigned To platform => Triage Finance
2016-04-27 13:16 aferraz Assigned To Triage Finance => AtulOpenbravo
2016-04-27 13:28 aferraz Web browser Google Chrome => Google Chrome
2016-04-27 13:28 aferraz Steps to Reproduce Updated View Revisions
2016-04-27 21:34 eugeni Issue Monitored: eugeni
2016-04-29 08:06 AtulOpenbravo Status new => scheduled
2016-04-29 08:06 AtulOpenbravo Note Added: 0086068
2016-05-02 19:09 psanjuan Note Added: 0086140
2016-05-02 19:13 psanjuan Note Added: 0086141
2016-05-02 19:14 psanjuan Note Edited: 0086068 View Revisions
2016-05-02 19:14 psanjuan Note Edited: 0086141 View Revisions
2016-05-02 19:41 psanjuan Note Edited: 0086141 View Revisions
2016-05-02 19:47 psanjuan Note Edited: 0086141 View Revisions
2016-05-03 11:40 hgbot Checkin
2016-05-03 11:40 hgbot Note Added: 0086148
2016-05-03 11:40 hgbot Status scheduled => resolved
2016-05-03 11:40 hgbot Resolution open => fixed
2016-05-03 11:40 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/04d238173afaba3908d38944367d028ee850f41b [^]
2016-05-03 11:40 hgbot Checkin
2016-05-03 11:40 hgbot Note Added: 0086149
2016-05-03 11:41 aferraz Review Assigned To => aferraz
2016-05-03 11:41 aferraz Note Added: 0086150
2016-05-03 11:41 aferraz Status resolved => closed
2016-05-03 11:41 aferraz Fixed in Version => 3.0PR16Q3
2016-05-03 12:19 aferraz Relationship added related to 0032837
2016-05-18 10:16 aferraz Status closed => new
2016-05-18 10:16 aferraz Resolution fixed => open
2016-05-18 10:16 aferraz Fixed in Version 3.0PR16Q3 =>
2016-05-18 10:16 aferraz Status new => scheduled
2016-05-18 10:17 aferraz Status scheduled => resolved
2016-05-18 10:17 aferraz Fixed in Version => 3.0PR16Q3
2016-05-18 10:17 aferraz Resolution open => fixed
2016-05-18 10:17 aferraz Status resolved => closed
2016-06-17 19:37 hudsonbot Checkin
2016-06-17 19:37 hudsonbot Note Added: 0087509
2016-06-17 19:37 hudsonbot Checkin
2016-06-17 19:37 hudsonbot Note Added: 0087510

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker