Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032793Openbravo ERPC. Securitypublic2016-04-27 02:482016-06-17 19:37
Reporterrbianchini 
Assigned ToAtulOpenbravo 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0PR16Q1 
Target VersionFixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032793: Generate duplicate payment plan under some circumstances
DescriptionWhen 2 different users are logged in (in different browsers) openbravo, and both complete a sales order, the sales order might have 2 payment plans. If you want to pay the order, you can pay double amount. If you want to reactivate the order an error is shown "The order has more than one Payment Plan record with related Payment Plan details. Please contact your System Administrator to fix it."
Steps To Reproduce0 - Login with Openbravo user and activate user F&BUser
1 - Go to Alimentos y Supermercados business partner and delete every record in Basic Discount tab
2 - Create a sales order, add a line and let it in draft status
3 - Open other browser and log in ERP with F&BUser
4 - Go to Sales order window and check the sales order created in step 2
5 - With Openbravo user complete the sales order
6 - With F&BUser user, without refresh, complete the same sales order
7 - Go to payment plan tab and check the duplicated payment plan
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00329823.0PR16Q2 closed AtulOpenbravo Generate duplicate payment plan under some circumstances 
depends on backport 00329833.0PR16Q1.2 closed AtulOpenbravo Generate duplicate payment plan under some circumstances 
depends on backport 00329843.0PR15Q4.7 closed AtulOpenbravo Generate duplicate payment plan under some circumstances 
related to defect 0032837 new Triage Finance Some documents can be processed twice 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-04-27 02:48rbianchiniNew Issue
2016-04-27 02:48rbianchiniAssigned To => platform
2016-04-27 02:48rbianchiniWeb browser => Google Chrome
2016-04-27 02:48rbianchiniModules => Core
2016-04-27 02:48rbianchiniResolution time => 1462244400
2016-04-27 02:48rbianchiniTriggers an Emergency Pack => No
2016-04-27 09:49caristuWeb browserGoogle Chrome => Google Chrome
2016-04-27 09:49caristuResolution time1462244400 => 1462226400
2016-04-27 09:49caristuAssigned Toplatform => Triage Finance
2016-04-27 13:16aferrazAssigned ToTriage Finance => AtulOpenbravo
2016-04-27 13:28aferrazWeb browserGoogle Chrome => Google Chrome
2016-04-27 13:28aferrazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11883#r11883
2016-04-27 21:34eugeniIssue Monitored: eugeni
2016-04-29 08:06AtulOpenbravoStatusnew => scheduled
2016-04-29 08:06AtulOpenbravoNote Added: 0086068
2016-05-02 19:09psanjuanNote Added: 0086140
2016-05-02 19:13psanjuanNote Added: 0086141
2016-05-02 19:14psanjuanNote Edited: 0086068bug_revision_view_page.php?bugnote_id=0086068#r11945
2016-05-02 19:14psanjuanNote Edited: 0086141bug_revision_view_page.php?bugnote_id=0086141#r11947
2016-05-02 19:41psanjuanNote Edited: 0086141bug_revision_view_page.php?bugnote_id=0086141#r11948
2016-05-02 19:47psanjuanNote Edited: 0086141bug_revision_view_page.php?bugnote_id=0086141#r11949
2016-05-03 11:40hgbotCheckin
2016-05-03 11:40hgbotNote Added: 0086148
2016-05-03 11:40hgbotStatusscheduled => resolved
2016-05-03 11:40hgbotResolutionopen => fixed
2016-05-03 11:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/04d238173afaba3908d38944367d028ee850f41b [^]
2016-05-03 11:40hgbotCheckin
2016-05-03 11:40hgbotNote Added: 0086149
2016-05-03 11:41aferrazReview Assigned To => aferraz
2016-05-03 11:41aferrazNote Added: 0086150
2016-05-03 11:41aferrazStatusresolved => closed
2016-05-03 11:41aferrazFixed in Version => 3.0PR16Q3
2016-05-03 12:19aferrazRelationship addedrelated to 0032837
2016-05-18 10:16aferrazStatusclosed => new
2016-05-18 10:16aferrazResolutionfixed => open
2016-05-18 10:16aferrazFixed in Version3.0PR16Q3 =>
2016-05-18 10:16aferrazStatusnew => scheduled
2016-05-18 10:17aferrazStatusscheduled => resolved
2016-05-18 10:17aferrazFixed in Version => 3.0PR16Q3
2016-05-18 10:17aferrazResolutionopen => fixed
2016-05-18 10:17aferrazStatusresolved => closed
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087509
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087510

Notes
(0086068)
AtulOpenbravo   
2016-04-29 08:06   
(edited on: 2016-05-02 19:14)
- Login with Openbravo user and activate user F&BUser
- Go to "Alimentos y Supermercados" business partner and delete every record in Basic Discount tab.
- Create a sales order, add a line and let it in draft status.
- Open other browser and log in ERP with F&BUser.
- Go to Sales order window and check the sales order created in step 2
  - With Openbravo user complete the sales order.
  - With F&BUser user, without refresh, complete the same sales order.
- Error message is shown "Record cannot be changed because is processed".
(0086140)
psanjuan   
2016-05-02 19:09   
Issue verified.
(0086141)
psanjuan   
2016-05-02 19:13   
(edited on: 2016-05-02 19:47)
Test Plan

- Login with Openbravo user and activate user F&BUser

- Go to "Alimentos y Supermercados" business partner and delete every record in Basic Discount tab.

- Create a sales order, add a line and let it in draft status.

- Open other browser and log in ERP with F&BUser.

- Go to Sales order window and check the sales order created in step 2
  - With Openbravo user complete the sales order.
  - With F&BUser user, without refresh, complete the same sales order.

- Error message is shown "Record cannot be changed because is processed".

Repeat same test plan as above for:
Sales Quotation - ok
Goods Shipment - not ok. Error shown is: Movement quantity is greater than the ordered quantity in lines 10.
Sales Invoice - ok
Return from customer - ok

Purchase Order - ok
Goods Receipt - not ok, it is processed once more. Message shown is: Process completed successfully.
Purchase Invoice - ok
Return to Vendor - Ok
Return to Vendor Shipment - not ok, it is processed once more. Message shown is: Process completed successfully.
(0086148)
hgbot   
2016-05-03 11:40   
Repository: erp/devel/pi
Changeset: 04d238173afaba3908d38944367d028ee850f41b
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon May 02 16:58:34 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/04d238173afaba3908d38944367d028ee850f41b [^]

Fixes issue 32793: Generate duplicate payment plan under some circumstances

Before processing order, a check is done whether processed flag is N or not.

---
M src-db/database/model/functions/C_ORDER_POST1.xml
---
(0086149)
hgbot   
2016-05-03 11:40   
Repository: erp/devel/pi
Changeset: 2bcf5c3e1da66ebae6a14d2c75d5627ac9e36ccd
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue May 03 11:36:04 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2bcf5c3e1da66ebae6a14d2c75d5627ac9e36ccd [^]

Related to issue 32793: Code review improvements

---
M src-db/database/model/functions/C_ORDER_POST1.xml
---
(0086150)
aferraz   
2016-05-03 11:41   
Code review + Testing OK
(0087509)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087510)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test