0032325: [SERQA 692] Javscript error when adding a manual discount

Description

"Promotion and Discount: If we insert a manual amount discount without pressing ENTER or Discount, WE get a javascript error.

Steps To Reproduce

1. In backend create a Discount and promotion woth the following information:
- Org: *
- Discount/promotion type: User Defined Amount
- Name: Amount discount
- Starting date: 1/2/2016
Leave the other fields as thy are by default
2. In web POS create a receipt and add the product "headlamp ultralight"
3. In menu select the option Receipt discounts
4. In payment pannel select the option Amount discount
5. Check both options,
Override existing promotions
Apply to all lines
6. Click amount 12 (without pressing the button DISCOUNT or ENTER)
7. Click the button APPLY
ERROR--> a javascript error appears

Proposed Solution

Instead of the javascript error, we should have a Error message saying por example: "you must click enter or DISCOUNT before APPLY button in order to add the discount to the receipt"

Tags

No tags attached.

Attached Files

issue 32325 posterminal RR16Q1 6111.patch [^] (1,170 bytes) 2016-02-25 17:44 [Show Content] [Hide Content]

# HG changeset patch
# User Ranjith S R <ranjith@qualiantech.com>
# Date 1456418266 -19800
# Node ID 11e6778f6a5120c1a41f03718d63c9a594d03c38
# Parent  df469c6050082768d3f7ad0839bf2548029c327d
Related to issue 32243 : Validating Variable Discount Amount before applying to receipt

diff -r df469c605008 -r 11e6778f6a51 web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js	Thu Feb 25 13:43:23 2016 +0100
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js	Thu Feb 25 22:07:46 2016 +0530
@@ -236,7 +236,7 @@
     var comp = this._searchSelectedComponent(this.$.discountsList.getValue()),
         discountsContainer = this.$.discountsContainer;
     discountsContainer.model = comp.model;
-    discountsContainer.requiredQty = comp.requiredQty;
+    discountsContainer.requiresQty = comp.requiresQty;
     discountsContainer.amt = comp.amt;
     discountsContainer.units = comp.units;
     if (comp.model.get('discountType') === "8338556C0FBF45249512DB343FEFD280" || comp.model.get('discountType') === "7B49D8CC4E084A75B7CB4D85A6A3A578") {

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0032243

closed

ranjith_qualiantech_com

[SERQA 692] Javscript error when adding a manual discount

Notes
(0084663) hgbot (developer) 2016-03-02 17:04	Repository: retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal Changeset: 3829ddc332fb0d89248afffa001006816afe1442 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Wed Mar 02 17:04:24 2016 +0100 URL: http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/3829ddc332fb0d89248afffa001006816afe1442 [^] Fixed issue 32325. Validating Variable Discount Amount before applying to receipt --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js ---

Issue History
Date Modified	Username	Field	Change
2016-02-24 14:19	Orekaria	Type	defect => backport
2016-02-24 14:19	Orekaria	Target Version	=> RR16Q1
2016-02-25 17:44	ranjith_qualiantech_com	File Added: issue 32325 posterminal RR16Q1 6111.patch
2016-02-29 18:15	marvintm	Severity	major => minor
2016-03-02 17:04	hgbot	Checkin
2016-03-02 17:04	hgbot	Note Added: 0084663
2016-03-02 17:04	hgbot	Status	scheduled => resolved
2016-03-02 17:04	hgbot	Resolution	open => fixed
2016-03-02 17:04	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/94638e56e37bc53643b40c083e5866b59792139b [^] => http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/3829ddc332fb0d89248afffa001006816afe1442 [^]
2016-03-08 19:20	guilleaer	Review Assigned To	=> guilleaer
2016-03-08 19:20	guilleaer	Status	resolved => closed
2016-03-08 19:20	guilleaer	Fixed in Version	=> RR16Q1