Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0032044
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminoralways2016-01-28 18:012016-07-08 11:34
ReportermigueldejuanaView Statuspublic 
Assigned Tomigueldejuana 
PrioritynormalResolutionno change requiredFixed in Version
StatusclosedFix in branchFixed in SCM revision81c7d094eec9
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomtaal
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0032044: Ensure stable ids in docs send from WebPOS to the server (Payment API)

DescriptionSee wiki page:
http://wiki.openbravo.com/wiki/Projects:WebPOS_Store_Server_ensure_Same_Ids [^] [^]

Do that in Payments API.

AdvPaymentMngtDao
TransactionsDao
FIN_AddPayment
Steps To ReproduceSee Description
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0031654 closedmigueldejuana Retail Modules Ensure stable ids in docs send from WebPOS to the server 
depends on design defect 0031419 closedvmromanos Modules Processing an invoice with more than 450 lines takes around 7 minutes 
blocks defect 0032045 closedmtaal Retail Modules Ensure stable ids in docs send from WebPOS to the server (External Modules) 

-  Notes
(0084270)
hgbot (developer)
2016-02-16 18:46

 Repository: erp/mods/org.openbravo.module.remittance
Changeset: 7f128dd4cf54b5a3d2674176cc040af1d4689df8
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Feb 16 18:37:25 2016 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/7f128dd4cf54b5a3d2674176cc040af1d4689df8 [^]

Related to issue 32044: Support for paymentId parameter

---
M src/org/openbravo/module/remittance/process/REM_RemittanceProcess.java
---
(0084562)
hgbot (developer)
2016-02-26 12:57

 Repository: erp/devel/pi
Changeset: 6f297f8de5d6ea54a8f9e4cc7383d0e33caff587
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Feb 18 13:23:15 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6f297f8de5d6ea54a8f9e4cc7383d0e33caff587 [^]

Fixed issue 0032044: Ensure stable ids in docs send from WebPOS to the server (Payment API)

- Set some entities ids related to order loading in Web POS to ensure stable ids

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/TransactionsDao.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java
---
(0084564)
dmiguelez (developer)
2016-02-26 12:59

 Code Review + Testing Ok
(0084566)
migueldejuana (developer)
2016-02-26 13:37

 ERP side is ok. Now we can use it and push posterminal module change
(0084677)
hgbot (developer)
2016-03-03 12:42

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 81c7d094eec9e76957ff0c87d3d74b1c5286b030
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Mar 02 15:51:57 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/81c7d094eec9e76957ff0c87d3d74b1c5286b030 [^]

Fixed issue 0032044: Ensure stable ids in docs send from WebPOS to the server (Payment API)

- Send the payment id to set payment entities

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0084752)
mtaal (manager)
2016-03-06 23:13

 I checked with the following queries, it showed that the last one, the payment detail was not yet solved. The id of the payment detail was not set. See the stack trace below to find the route which was taken.

select * from FIN_Payment order by updated desc limit 2
-- "F7D5D0D1452231AC6FDB7897C2D0636E"
-- "578A3FB223F10CBB4C85023536B86EB2"

select * from FIN_Payment_ScheduleDetail order by updated desc limit 2
-- "F7D5D0D1452231AC6FDB7897C2D0636E"
-- "578A3FB223F10CBB4C85023536B86EB2"

select * from FIN_Payment_Detail order by updated desc limit 2
-- "FF069451B2994899B0464D19CBFF9976"
-- "CA9F4D790C8A407FA17F19EB85705619"



AdvPaymentMngtDao.getNewPaymentDetail(FIN_Payment, FIN_PaymentScheduleDetail, BigDecimal, BigDecimal, boolean, GLItem, boolean, String) line: 554
FIN_AddPayment.updatePaymentDetail(FIN_PaymentScheduleDetail, FIN_Payment, BigDecimal, boolean, boolean) line: 525
FIN_AddPayment.savePayment(FIN_Payment, boolean, DocumentType, String, BusinessPartner, FIN_PaymentMethod, FIN_FinancialAccount, String, Date, Organization, String, List<FIN_PaymentScheduleDetail>, HashMap<String,BigDecimal>, boolean, boolean, Currency, BigDecimal, BigDecimal, boolean, String) line: 182
OrderLoader.processPayments(FIN_PaymentSchedule, FIN_PaymentSchedule, Order, Invoice, OBPOSAppPayment, JSONObject, BigDecimal, JSONObject) line: 1968
OrderLoader.handlePayments(JSONObject, Order, Invoice, Boolean) line: 1756
OrderLoader.saveRecord(JSONObject) line: 436
(0085172)
hudsonbot (developer)
2016-03-17 10:56

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test
(0087111)
migueldejuana (developer)
2016-06-09 10:41

 author Miguel de Juana <miguel.dejuana@openbravo.com>
Tue Jun 07 09:11:39 2016 +0200 (2 days ago)
changeset 2173 c07808a55e4e
parent 2172 4d876100807c
Related to 0032044: Ensure stable ids in docs send from WebPOS to the server (Payment API)

- Improve javadoc
- Use UTF-8 because getBytes depends on 'default encoding' of JVM.

https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c07808a55e4e [^]
(0088289)
migueldejuana (developer)
2016-07-07 12:56

 Does make sense to solve it after last changes in multiserver? (Now, we do not send the ajaxRequest to all server, we do somenthing similar to FailOver)
(0088330)
mtaal (manager)
2016-07-08 11:34

 functionality not needed anymore due to change in approach

- Issue History
Date Modified Username Field Change
2016-01-28 18:01 migueldejuana New Issue
2016-01-28 18:01 migueldejuana Assigned To => migueldejuana
2016-01-28 18:01 migueldejuana Triggers an Emergency Pack => No
2016-01-28 18:02 migueldejuana Relationship added related to 0031654
2016-01-28 18:04 migueldejuana Relationship added blocks 0032045
2016-02-16 18:46 hgbot Checkin
2016-02-16 18:46 hgbot Note Added: 0084270
2016-02-18 13:24 migueldejuana Relationship added depends on 0031419
2016-02-26 12:57 hgbot Checkin
2016-02-26 12:57 hgbot Note Added: 0084562
2016-02-26 12:57 hgbot Status new => resolved
2016-02-26 12:57 hgbot Resolution open => fixed
2016-02-26 12:57 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6f297f8de5d6ea54a8f9e4cc7383d0e33caff587 [^]
2016-02-26 12:59 dmiguelez Review Assigned To => dmiguelez
2016-02-26 12:59 dmiguelez Note Added: 0084564
2016-02-26 12:59 dmiguelez Status resolved => closed
2016-02-26 13:37 migueldejuana Note Added: 0084566
2016-02-26 13:37 migueldejuana Status closed => new
2016-02-26 13:37 migueldejuana Resolution fixed => open
2016-02-26 13:39 migueldejuana Review Assigned To dmiguelez => mtaal
2016-03-03 12:42 hgbot Checkin
2016-03-03 12:42 hgbot Note Added: 0084677
2016-03-03 12:42 hgbot Status new => resolved
2016-03-03 12:42 hgbot Resolution open => fixed
2016-03-03 12:42 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/6f297f8de5d6ea54a8f9e4cc7383d0e33caff587 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/81c7d094eec9e76957ff0c87d3d74b1c5286b030 [^]
2016-03-06 23:13 mtaal Note Added: 0084752
2016-03-06 23:13 mtaal Status resolved => new
2016-03-06 23:13 mtaal Resolution fixed => open
2016-03-17 10:56 hudsonbot Checkin
2016-03-17 10:56 hudsonbot Note Added: 0085172
2016-06-09 10:42 migueldejuana Note Added: 0087111
2016-07-07 12:56 migueldejuana Note Added: 0088289
2016-07-07 12:56 migueldejuana Status new => acknowledged
2016-07-08 11:33 mtaal Status acknowledged => scheduled
2016-07-08 11:34 mtaal Note Added: 0088330
2016-07-08 11:34 mtaal Status scheduled => closed
2016-07-08 11:34 mtaal Resolution open => no change required

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker