Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0031323

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2015-11-02 16:14

2015-11-20 12:50

Reporter

guilleaer

View Status

public

Assigned To

guilleaer

Priority

normal

Resolution

fixed

Fixed in Version

RR16Q1

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

No

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0031323: Web POS crashes when a reload is done having loaded orders using "paid open tickets" functionality

Description

Web POS crashes when a reload is done having loaded orders using "paid open tickets" functionality

Steps To Reproduce

1. Create a layaway and save it without any payment
2. Create a layaway and save it without any payment
3. Open Menu
4. Select "pay open tickets"
5. In the popup select the layaways created in steps 1 and 2
6. press done and layaways will be ready to be paid
7. press f5 or reload
8. When the Web POS is loading an error is shown

OB.Dal: a success callback threw an exception; "function (){if(callback){callback();}}";
TypeError: Cannot read property 'isNegative' of undefined
    at Object.enyo.kind.checkValidCashOverpayment (http://localhost:8080/openbravo/web/js/gen/2b880881f09e85a11e5484f9990c00dc_WebPOS.js:1461:17 [^])
    at Object.enyo.kind.checkValidPayments (http://localhost:8080/openbravo/web/js/gen/2b880881f09e85a11e5484f9990c00dc_WebPOS.js:1462:575 [^])
    at Object.enyo.kind.buttonStatusChanged (http://localhost:8080/openbravo/web/js/gen/2b880881f09e85a11e5484f9990c00dc_WebPOS.js:1433:6 [^])

The only way to reload the app is clearing the cache

Tags

No tags attached.

issue31323.diff [^] (849 bytes) 2015-11-02 16:44 [Show Content] [Hide Content]

diff -r b17dfd0a4fef web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js	Mon Nov 02 11:06:08 2015 +0100
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js	Mon Nov 02 16:44:21 2015 +0100
@@ -79,7 +79,10 @@
       } else if (!_.isNull(pending) && pending) {
         this.setTotalPending(pending, payment.mulrate, payment.symbol, payment.currencySymbolAtTheRight, inSender, inEvent);
       }
-      this.checkValidPayments(paymentstatus, payment);
+      if (paymentstatus) {
+        debugger;
+        this.checkValidPayments(paymentstatus, payment);  
+      }
       if (!_.isNull(this.receipt) && this.receipt.get('isLayaway') && this.receipt.get('orderType') !== 3) {
         this.$.layawayaction.updateVisibility(true);
       }

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on	backport	0031324	RR15Q4	closed	Retail	Web POS crashes when a reload is done having loaded orders using "paid open tickets" functionality
depends on	backport	0031325	RR15Q3.3	closed	guilleaer	Web POS crashes when a reload is done having loaded orders using "paid open tickets" functionality

Notes
(0081460) hgbot (developer) 2015-11-04 09:03	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: e15a9adcf352020314d63266874dd3ce78276239 Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Tue Nov 03 22:03:13 2015 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e15a9adcf352020314d63266874dd3ce78276239 [^] Fixed issue 31323: Don't check payments if there is not information about payments --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js ---

(0081891) hgbot (developer) 2015-11-16 15:25	Repository: tools/automation/pi-mobile Changeset: 3fdd53d15aaa210a9aebabe333efbd71951e8bba Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Mon Nov 16 08:25:09 2015 -0600 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/3fdd53d15aaa210a9aebabe333efbd71951e8bba [^] Verifies issue 31323: Added automated test --- A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31323_LayawayPayOpenTicket.java ---

Issue History
Date Modified	Username	Field	Change
2015-11-02 16:14	guilleaer	New Issue
2015-11-02 16:14	guilleaer	Assigned To	=> Retail
2015-11-02 16:14	guilleaer	OBNetwork customer	=> No
2015-11-02 16:14	guilleaer	Triggers an Emergency Pack	=> No
2015-11-02 16:16	guilleaer	Status	new => scheduled
2015-11-02 16:44	guilleaer	File Added: issue31323.diff
2015-11-04 09:03	hgbot	Checkin
2015-11-04 09:03	hgbot	Note Added: 0081460
2015-11-04 09:03	hgbot	Status	scheduled => resolved
2015-11-04 09:03	hgbot	Resolution	open => fixed
2015-11-04 09:03	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e15a9adcf352020314d63266874dd3ce78276239 [^]
2015-11-09 13:19	Orekaria	Assigned To	Retail => guilleaer
2015-11-09 13:19	Orekaria	Review Assigned To	=> guilleaer
2015-11-11 09:54	Orekaria	Review Assigned To	guilleaer => Orekaria
2015-11-11 09:54	Orekaria	Status	resolved => closed
2015-11-11 09:54	Orekaria	Fixed in Version	=> RR16Q1
2015-11-16 15:25	hgbot	Checkin
2015-11-16 15:25	hgbot	Note Added: 0081891
2015-11-20 12:50	Orekaria	Review Assigned To	Orekaria => marvintm

Copyright © 2000 - 2009 MantisBT Group