Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0030942
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Retail Modules] Web POSmajoralways2015-09-26 22:292015-09-30 10:52
ReporterOrekariaView Statuspublic 
Assigned ToOrekaria 
PrioritynormalResolutionfixedFixed in VersionRR15Q4
StatusclosedFix in branchFixed in SCM revision27aaede86645
ProjectionnoneETAnoneTarget VersionRR15Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toguilleaer
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0030942: Events are being fired when the applyDiscounts tries to prevent infinite loop

DescriptionEvents are being fired when the applyDiscounts tries to prevent infinite loop
Steps To ReproduceIn the discounts.js file
Verify that the new variables set with receipt.set, are not being silented
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0029445 closedOrekaria No receipt events should be fired while the calculateGross is being executed 
caused by defect 0030498 closedjorge-garcia infinite loop with discounts of type "Buy X pay Y of different product" 

-  Notes
(0080656)
hgbot (developer)
2015-09-26 22:54

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 27aaede86645e84f57f5bf272b0790d4f9436f0a
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Sep 26 22:53:19 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/27aaede86645e84f57f5bf272b0790d4f9436f0a [^]

Fixes issue 30942: Silently set values in the applyPromotions logic

The problem is that when a value is set in a backbone model, the 'change' event is being fired. If any event is fired while the discount algorithm is being executed, it could lead to unwanted processes being executed or wrong UI rendering updates

---
M web/org.openbravo.retail.posterminal/js/model/discounts.js
---

- Issue History
Date Modified Username Field Change
2015-09-26 22:29 Orekaria New Issue
2015-09-26 22:29 Orekaria Assigned To => Orekaria
2015-09-26 22:29 Orekaria Triggers an Emergency Pack => No
2015-09-26 22:30 Orekaria Relationship added caused by 0030498
2015-09-26 22:30 Orekaria Review Assigned To => guilleaer
2015-09-26 22:43 Orekaria Regression level => Automated tests
2015-09-26 22:43 Orekaria Regression introduced by commit => https://issues.openbravo.com/view.php?id=30498 [^]
2015-09-26 22:43 Orekaria Regression level Automated tests =>
2015-09-26 22:43 Orekaria Regression introduced by commit https://issues.openbravo.com/view.php?id=30498 [^] =>
2015-09-26 22:44 Orekaria Steps to Reproduce Updated View Revisions
2015-09-26 22:47 Orekaria Type defect => design defect
2015-09-26 22:54 hgbot Checkin
2015-09-26 22:54 hgbot Note Added: 0080656
2015-09-26 22:54 hgbot Status new => resolved
2015-09-26 22:54 hgbot Resolution open => fixed
2015-09-26 22:54 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/27aaede86645e84f57f5bf272b0790d4f9436f0a [^]
2015-09-26 22:59 Orekaria Relationship added related to 0029445
2015-09-30 10:52 guilleaer Status resolved => closed
2015-09-30 10:52 guilleaer Fixed in Version => RR15Q4

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker