Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030942Retail ModulesWeb POSpublic2015-09-26 22:292015-09-30 10:52
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q4Fixed in VersionRR15Q4 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030942: Events are being fired when the applyDiscounts tries to prevent infinite loop
DescriptionEvents are being fired when the applyDiscounts tries to prevent infinite loop
Steps To ReproduceIn the discounts.js file
Verify that the new variables set with receipt.set, are not being silented
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0029445 closed Orekaria No receipt events should be fired while the calculateGross is being executed 
caused by defect 0030498 closed jorge-garcia infinite loop with discounts of type "Buy X pay Y of different product" 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-09-26 22:29OrekariaNew Issue
2015-09-26 22:29OrekariaAssigned To => Orekaria
2015-09-26 22:29OrekariaOBNetwork customer => No
2015-09-26 22:29OrekariaTriggers an Emergency Pack => No
2015-09-26 22:30OrekariaRelationship addedcaused by 0030498
2015-09-26 22:30OrekariaReview Assigned To => guilleaer
2015-09-26 22:43OrekariaRegression level => Automated tests
2015-09-26 22:43OrekariaRegression introduced by commit => https://issues.openbravo.com/view.php?id=30498 [^]
2015-09-26 22:43OrekariaRegression levelAutomated tests =>
2015-09-26 22:43OrekariaRegression introduced by commithttps://issues.openbravo.com/view.php?id=30498 [^] =>
2015-09-26 22:44OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=9487#r9487
2015-09-26 22:47OrekariaTypedefect => design defect
2015-09-26 22:54hgbotCheckin
2015-09-26 22:54hgbotNote Added: 0080656
2015-09-26 22:54hgbotStatusnew => resolved
2015-09-26 22:54hgbotResolutionopen => fixed
2015-09-26 22:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/27aaede86645e84f57f5bf272b0790d4f9436f0a [^]
2015-09-26 22:59OrekariaRelationship addedrelated to 0029445
2015-09-30 10:52guilleaerStatusresolved => closed
2015-09-30 10:52guilleaerFixed in Version => RR15Q4

Notes
(0080656)
hgbot   
2015-09-26 22:54   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 27aaede86645e84f57f5bf272b0790d4f9436f0a
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Sep 26 22:53:19 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/27aaede86645e84f57f5bf272b0790d4f9436f0a [^]

Fixes issue 30942: Silently set values in the applyPromotions logic

The problem is that when a value is set in a backbone model, the 'change' event is being fired. If any event is fired while the discount algorithm is being executed, it could lead to unwanted processes being executed or wrong UI rendering updates

---
M web/org.openbravo.retail.posterminal/js/model/discounts.js
---