0030472: Stabilization: Sometimes the incoming 'creationDate' is not correct

# HG changeset patch
# User Rafa Alonso <ral@openbravo.com>
# Date 1438338717 -7200
#      Fri Jul 31 12:31:57 2015 +0200
# Node ID 8bc4e8c08ab7f01ff5df93950a605d42fa5969b9
# Parent  ecbbe2ac59b98a094810c98a735580932449909e
Fix the incoming 'creationDate' in case it is not correct

diff -r ecbbe2ac59b9 -r 8bc4e8c08ab7 web/org.openbravo.retail.posterminal/js/data/dataordersave.js
--- a/web/org.openbravo.retail.posterminal/js/data/dataordersave.js	Fri Jul 17 14:55:29 2015 +0200
+++ b/web/org.openbravo.retail.posterminal/js/data/dataordersave.js	Fri Jul 31 12:31:57 2015 +0200
@@ -69,14 +69,19 @@
           docno = this.receipt.get('documentNo'),
           isLayaway = (this.receipt.get('orderType') === 2 || this.receipt.get('isLayaway')),
           json = this.receipt.serializeToJSON(),
-          receiptId = this.receipt.get('id'),
-          creationDate = this.receipt.get('creationDate') || new Date();
+          receiptId = this.receipt.get('id');
 
       if (this.receipt.get('isbeingprocessed') === 'Y') {
         //The receipt has already been sent, it should not be sent again
         return;
       }
 
+      var creationDate = this.receipt.get('creationDate');
+      if (!creationDate || !creationDate.getTimezoneOffset) {
+        OB.info("Ticket closed: 'creationDate' set to '" + new Date() + "' (was '" + creationDate + "')");
+        creationDate = new Date();
+      }
+
       this.receipt.set('hasbeenpaid', 'Y');
 
       OB.trace('Executing pre order save hook.');

# HG changeset patch
# User Rafa Alonso <ral@openbravo.com>
# Date 1438346819 -7200
#      Fri Jul 31 14:46:59 2015 +0200
# Node ID c8a01eb495fed346c92a2e8ab7864d54c5ee0994
# Parent  8bc4e8c08ab7f01ff5df93950a605d42fa5969b9
Fix the incoming 'creationDate' in case it is not correct (multiorders)

diff -r 8bc4e8c08ab7 -r c8a01eb495fe web/org.openbravo.retail.posterminal/js/data/dataordersave.js
--- a/web/org.openbravo.retail.posterminal/js/data/dataordersave.js	Fri Jul 31 12:31:57 2015 +0200
+++ b/web/org.openbravo.retail.posterminal/js/data/dataordersave.js	Fri Jul 31 14:46:59 2015 +0200
@@ -219,14 +219,14 @@
           docno = this.receipt.get('documentNo'),
           isLayaway = (this.receipt.get('orderType') === 2 || this.receipt.get('isLayaway')),
           json = this.receipt.serializeToJSON(),
-          receiptId = this.receipt.get('id'),
-          creationDate = this.receipt.get('creationDate') || new Date();
+          receiptId = this.receipt.get('id');
 
-      // issue 29164: sometimes, the quotations are sync without creation date
-      if (creationDate === "Invalid Date") {
+      var creationDate = this.receipt.get('creationDate');
+      if (!creationDate || !creationDate.getTimezoneOffset) {
+        OB.info("Multiorders ticket closed: 'creationDate' set to '" + new Date() + "' (was '" + creationDate + "')");
         creationDate = new Date();
       }
-
+      
       this.receipt.set('creationDate', creationDate);
       this.receipt.set('hasbeenpaid', 'Y');
       this.context.get('multiOrders').trigger('integrityOk', this.receipt);

# HG changeset patch
# User Rafa Alonso <ral@openbravo.com>
# Date 1438628451 -7200
#      Mon Aug 03 21:00:51 2015 +0200
# Node ID 80a83ac322e88a300535e5ab9c90fe2eca0db210
# Parent  71af5c2bd0119390d1c5a6007f5f90a792ee1e16
Related to issue 30472: The receipt information is frozen when the receipt is closed

diff -r 71af5c2bd011 -r 80a83ac322e8 web/org.openbravo.retail.posterminal/js/data/dataordersave.js
--- a/web/org.openbravo.retail.posterminal/js/data/dataordersave.js	Tue Aug 04 12:10:47 2015 +0200
+++ b/web/org.openbravo.retail.posterminal/js/data/dataordersave.js	Mon Aug 03 21:00:51 2015 +0200
@@ -93,7 +93,6 @@
           return true;
         }
         var receipt = args.context.receipt,
-            auxReceipt = new OB.Model.Order(),
             currentDocNo = receipt.get('documentNo') || docno;
 
         OB.trace('Execution of pre order save hook OK.');
@@ -128,14 +127,20 @@
         receipt.set('json', JSON.stringify(receipt.serializeToJSON()));
 
         OB.trace('Calculationg cashup information.');
+        
+        var auxReceipt = new OB.Model.Order();
+        auxReceipt.clearWith(receipt);
+        var auxReceipt2 = new OB.Model.Order();
+        auxReceipt2.clearWith(receipt);
+        var auxReceipt3 = new OB.Model.Order();
+        auxReceipt3.clearWith(receipt);
 
-        auxReceipt.clearWith(receipt);
         OB.Dal.transaction(function (tx) {
           OB.UTIL.cashUpReport(auxReceipt, function () {
             OB.UTIL.calculateCurrentCash(null, tx);
-            OB.MobileApp.model.updateDocumentSequenceWhenOrderSaved(receipt.get('documentnoSuffix'), receipt.get('quotationnoSuffix'), function () {
+            OB.MobileApp.model.updateDocumentSequenceWhenOrderSaved(auxReceipt2.get('documentnoSuffix'), auxReceipt2.get('quotationnoSuffix'), function () {
               OB.trace('Saving receipt.');
-              OB.Dal.saveInTransaction(tx, receipt);
+              OB.Dal.saveInTransaction(tx, auxReceipt2);
             }, tx);
           }, tx);
         }, null, function () {
@@ -171,7 +176,7 @@
 
             OB.MobileApp.model.runSyncProcess(function () {
               OB.UTIL.HookManager.executeHooks('OBPOS_PostSyncReceipt', {
-                receipt: auxReceipt
+                receipt: auxReceipt3
               }, function (args) {
                 successCallback();
                 if (eventParams && eventParams.callback) {
@@ -180,7 +185,7 @@
               });
             }, function () {
               OB.UTIL.HookManager.executeHooks('OBPOS_PostSyncReceipt', {
-                receipt: auxReceipt
+                receipt: auxReceipt3
               }, function (args) {
                 if (eventParams && eventParams.callback) {
                   eventParams.callback();

# HG changeset patch
# User Rafa Alonso <ral@openbravo.com>
# Date 1438683047 -7200
#      Tue Aug 04 12:10:47 2015 +0200
# Node ID 71af5c2bd0119390d1c5a6007f5f90a792ee1e16
# Parent  ecbbe2ac59b98a094810c98a735580932449909e
Related to issue 30472: Added log entries when the 'creationDate' is updated

diff -r ecbbe2ac59b9 -r 71af5c2bd011 web/org.openbravo.retail.posterminal/js/model/order.js
--- a/web/org.openbravo.retail.posterminal/js/model/order.js	Fri Jul 17 14:55:29 2015 +0200
+++ b/web/org.openbravo.retail.posterminal/js/model/order.js	Tue Aug 04 12:10:47 2015 +0200
@@ -244,6 +244,17 @@
     local: true,
     _id: 'modelorder',
     initialize: function (attributes) {
+      // check if the creationDate is set to an incorrect value and get the stacktrace information
+      this.on('change:creationDate', function () {
+        var newDate = this.get('creationDate');
+        var message = "'creationDate' changed to " + newDate + (!newDate ? "" : ". getTimezoneOffset: '" + !!newDate.getTimezoneOffset) + "'. Stack: " + OB.UTIL.getStackTrace('_.extend.set', false);
+        if (newDate && !newDate.getTimezoneOffset) {
+          OB.error(message);
+        } else {
+          OB.info(message);
+        }
+      }, this);
+
       var orderId;
       if (attributes && attributes.id && attributes.json) {
         // The attributes of the order are stored in attributes.json

# HG changeset patch
# User Rafa Alonso <ral@openbravo.com>
# Date 1438683229 -7200
#      Tue Aug 04 12:13:49 2015 +0200
# Node ID c3cb2e06388ead65d96b9ab15c2c84463f84c396
# Parent  80a83ac322e88a300535e5ab9c90fe2eca0db210
Related to issue 30472: Correct order in the actions executed when the ticket is closed

diff -r 80a83ac322e8 -r c3cb2e06388e web/org.openbravo.retail.posterminal/js/data/dataordersave.js
--- a/web/org.openbravo.retail.posterminal/js/data/dataordersave.js	Mon Aug 03 21:00:51 2015 +0200
+++ b/web/org.openbravo.retail.posterminal/js/data/dataordersave.js	Tue Aug 04 12:13:49 2015 +0200
@@ -197,12 +197,13 @@
             OB.trace('Execution Sync process.');
 
             //If there are no elements in the hook, we can execute the callback asynchronusly with the synchronization process
-            OB.MobileApp.model.runSyncProcess(function () {
-              successCallback(model);
-            });
+            successCallback(model);
             if (eventParams && eventParams.callback) {
               eventParams.callback();
             }
+            OB.MobileApp.model.runSyncProcess(function () {
+              OB.debug("Ticket closed: runSyncProcess executed");
+            });
           }
         });
       });