Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030472Retail ModulesWeb POSpublic2015-07-31 12:382015-09-18 15:10
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q4Fixed in VersionRR15Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030472: Stabilization: Sometimes the incoming 'creationDate' is not correct
DescriptionSometimes the incoming 'creationDate' field has something but is not a valid date or, at least, it does not have the 'timezoneOffset' method

Notice that the incoming 'creationDate' is considered valid if it is null

When an order with this bug reaches the server, it has these missing fields:
  timezoneOffset
  obposCreatedabsolute
  obposAppCashup

This are new fields that are added in the 'closed' event of the ticket, in the dataordersave.js file
Steps To ReproduceUnknown
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0029164 closed malsasua quotations are not synced: creationdate is null 
depends on defect 0030823 closed Orekaria Sometimes the Id of the order model is null 
blocks defect 0030603RR15Q4 closed Orekaria Stabilization: RR15Q4 related issues 
blocks defect 0030636RR15Q4 closed mario_castello [UX] The date in the receipt is not correctly formatted 
blocks defect 0030713 closed mario_castello dateorder is set when the ticket is created in WebPOS not when it is processed 
Attached Filespatch 4683.patch (1,503) 2015-07-31 12:39
https://issues.openbravo.com/file_download.php?file_id=8326&type=bug
patch 4684 (multiorders).patch (1,583) 2015-07-31 14:47
https://issues.openbravo.com/file_download.php?file_id=8328&type=bug
patch 4683 (fix candidate - freeze receipt).patch (2,764) 2015-08-04 12:28
https://issues.openbravo.com/file_download.php?file_id=8336&type=bug
patch 4684 (fix candidate - log on creationDate change).patch (1,395) 2015-08-04 12:28
https://issues.openbravo.com/file_download.php?file_id=8337&type=bug
patch 4685 (fix candidate - correct actions order).patch (1,258) 2015-08-04 12:28
https://issues.openbravo.com/file_download.php?file_id=8338&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-07-31 12:38OrekariaNew Issue
2015-07-31 12:38OrekariaAssigned To => Orekaria
2015-07-31 12:38OrekariaTriggers an Emergency Pack => No
2015-07-31 12:39OrekariaFile Added: 4683.patch
2015-07-31 12:42OrekariaRelationship addedrelated to 0029164
2015-07-31 12:44OrekariaSummarySometimes the incomming 'creationDate' is not correct => Sometimes the incoming 'creationDate' is not correct
2015-07-31 12:44OrekariaDescription Updatedbug_revision_view_page.php?rev_id=9128#r9128
2015-07-31 12:48OrekariaDescription Updatedbug_revision_view_page.php?rev_id=9129#r9129
2015-07-31 12:59OrekariaDescription Updatedbug_revision_view_page.php?rev_id=9130#r9130
2015-07-31 14:36OrekariaFile Added: 4684.patch
2015-07-31 14:47OrekariaFile Deleted: 4684.patch
2015-07-31 14:47OrekariaFile Added: 4684 (multiorders).patch
2015-07-31 15:51OrekariaFile Added: 4974 (fix candidate).patch
2015-07-31 22:15hgbotCheckin
2015-07-31 22:15hgbotNote Added: 0079158
2015-07-31 22:15hgbotCheckin
2015-07-31 22:15hgbotNote Added: 0079159
2015-07-31 22:59hgbotCheckin
2015-07-31 22:59hgbotNote Added: 0079160
2015-08-03 21:02OrekariaFile Added: 4809 (fix candidate 2: frozenReceipt).patch
2015-08-04 12:28OrekariaFile Deleted: 4974 (fix candidate).patch
2015-08-04 12:28OrekariaFile Deleted: 4809 (fix candidate 2: frozenReceipt).patch
2015-08-04 12:28OrekariaFile Added: 4683 (fix candidate - freeze receipt).patch
2015-08-04 12:28OrekariaFile Added: 4684 (fix candidate - log on creationDate change).patch
2015-08-04 12:28OrekariaFile Added: 4685 (fix candidate - correct actions order).patch
2015-08-05 09:42hgbotCheckin
2015-08-05 09:42hgbotNote Added: 0079195
2015-08-05 21:24OrekariaNote Added: 0079206
2015-08-06 13:21hgbotCheckin
2015-08-06 13:21hgbotNote Added: 0079220
2015-08-06 13:21hgbotStatusnew => resolved
2015-08-06 13:21hgbotResolutionopen => fixed
2015-08-06 13:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/76f9919b796601dce75e86a204447a9005730a83 [^]
2015-08-06 13:21hgbotCheckin
2015-08-06 13:21hgbotNote Added: 0079221
2015-08-06 13:21hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/76f9919b796601dce75e86a204447a9005730a83 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c9df149341181f862a4cf37679cb68f67d2c3df9 [^]
2015-08-06 13:32OrekariaNote Added: 0079222
2015-08-06 13:32OrekariaStatusresolved => new
2015-08-06 13:32OrekariaResolutionfixed => open
2015-08-06 23:56OrekariaDescription Updatedbug_revision_view_page.php?rev_id=9169#r9169
2015-08-06 23:56OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=9171#r9171
2015-08-06 23:57OrekariaDescription Updatedbug_revision_view_page.php?rev_id=9172#r9172
2015-08-19 12:37OrekariaRelationship addedblocks 0030603
2015-08-19 18:30OrekariaTarget Version => RR15Q4
2015-08-19 18:30OrekariaSummarySometimes the incoming 'creationDate' is not correct => Stabilization: Sometimes the incoming 'creationDate' is not correct
2015-08-23 11:55OrekariaRelationship addedblocks 0030636
2015-08-23 11:56OrekariaStatusnew => scheduled
2015-08-23 11:57OrekariaNote Added: 0079628
2015-08-23 11:57OrekariaStatusscheduled => resolved
2015-08-23 11:57OrekariaFixed in Version => RR15Q4
2015-08-23 11:57OrekariaResolutionopen => fixed
2015-09-10 09:56OrekariaRelationship addedblocks 0030713
2015-09-16 22:48OrekariaRelationship addeddepends on 0030823
2015-09-17 23:15hgbotCheckin
2015-09-17 23:15hgbotNote Added: 0080474
2015-09-18 15:10marvintmReview Assigned To => marvintm
2015-09-18 15:10marvintmStatusresolved => closed

Notes
(0079158)
hgbot   
2015-07-31 22:15   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 20f7e5bc5a6252af128ca7903f6e74448c2246df
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Fri Jul 31 17:27:17 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/20f7e5bc5a6252af128ca7903f6e74448c2246df [^]

Related to issue 30472: JsLint: removed unused code

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0079159)
hgbot   
2015-07-31 22:15   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8a93ba46cae0a570aa3d11966b3fceee7d34bdb2
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Fri Jul 31 14:45:47 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8a93ba46cae0a570aa3d11966b3fceee7d34bdb2 [^]

Related to issue 30472: Fix the incoming 'creationDate' in case it is not valid

The problem is that, in some cases (to be identified), the content of the 'creationDate' field is not null and not a valid date. If the 'creationDate' is not valid, the flow fails to retrieve its 'timezoneOffset' and a javascript error is risen


This patch verifies that the 'creationDate' has a valid date

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---
(0079160)
hgbot   
2015-07-31 22:59   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0672435b95200b2c9fe6e2ba9fd04c9ec9c552d0
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Fri Jul 31 22:58:24 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0672435b95200b2c9fe6e2ba9fd04c9ec9c552d0 [^]

Related to issue 30472: removed rogue error ยป info

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---
(0079195)
hgbot   
2015-08-05 09:42   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: f10b2603dcbfbe00eaddd10588d109a928f2c9f1
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Tue Aug 04 18:12:49 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f10b2603dcbfbe00eaddd10588d109a928f2c9f1 [^]

Related to issue 30472: JsLint: removed unused code

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0079206)
Orekaria   
2015-08-05 21:24   
The previous changeset should had been associated to the issue 30450
(0079220)
hgbot   
2015-08-06 13:21   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 76f9919b796601dce75e86a204447a9005730a83
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Thu Aug 06 12:08:08 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/76f9919b796601dce75e86a204447a9005730a83 [^]

Fixes issue 30472: The 'creationDate' has been normalized

The problem was that the dates were not saved as string and a Date.toString() value was saved to the database

Thia fix done for the 'creationDate' should be done to the 'orderDate' as it is suffering similar issues

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0079221)
hgbot   
2015-08-06 13:21   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: c9df149341181f862a4cf37679cb68f67d2c3df9
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Wed Aug 05 22:42:18 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c9df149341181f862a4cf37679cb68f67d2c3df9 [^]

Fixes issue 30472: Added 'OB.I18N.normalizeDate'

This method takes an argument that is supposed to be a date and returns a valid date string or null if the object is not a valid date

---
M web/org.openbravo.mobile.core/source/utils/ob-i18n.js
---
(0079222)
Orekaria   
2015-08-06 13:32   
Please note that now, the receipts can show the date as an ISO string. This should be fixed in this issue or create another related issue if this one does not include it
(0079628)
Orekaria   
2015-08-23 11:57   
New issue created for the visual formatting

https://issues.openbravo.com/view.php?id=30636 [^]
(0080474)
hgbot   
2015-09-17 23:15   
Repository: tools/automation/pi-mobile
Changeset: 84eadd30e9374e06a2169fb5b1a68f82aafb34de
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Thu Sep 17 18:47:24 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/84eadd30e9374e06a2169fb5b1a68f82aafb34de [^]

Verifies issue 30472: Added the 'VerifyCreationDateIsInISOFormat' test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/VerifyCreationDateIsInISOFormat.java
---