Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0029913 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] Z. Others | major | always | 2015-05-18 13:32 | 2015-05-25 18:01 | |||
Reporter | maite | View Status | public | |||||
Assigned To | umartirena | |||||||
Priority | immediate | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | 0fd6131c786a | ||||
Projection | none | ETA | none | Target Version | 3.0PR15Q3 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | vmromanos | |||||||
OBNetwork customer | OBPS | |||||||
Web browser | ||||||||
Modules | Advanced Payables and Receivables Mngmt | |||||||
Support ticket | 36248 | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0029913: Wrong transaction status when deleting from reconciliation | |||||||
Description | Wrong transaction status when deleting from reconciliation | |||||||
Steps To Reproduce | 1. Access Manual Financial Account and register: - one Deposit transaction referencing a GL Item. Process and realize that status has been properly set - one Withdrawn transaction referencing a GL Item. Process and realize that status has been properly set 2. Run "Reconcile" process, select both transactions and Save 3. Realize that transaction's status has been correctly changed to "cleared" 4. Run "Reconcile" process, unselect both transaction and Save 5. Realize that transaction's status is INCORRECT. In transaction has out status and Out transaction has in status | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
|||||||||||||||
|
![]() |
|
(0077598) umartirena (viewer) 2015-05-20 13:30 |
Finally it is not going to be necessary an script as with the fix the erroneous data could be fixed. |
(0077599) umartirena (viewer) 2015-05-20 13:38 |
** Test Plan 1: In live builds, log as F&B Group Admin: 1. Open Financial Account window and select 'Caja' 2. Add 2 records in Transaction Tab: - one Deposit transaction referencing a GL Item. Process and realize that status has been properly set - one Withdrawn transaction referencing a GL Item. Process and realize that status has been properly set 3. Run "Reconcile" process, select both transactions and Save 4. Realize that transaction's status has been correctly changed to "cleared" 5. Run "Reconcile" process, unselect both transaction and Save 6. Realize that transaction's status is CORRECT. In transaction has in status and Out transaction has out status. ** Test Plan 2 (Fix wrong data): In live builds, log as F&B Group Admin: 1. Remove the patch that fixes the issue in order to be able to create wrong data. 2. Repeat steps 1-5 of Test Plan 1. 3. Realize that transaction's status is INCORRECT. In transaction has out status and Out transaction has in status. 4. Apply the patch that fixes the issue in order to be able to fix wrong data. 5. Open Financial Account window and select 'Caja'. 6. Check that the transactions created in previous steps have wrong status. 7. Run "Reconcile" process, select both transactions and Save. 8. Realize that transaction's status has been correctly changed to "cleared" 9. Run "Reconcile" process, unselect both transaction and Save 10. Realize that transaction's status is CORRECT. In transaction has in status and Out transaction has out status. |
(0077696) hgbot (developer) 2015-05-25 11:25 |
Repository: erp/devel/pi Changeset: 0fd6131c786a8e02e1c99ae9dfa810bcd4b7dc0b Author: Unai Martirena <unai.martirena <at> openbravo.com> Date: Tue May 19 13:26:52 2015 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/0fd6131c786a8e02e1c99ae9dfa810bcd4b7dc0b [^] Fixes bug 29913: Correct trx status assigned while deleting from reconciliation while checking or unchecking lines in Reconcile popup 'updateTransactionStatus' method is called to assign the proper status to the transaction. While unchecking 'Withdrawn not Cleared' or 'Deposited not Cleared' statuses has to be assigned to the transactions. This part is was wrong. When the transaction was of BP Deposit 'Withdrawn not Cleared' was being assigned and when the transaction was BP Withdrawal 'Deposited not Cleared' was being assigned. --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/Reconciliation.java --- |
(0077698) vmromanos (viewer) 2015-05-25 11:25 |
Code review + testing OK |
(0077723) hudsonbot (viewer) 2015-05-25 18:01 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8cc85f698754 [^] Maturity status: Test |
![]() |
|||
Date Modified | Username | Field | Change |
2015-05-18 13:32 | maite | New Issue | |
2015-05-18 13:32 | maite | Assigned To | => Triage Finance |
2015-05-18 13:32 | maite | OBNetwork customer | => Yes |
2015-05-18 13:32 | maite | Modules | => Core |
2015-05-18 13:32 | maite | Support ticket | => 36248 |
2015-05-18 13:32 | maite | Triggers an Emergency Pack | => No |
2015-05-18 13:34 | maite | Resolution time | => 1432504800 |
2015-05-18 13:34 | maite | Target Version | => 3.0PR15Q3 |
2015-05-18 13:34 | maite | Issue Monitored: networkb | |
2015-05-18 13:35 | maite | Modules | Core => Advanced Payables and Receivables Mngmt |
2015-05-19 16:52 | umartirena | Severity | critical => major |
2015-05-20 13:30 | umartirena | Note Added: 0077598 | |
2015-05-20 13:38 | umartirena | Note Added: 0077599 | |
2015-05-22 14:48 | vmromanos | Status | new => scheduled |
2015-05-22 14:48 | vmromanos | Assigned To | Triage Finance => umartirena |
2015-05-25 11:25 | hgbot | Checkin | |
2015-05-25 11:25 | hgbot | Note Added: 0077696 | |
2015-05-25 11:25 | hgbot | Status | scheduled => resolved |
2015-05-25 11:25 | hgbot | Resolution | open => fixed |
2015-05-25 11:25 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/0fd6131c786a8e02e1c99ae9dfa810bcd4b7dc0b [^] |
2015-05-25 11:25 | vmromanos | Review Assigned To | => vmromanos |
2015-05-25 11:25 | vmromanos | Note Added: 0077698 | |
2015-05-25 11:25 | vmromanos | Status | resolved => closed |
2015-05-25 18:01 | hudsonbot | Checkin | |
2015-05-25 18:01 | hudsonbot | Note Added: 0077723 |
Copyright © 2000 - 2009 MantisBT Group |