Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029913Openbravo ERPZ. Otherspublic2015-05-18 13:322015-05-25 18:01
Reportermaite 
Assigned Toumartirena 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q3Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerOBPS
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket36248
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029913: Wrong transaction status when deleting from reconciliation
DescriptionWrong transaction status when deleting from reconciliation
Steps To Reproduce1. Access Manual Financial Account and register:
  - one Deposit transaction referencing a GL Item. Process and realize that status has been properly set
  - one Withdrawn transaction referencing a GL Item. Process and realize that status has been properly set
2. Run "Reconcile" process, select both transactions and Save
3. Realize that transaction's status has been correctly changed to "cleared"
4. Run "Reconcile" process, unselect both transaction and Save
5. Realize that transaction's status is INCORRECT. In transaction has out status and Out transaction has in status
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00299863.0PR15Q2.2 closed umartirena Wrong transaction status when deleting from reconciliation 
depends on backport 00299873.0PR15Q1.5 closed umartirena Wrong transaction status when deleting from reconciliation 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-05-18 13:32maiteNew Issue
2015-05-18 13:32maiteAssigned To => Triage Finance
2015-05-18 13:32maiteOBNetwork customer => Yes
2015-05-18 13:32maiteModules => Core
2015-05-18 13:32maiteSupport ticket => 36248
2015-05-18 13:32maiteTriggers an Emergency Pack => No
2015-05-18 13:34maiteResolution time => 1432504800
2015-05-18 13:34maiteTarget Version => 3.0PR15Q3
2015-05-18 13:34maiteIssue Monitored: networkb
2015-05-18 13:35maiteModulesCore => Advanced Payables and Receivables Mngmt
2015-05-19 16:52umartirenaSeveritycritical => major
2015-05-20 13:30umartirenaNote Added: 0077598
2015-05-20 13:38umartirenaNote Added: 0077599
2015-05-22 14:48vmromanosStatusnew => scheduled
2015-05-22 14:48vmromanosAssigned ToTriage Finance => umartirena
2015-05-25 11:25hgbotCheckin
2015-05-25 11:25hgbotNote Added: 0077696
2015-05-25 11:25hgbotStatusscheduled => resolved
2015-05-25 11:25hgbotResolutionopen => fixed
2015-05-25 11:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0fd6131c786a8e02e1c99ae9dfa810bcd4b7dc0b [^]
2015-05-25 11:25vmromanosReview Assigned To => vmromanos
2015-05-25 11:25vmromanosNote Added: 0077698
2015-05-25 11:25vmromanosStatusresolved => closed
2015-05-25 18:01hudsonbotCheckin
2015-05-25 18:01hudsonbotNote Added: 0077723

Notes
(0077598)
umartirena   
2015-05-20 13:30   
Finally it is not going to be necessary an script as with the fix the erroneous data could be fixed.
(0077599)
umartirena   
2015-05-20 13:38   
** Test Plan 1:


In live builds, log as F&B Group Admin:

1. Open Financial Account window and select 'Caja'
2. Add 2 records in Transaction Tab:
  - one Deposit transaction referencing a GL Item. Process and realize that status has been properly set
  - one Withdrawn transaction referencing a GL Item. Process and realize that status has been properly set
3. Run "Reconcile" process, select both transactions and Save
4. Realize that transaction's status has been correctly changed to "cleared"
5. Run "Reconcile" process, unselect both transaction and Save
6. Realize that transaction's status is CORRECT. In transaction has in status and Out transaction has out status.



** Test Plan 2 (Fix wrong data):


In live builds, log as F&B Group Admin:

1. Remove the patch that fixes the issue in order to be able to create wrong data.
2. Repeat steps 1-5 of Test Plan 1.
3. Realize that transaction's status is INCORRECT. In transaction has out status and Out transaction has in status.
4. Apply the patch that fixes the issue in order to be able to fix wrong data.
5. Open Financial Account window and select 'Caja'.
6. Check that the transactions created in previous steps have wrong status.
7. Run "Reconcile" process, select both transactions and Save.
8. Realize that transaction's status has been correctly changed to "cleared"
9. Run "Reconcile" process, unselect both transaction and Save
10. Realize that transaction's status is CORRECT. In transaction has in status and Out transaction has out status.
(0077696)
hgbot   
2015-05-25 11:25   
Repository: erp/devel/pi
Changeset: 0fd6131c786a8e02e1c99ae9dfa810bcd4b7dc0b
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Tue May 19 13:26:52 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0fd6131c786a8e02e1c99ae9dfa810bcd4b7dc0b [^]

Fixes bug 29913: Correct trx status assigned while deleting from reconciliation

while checking or unchecking lines in Reconcile popup 'updateTransactionStatus' method is called to assign the proper status to the transaction. While unchecking 'Withdrawn not Cleared' or 'Deposited not Cleared' statuses has to be assigned to the transactions. This part is was wrong. When the transaction was of BP Deposit 'Withdrawn not Cleared' was being assigned and when the transaction was BP Withdrawal 'Deposited not Cleared' was being assigned.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/Reconciliation.java
---
(0077698)
vmromanos   
2015-05-25 11:25   
Code review + testing OK
(0077723)
hudsonbot   
2015-05-25 18:01   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8cc85f698754 [^]
Maturity status: Test