0002974: Grid export bug

Description

There is a bug when exporting a grid to excel that puts numbers in Openbravo as Strings in excel. This makes impossible to use the excels for operations as the strings cannot be added, multiplied....
If the column is set in Openbravo as Integer, when exporting the grid to excel by Jasper Reports you will have a nice number, but if the column is set as Number in Openbravo, when exporting to excel it will be set as a string in the excel, making it impossible to use it as a number.

For fixing this you have to open the class org.openbravo.erpCommon.utility.ExportGrid.java and go to these lines

if (log4j.isDebugEnabled()) log4j.debug("Add column: " + columnname + " width: " + headers[i].getField("width") + " reference: " + headers[i].getField("adReferenceId"));
        totalWidth += Integer.valueOf(headers[i].getField("width"));
        Class<?> fieldClass = String.class;
       /* if (headers[i].getField("adReferenceId").equals("11")) fieldClass = Integer.class;
        else*/ if (headers[i].getField("adReferenceId").equals("11") || headers[i].getField("adReferenceId").equals("12") || headers[i].getField("adReferenceId").equals("800008") || headers[i].getField("adReferenceId").equals("800019")) {
          fieldClass = Double.class;

As you see, the java converts all the column types to String except for the ones defined in ad_reference as 11 (Integer), 12 (Amount), 800008 (Price),800019 (General Quantity).
Now, we need that this java would convert the columns defined as "Number" to convert them to BigDecimal (number with comma). The code for the java, then it will be:

if (log4j.isDebugEnabled()) log4j.debug("Add column: " + columnname + " width: " + headers[i].getField("width") + " reference: " + headers[i].getField("adReferenceId"));
        totalWidth += Integer.valueOf(headers[i].getField("width"));
        Class<?> fieldClass = String.class;
       /* if (headers[i].getField("adReferenceId").equals("11")) fieldClass = Integer.class;
        else*/ if (headers[i].getField("adReferenceId").equals("11") || headers[i].getField("adReferenceId").equals("12") || headers[i].getField("adReferenceId").equals("800008") || headers[i].getField("adReferenceId").equals("800019")) {
          fieldClass = Double.class;
        }/* If Number column is detected, put BigDecimal in the excel for a good export */
        else if (headers[i].getField("adReferenceId").equals("22")) {
           fieldClass = java.math.BigDecimal.class;
        }

I also would suggest that is not best practice to hardcode the ad_reference_id like 11, 12, 800008, 800019, 22 .... But thats another history :)

Notes
(0003694) gorkaion (viewer) 2008-05-26 19:09 edited on: 2008-06-12 09:26	Logged In: YES user_id=1500690 Originator: NO Fixed on trunk revision 4565 All references but Integer now use the BigDecimal class in the jasper reports template.

(0006563) user71 2005-06-01 00:00 edited on: 2008-06-12 09:43	This bug was originally reported in SourceForge bug tracker and then migrated to Mantis. You can see the original bug report in: https://sourceforge.net/support/tracker.php?aid=1968033 [^]

Issue History
Date Modified	Username	Field	Change
2008-06-18 19:00	plujan	Status	resolved => closed

Relationships [ Relation Graph ] [ Dependency Graph ]