Openbravo Issue Tracking System - Openbravo ERP | |||||
| View Issue Details | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0002974 | Openbravo ERP | Z. Others | public | 2008-05-20 17:19 | 2008-06-18 19:00 |
| Reporter | user71 | ||||
| Assigned To | gorkaion | ||||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | OS | 5 | OS Version | ||
| Product Version | |||||
| Target Version | Fixed in Version | 2.40alpha-r3 | |||
| Merge Request Status | |||||
| Review Assigned To | |||||
| OBNetwork customer | No | ||||
| Web browser | |||||
| Modules | Core | ||||
| Support ticket | |||||
| Regression level | |||||
| Regression date | |||||
| Regression introduced in release | |||||
| Regression introduced by commit | |||||
| Triggers an Emergency Pack | No | ||||
| Summary | 0002974: Grid export bug | ||||
| Description | There is a bug when exporting a grid to excel that puts numbers in Openbravo as Strings in excel. This makes impossible to use the excels for operations as the strings cannot be added, multiplied.... If the column is set in Openbravo as Integer, when exporting the grid to excel by Jasper Reports you will have a nice number, but if the column is set as Number in Openbravo, when exporting to excel it will be set as a string in the excel, making it impossible to use it as a number. For fixing this you have to open the class org.openbravo.erpCommon.utility.ExportGrid.java and go to these lines if (log4j.isDebugEnabled()) log4j.debug("Add column: " + columnname + " width: " + headers[i].getField("width") + " reference: " + headers[i].getField("adReferenceId")); totalWidth += Integer.valueOf(headers[i].getField("width")); Class<?> fieldClass = String.class; /* if (headers[i].getField("adReferenceId").equals("11")) fieldClass = Integer.class; else*/ if (headers[i].getField("adReferenceId").equals("11") || headers[i].getField("adReferenceId").equals("12") || headers[i].getField("adReferenceId").equals("800008") || headers[i].getField("adReferenceId").equals("800019")) { fieldClass = Double.class; As you see, the java converts all the column types to String except for the ones defined in ad_reference as 11 (Integer), 12 (Amount), 800008 (Price),800019 (General Quantity). Now, we need that this java would convert the columns defined as "Number" to convert them to BigDecimal (number with comma). The code for the java, then it will be: if (log4j.isDebugEnabled()) log4j.debug("Add column: " + columnname + " width: " + headers[i].getField("width") + " reference: " + headers[i].getField("adReferenceId")); totalWidth += Integer.valueOf(headers[i].getField("width")); Class<?> fieldClass = String.class; /* if (headers[i].getField("adReferenceId").equals("11")) fieldClass = Integer.class; else*/ if (headers[i].getField("adReferenceId").equals("11") || headers[i].getField("adReferenceId").equals("12") || headers[i].getField("adReferenceId").equals("800008") || headers[i].getField("adReferenceId").equals("800019")) { fieldClass = Double.class; }/* If Number column is detected, put BigDecimal in the excel for a good export */ else if (headers[i].getField("adReferenceId").equals("22")) { fieldClass = java.math.BigDecimal.class; } I also would suggest that is not best practice to hardcode the ad_reference_id like 11, 12, 800008, 800019, 22 .... But thats another history :) | ||||
| Steps To Reproduce | |||||
| Proposed Solution | |||||
| Additional Information | |||||
| Tags | No tags attached. | ||||
| Relationships | |||||
| Attached Files | |||||
| Issue History | |||||
| Date Modified | Username | Field | Change | ||
| 2008-06-18 19:00 | plujan | Status | resolved => closed | ||
| Notes | |||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||