Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029670
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminoralways2015-04-22 14:162015-05-19 16:15
ReporterguillermogilView Statuspublic 
Assigned Tomarvintm 
PrioritynormalResolutionfixedFixed in VersionRR15Q3
StatusclosedFix in branchFixed in SCM revision2dd368c5b513
ProjectionnoneETAnoneTarget Versionpi
OSLinux 64 bitDatabasePostgreSQLJava version6
OS Version14.10Database version9.3Ant version
Product VersionpiSCM revision 
Review Assigned ToOrekaria
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0029670: WebPOS does not work on the lastest beta Chrome release (43)

DescriptionThere has been an API restriction to webSQL calls on the lastest beta Chrome release (43). on the lastest stable chrome version (42) it works properly.

Uncaught TypeError: Failed to execute 'executeSql' on 'SQLTransaction': The 2nd argument is neither an array, nor does it have indexed properties.

It is looking for an empty array but it is receiving an empty object.
Steps To ReproduceInstall beta Chrome release
Try to log in.
Proposed SolutionDo not use empty objects, instead use empty arrays.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0029672RR15Q2.1 closedguillermogil WebPOS does not work on the lastest beta Chrome release (43) 
depends on backport 0029928RR15Q1.4 closedOrekaria WebPOS does not work on the lastest beta Chrome release (43) 
caused by defect 0029055RR15Q2 closedmarvintm Web POS doesn't handle update of local database tables correctly 

-  Notes
(0076689)
hgbot (developer)
2015-04-22 14:23

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: da484494aa9c64b3569ae00a80661cfe9ed8db7f
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Wed Apr 22 14:18:52 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/da484494aa9c64b3569ae00a80661cfe9ed8db7f [^]

Fixed issue 29670: WebPOS does not work on Chrome 43

There has been an API restriction to webSQL calls on the lastest beta Chrome release (43) on the lastest stable chrome version (42) it works properly.
Just call to the executeSQL with an empty array instead of and object

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0076693)
Orekaria (administrator)
2015-04-22 15:12

 Backport required
(0076851)
Orekaria (administrator)
2015-04-29 10:31

 All the flow until a method of signature "executeSql(x, y," where y can be any parameter arrived, must be analyzed
(0077503)
hgbot (developer)
2015-05-15 17:20

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: ece27b8d83776f24701bebc3fc8470adee9eaf4c
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri May 15 17:17:34 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ece27b8d83776f24701bebc3fc8470adee9eaf4c [^]

Fixed issue 29670. Changed ob-dal so that it doesn't fail in Chrome v43.
- All possible calls to executeSql with parameter {} have been replaced with [].

---
M web/org.openbravo.mobile.core/source/data/ob-cache.js
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0077531)
Orekaria (administrator)
2015-05-18 15:10

 1) there is no need to modify ob-cache.js

2) the following change is out of the local database flow:

  params = enyo.clone(_.isEmpty(whereClause) ? [] : whereClause);


legibility and maintenance (aka facilitate the other's work)

  3) unify what we do when there is no value, null or []
      e.g: initCache is sending a null value. we have to always send the same one in the absence of value, null or []
  
  4) call them all the same way once they have been 'filtered', params or filteredParams. As filteredParams is necessary, we could use that name once the params have been prepared. then we would easily see where they have been prepared or not
  
  5) use the same assignment approach:

      params = _.isEmpty(whereClause.params) ? [] : whereClause.params;

   or
      params = whereClause.params;
      if (_.isEmpty(params)) {
        params = [];
      }
(0077543)
hgbot (developer)
2015-05-18 18:10

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 2dd368c5b513019e5ce47143aaab643f688d447e
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon May 18 18:09:40 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2dd368c5b513019e5ce47143aaab643f688d447e [^]

Fixed issue 29670. Applied several items of the code-review feedback:
- Removed changes to ob-cache as they are not necessary
- Standardized variable names and calls to identify when wrong parameter is passed
- Removed transformation done out of the local database code
- Replaced some nulls by [] to unify empty parameter object

---
M web/org.openbravo.mobile.core/source/data/ob-cache.js
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0077550)
hgbot (developer)
2015-05-19 09:19

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 71f7634dd5298afacf6aae558cb465f26c3f384d
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue May 19 09:19:17 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/71f7634dd5298afacf6aae558cb465f26c3f384d [^]

Related to issue 29670. Fixed small typo.

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0077560)
Orekaria (administrator)
2015-05-19 10:23

 Opened to create backport to RR15Q1.4
(0077561)
hgbot (developer)
2015-05-19 10:28

 Repository: retail/backports/3.0RR15Q1.4/org.openbravo.mobile.core
Changeset: 7cd6c5ef81a64871ccf67c7bc3b8d97743a69f1d
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue May 19 10:27:17 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q1.4/org.openbravo.mobile.core/rev/7cd6c5ef81a64871ccf67c7bc3b8d97743a69f1d [^]

Fixes issue 29928, backport of issue 29670: WebPOS does not work on Chrome 43

There has been an API restriction to webSQL calls on the lastest beta Chrome release (43) on the lastest stable chrome version (42) it works properly.
Just call to the executeSQL with an empty array instead of and object
* * *
Fixes issue 29672, backport of issue 29670. Changed ob-dal so that it doesn't fail in Chrome v43 (I - III)
- All possible calls to executeSql with parameter {} have been replaced with [].
Applied several items of the code-review feedback:
- Removed changes to ob-cache as they are not necessary
- Standardized variable names and calls to identify when wrong parameter is passed
- Removed transformation done out of the local database code
- Replaced some nulls by [] to unify empty parameter object
Fixed small typo.

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0077564)
hgbot (developer)
2015-05-19 10:28

 Repository: retail/backports/3.0RR15Q2.1/org.openbravo.mobile.core
Changeset: 3436b3bcb11d1a1d96c013ad1f2a83749c1c19b9
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Wed Apr 22 14:18:52 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q2.1/org.openbravo.mobile.core/rev/3436b3bcb11d1a1d96c013ad1f2a83749c1c19b9 [^]

Fixes issue 29672, backport of issue 29670: WebPOS does not work on Chrome 43

There has been an API restriction to webSQL calls on the lastest beta Chrome release (43) on the lastest stable chrome version (42) it works properly.
Just call to the executeSQL with an empty array instead of and object

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0077566)
hgbot (developer)
2015-05-19 10:28

 Repository: retail/backports/3.0RR15Q2.1/org.openbravo.mobile.core
Changeset: 06774cc5ca24685826d8c41803477f9ca092d978
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri May 15 17:17:34 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q2.1/org.openbravo.mobile.core/rev/06774cc5ca24685826d8c41803477f9ca092d978 [^]

Fixes issue 29672, backport of issue 29670. Changed ob-dal so that it doesn't fail in Chrome v43 (I - III)
- All possible calls to executeSql with parameter {} have been replaced with [].
Applied several items of the code-review feedback:
- Removed changes to ob-cache as they are not necessary
- Standardized variable names and calls to identify when wrong parameter is passed
- Removed transformation done out of the local database code
- Replaced some nulls by [] to unify empty parameter object
Fixed small typo.

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---

- Issue History
Date Modified Username Field Change
2015-04-22 14:16 guillermogil New Issue
2015-04-22 14:16 guillermogil Assigned To => guillermogil
2015-04-22 14:16 guillermogil Triggers an Emergency Pack => No
2015-04-22 14:16 guillermogil Review Assigned To => marvintm
2015-04-22 14:23 hgbot Checkin
2015-04-22 14:23 hgbot Note Added: 0076689
2015-04-22 14:23 hgbot Status new => resolved
2015-04-22 14:23 hgbot Resolution open => fixed
2015-04-22 14:23 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/da484494aa9c64b3569ae00a80661cfe9ed8db7f [^]
2015-04-22 15:10 Orekaria Relationship added caused by 0029478
2015-04-22 15:11 Orekaria Relationship deleted caused by 0029478
2015-04-22 15:11 Orekaria Relationship added caused by 0029055
2015-04-22 15:12 Orekaria Note Added: 0076693
2015-04-22 15:12 Orekaria Status resolved => new
2015-04-22 15:12 Orekaria Resolution fixed => open
2015-04-22 15:12 Orekaria Status new => scheduled
2015-04-22 15:12 Orekaria Status scheduled => resolved
2015-04-22 15:12 Orekaria Fixed in Version => RR15Q3
2015-04-22 15:12 Orekaria Resolution open => fixed
2015-04-29 10:32 Orekaria Note Added: 0076851
2015-04-29 10:32 Orekaria Status resolved => new
2015-04-29 10:32 Orekaria Resolution fixed => open
2015-04-29 10:32 Orekaria Fixed in Version RR15Q3 =>
2015-05-15 17:20 hgbot Checkin
2015-05-15 17:20 hgbot Note Added: 0077503
2015-05-15 17:20 hgbot Status new => resolved
2015-05-15 17:20 hgbot Resolution open => fixed
2015-05-15 17:20 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/da484494aa9c64b3569ae00a80661cfe9ed8db7f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ece27b8d83776f24701bebc3fc8470adee9eaf4c [^]
2015-05-18 15:08 Orekaria Assigned To guillermogil => marvintm
2015-05-18 15:10 Orekaria Assigned To marvintm => Orekaria
2015-05-18 15:10 Orekaria Note Added: 0077531
2015-05-18 15:10 Orekaria Status resolved => new
2015-05-18 15:10 Orekaria Resolution fixed => open
2015-05-18 18:10 hgbot Checkin
2015-05-18 18:10 hgbot Note Added: 0077543
2015-05-18 18:10 hgbot Status new => resolved
2015-05-18 18:10 hgbot Resolution open => fixed
2015-05-18 18:10 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ece27b8d83776f24701bebc3fc8470adee9eaf4c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2dd368c5b513019e5ce47143aaab643f688d447e [^]
2015-05-19 09:19 hgbot Checkin
2015-05-19 09:19 hgbot Note Added: 0077550
2015-05-19 10:23 Orekaria Note Added: 0077560
2015-05-19 10:23 Orekaria Status resolved => new
2015-05-19 10:23 Orekaria Resolution fixed => open
2015-05-19 10:23 Orekaria Status new => scheduled
2015-05-19 10:23 Orekaria Status scheduled => resolved
2015-05-19 10:23 Orekaria Fixed in Version => RR15Q3
2015-05-19 10:23 Orekaria Resolution open => fixed
2015-05-19 10:28 hgbot Checkin
2015-05-19 10:28 hgbot Note Added: 0077561
2015-05-19 10:28 hgbot Checkin
2015-05-19 10:28 hgbot Note Added: 0077564
2015-05-19 10:28 hgbot Checkin
2015-05-19 10:28 hgbot Note Added: 0077566
2015-05-19 16:15 Orekaria Assigned To Orekaria => marvintm
2015-05-19 16:15 Orekaria Review Assigned To marvintm => Orekaria
2015-05-19 16:15 Orekaria Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker