Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029670Retail ModulesWeb POSpublic2015-04-22 14:162015-05-19 16:15
Reporterguillermogil 
Assigned Tomarvintm 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS Version14.10
Product Versionpi 
Target VersionpiFixed in VersionRR15Q3 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0029670: WebPOS does not work on the lastest beta Chrome release (43)
DescriptionThere has been an API restriction to webSQL calls on the lastest beta Chrome release (43). on the lastest stable chrome version (42) it works properly.

Uncaught TypeError: Failed to execute 'executeSql' on 'SQLTransaction': The 2nd argument is neither an array, nor does it have indexed properties.

It is looking for an empty array but it is receiving an empty object.
Steps To ReproduceInstall beta Chrome release
Try to log in.
Proposed SolutionDo not use empty objects, instead use empty arrays.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0029672RR15Q2.1 closed guillermogil WebPOS does not work on the lastest beta Chrome release (43) 
depends on backport 0029928RR15Q1.4 closed Orekaria WebPOS does not work on the lastest beta Chrome release (43) 
caused by defect 0029055RR15Q2 closed marvintm Web POS doesn't handle update of local database tables correctly 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-04-22 14:16guillermogilNew Issue
2015-04-22 14:16guillermogilAssigned To => guillermogil
2015-04-22 14:16guillermogilTriggers an Emergency Pack => No
2015-04-22 14:16guillermogilReview Assigned To => marvintm
2015-04-22 14:23hgbotCheckin
2015-04-22 14:23hgbotNote Added: 0076689
2015-04-22 14:23hgbotStatusnew => resolved
2015-04-22 14:23hgbotResolutionopen => fixed
2015-04-22 14:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/da484494aa9c64b3569ae00a80661cfe9ed8db7f [^]
2015-04-22 15:10OrekariaRelationship addedcaused by 0029478
2015-04-22 15:11OrekariaRelationship deletedcaused by 0029478
2015-04-22 15:11OrekariaRelationship addedcaused by 0029055
2015-04-22 15:12OrekariaNote Added: 0076693
2015-04-22 15:12OrekariaStatusresolved => new
2015-04-22 15:12OrekariaResolutionfixed => open
2015-04-22 15:12OrekariaStatusnew => scheduled
2015-04-22 15:12OrekariaStatusscheduled => resolved
2015-04-22 15:12OrekariaFixed in Version => RR15Q3
2015-04-22 15:12OrekariaResolutionopen => fixed
2015-04-29 10:32OrekariaNote Added: 0076851
2015-04-29 10:32OrekariaStatusresolved => new
2015-04-29 10:32OrekariaResolutionfixed => open
2015-04-29 10:32OrekariaFixed in VersionRR15Q3 =>
2015-05-15 17:20hgbotCheckin
2015-05-15 17:20hgbotNote Added: 0077503
2015-05-15 17:20hgbotStatusnew => resolved
2015-05-15 17:20hgbotResolutionopen => fixed
2015-05-15 17:20hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/da484494aa9c64b3569ae00a80661cfe9ed8db7f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ece27b8d83776f24701bebc3fc8470adee9eaf4c [^]
2015-05-18 15:08OrekariaAssigned Toguillermogil => marvintm
2015-05-18 15:10OrekariaAssigned Tomarvintm => Orekaria
2015-05-18 15:10OrekariaNote Added: 0077531
2015-05-18 15:10OrekariaStatusresolved => new
2015-05-18 15:10OrekariaResolutionfixed => open
2015-05-18 18:10hgbotCheckin
2015-05-18 18:10hgbotNote Added: 0077543
2015-05-18 18:10hgbotStatusnew => resolved
2015-05-18 18:10hgbotResolutionopen => fixed
2015-05-18 18:10hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ece27b8d83776f24701bebc3fc8470adee9eaf4c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2dd368c5b513019e5ce47143aaab643f688d447e [^]
2015-05-19 09:19hgbotCheckin
2015-05-19 09:19hgbotNote Added: 0077550
2015-05-19 10:23OrekariaNote Added: 0077560
2015-05-19 10:23OrekariaStatusresolved => new
2015-05-19 10:23OrekariaResolutionfixed => open
2015-05-19 10:23OrekariaStatusnew => scheduled
2015-05-19 10:23OrekariaStatusscheduled => resolved
2015-05-19 10:23OrekariaFixed in Version => RR15Q3
2015-05-19 10:23OrekariaResolutionopen => fixed
2015-05-19 10:28hgbotCheckin
2015-05-19 10:28hgbotNote Added: 0077561
2015-05-19 10:28hgbotCheckin
2015-05-19 10:28hgbotNote Added: 0077564
2015-05-19 10:28hgbotCheckin
2015-05-19 10:28hgbotNote Added: 0077566
2015-05-19 16:15OrekariaAssigned ToOrekaria => marvintm
2015-05-19 16:15OrekariaReview Assigned Tomarvintm => Orekaria
2015-05-19 16:15OrekariaStatusresolved => closed

Notes
(0076689)
hgbot   
2015-04-22 14:23   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: da484494aa9c64b3569ae00a80661cfe9ed8db7f
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Wed Apr 22 14:18:52 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/da484494aa9c64b3569ae00a80661cfe9ed8db7f [^]

Fixed issue 29670: WebPOS does not work on Chrome 43

There has been an API restriction to webSQL calls on the lastest beta Chrome release (43) on the lastest stable chrome version (42) it works properly.
Just call to the executeSQL with an empty array instead of and object

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0076693)
Orekaria   
2015-04-22 15:12   
Backport required
(0076851)
Orekaria   
2015-04-29 10:31   
All the flow until a method of signature "executeSql(x, y," where y can be any parameter arrived, must be analyzed
(0077503)
hgbot   
2015-05-15 17:20   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: ece27b8d83776f24701bebc3fc8470adee9eaf4c
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri May 15 17:17:34 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ece27b8d83776f24701bebc3fc8470adee9eaf4c [^]

Fixed issue 29670. Changed ob-dal so that it doesn't fail in Chrome v43.
- All possible calls to executeSql with parameter {} have been replaced with [].

---
M web/org.openbravo.mobile.core/source/data/ob-cache.js
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0077531)
Orekaria   
2015-05-18 15:10   
1) there is no need to modify ob-cache.js

2) the following change is out of the local database flow:

  params = enyo.clone(_.isEmpty(whereClause) ? [] : whereClause);


legibility and maintenance (aka facilitate the other's work)

  3) unify what we do when there is no value, null or []
      e.g: initCache is sending a null value. we have to always send the same one in the absence of value, null or []
  
  4) call them all the same way once they have been 'filtered', params or filteredParams. As filteredParams is necessary, we could use that name once the params have been prepared. then we would easily see where they have been prepared or not
  
  5) use the same assignment approach:

      params = _.isEmpty(whereClause.params) ? [] : whereClause.params;

   or
      params = whereClause.params;
      if (_.isEmpty(params)) {
        params = [];
      }
(0077543)
hgbot   
2015-05-18 18:10   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 2dd368c5b513019e5ce47143aaab643f688d447e
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon May 18 18:09:40 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2dd368c5b513019e5ce47143aaab643f688d447e [^]

Fixed issue 29670. Applied several items of the code-review feedback:
- Removed changes to ob-cache as they are not necessary
- Standardized variable names and calls to identify when wrong parameter is passed
- Removed transformation done out of the local database code
- Replaced some nulls by [] to unify empty parameter object

---
M web/org.openbravo.mobile.core/source/data/ob-cache.js
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0077550)
hgbot   
2015-05-19 09:19   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 71f7634dd5298afacf6aae558cb465f26c3f384d
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue May 19 09:19:17 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/71f7634dd5298afacf6aae558cb465f26c3f384d [^]

Related to issue 29670. Fixed small typo.

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0077560)
Orekaria   
2015-05-19 10:23   
Opened to create backport to RR15Q1.4
(0077561)
hgbot   
2015-05-19 10:28   
Repository: retail/backports/3.0RR15Q1.4/org.openbravo.mobile.core
Changeset: 7cd6c5ef81a64871ccf67c7bc3b8d97743a69f1d
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Tue May 19 10:27:17 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q1.4/org.openbravo.mobile.core/rev/7cd6c5ef81a64871ccf67c7bc3b8d97743a69f1d [^]

Fixes issue 29928, backport of issue 29670: WebPOS does not work on Chrome 43

There has been an API restriction to webSQL calls on the lastest beta Chrome release (43) on the lastest stable chrome version (42) it works properly.
Just call to the executeSQL with an empty array instead of and object
* * *
Fixes issue 29672, backport of issue 29670. Changed ob-dal so that it doesn't fail in Chrome v43 (I - III)
- All possible calls to executeSql with parameter {} have been replaced with [].
Applied several items of the code-review feedback:
- Removed changes to ob-cache as they are not necessary
- Standardized variable names and calls to identify when wrong parameter is passed
- Removed transformation done out of the local database code
- Replaced some nulls by [] to unify empty parameter object
Fixed small typo.

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0077564)
hgbot   
2015-05-19 10:28   
Repository: retail/backports/3.0RR15Q2.1/org.openbravo.mobile.core
Changeset: 3436b3bcb11d1a1d96c013ad1f2a83749c1c19b9
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Wed Apr 22 14:18:52 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q2.1/org.openbravo.mobile.core/rev/3436b3bcb11d1a1d96c013ad1f2a83749c1c19b9 [^]

Fixes issue 29672, backport of issue 29670: WebPOS does not work on Chrome 43

There has been an API restriction to webSQL calls on the lastest beta Chrome release (43) on the lastest stable chrome version (42) it works properly.
Just call to the executeSQL with an empty array instead of and object

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0077566)
hgbot   
2015-05-19 10:28   
Repository: retail/backports/3.0RR15Q2.1/org.openbravo.mobile.core
Changeset: 06774cc5ca24685826d8c41803477f9ca092d978
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri May 15 17:17:34 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q2.1/org.openbravo.mobile.core/rev/06774cc5ca24685826d8c41803477f9ca092d978 [^]

Fixes issue 29672, backport of issue 29670. Changed ob-dal so that it doesn't fail in Chrome v43 (I - III)
- All possible calls to executeSql with parameter {} have been replaced with [].
Applied several items of the code-review feedback:
- Removed changes to ob-cache as they are not necessary
- Standardized variable names and calls to identify when wrong parameter is passed
- Removed transformation done out of the local database code
- Replaced some nulls by [] to unify empty parameter object
Fixed small typo.

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---