Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029030
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2015-02-23 17:332015-04-01 08:47
ReporterumartirenaView Statuspublic 
Assigned Toumartirena 
PriorityurgentResolutionfixedFixed in Version3.0PR15Q2
StatusclosedFix in branchFixed in SCM revision0b5abcbe72ae
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToSandrahuguet
Web browser
ModulesCore
Regression level
Regression date2014-09-23
Regression introduced in release3.0PR14Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^]
Triggers an Emergency PackNo
Summary

0029030: Match Statement Matching Algorithm fails under certain circumstances

DescriptionMatch Statement Matching Algorithm fails when a bank statement line gives an error when trying to be matched. The process when a line triggers an error should skip that line and continue with the rest of the lines until finishing the process. In this case, the process is failing and the algorithm stops.
Steps To ReproduceInstall "Invoice Matching Algorithm" module.
Go to Enterprise module management and install the dataset of the module.
Go to Financial Account window:
 * Edit "Cuenta de Banco" and assign in Matching Algorithm "Advanced Matching Algorithm".
 * Go to "Imported Bank Statement" tab and create a header:
  - Put a name and set Import Date and Transaction Date: 03/01/2015.
 * Add 2 lines:
  - Transaction Date: 03/01/2015
  - Set a Reference No.
  - Set a Business Partner.
  - Set a GL Item.
  - One with Deposit Amount 35 and the other with Withdrawal Amount 30.
 * Process The Bank Statement.

Go to Open/Close Period Control window.
 * Filter by:
   - Year 2015
   - Name Ene-15
   - Org: F&B España
 * Click on Close Period.

Go back to Financial Account window:
 * Select "Cuenta de Banco"
 * Click on Match Statement.

Realize that "Error: Session is closed!" error is obtained, when the process should theoretically finish without matching anything.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by feature request 00293903.0PR14Q4 closedSandrahuguet Reconciliation refactor project 

-  Notes
(0074875)
hgbot (developer)
2015-02-24 18:11

 Repository: erp/devel/pi
Changeset: a169e46939dbb740c385be6a202791fbe70e3c9e
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Mon Feb 23 17:47:46 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a169e46939dbb740c385be6a202791fbe70e3c9e [^]

Fixes bug 29030: Match Statement does not fail when a line throws an exception

In Matching Algorithm in Match Statement, if a line to be matched fails for any reason (period closed for example) a rollback occurs. This rollback was not being properly managed in Matching Algorithm after the refactor of Match Statement window, so the process was failing instead of skipping that line and going forward. Now it skips and the process finished successfully.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadActionHandler.java
---
(0074881)
hgbot (developer)
2015-02-24 19:13

 Repository: erp/devel/pi
Changeset: f24821411d25df6c674fed910a827788cf6fd52b
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Tue Feb 24 19:00:32 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f24821411d25df6c674fed910a827788cf6fd52b [^]

Related to bug 29030: Code review.

Fixed the copyright.
Add a clear on every 100 iterations of bankLinesSR Scrollable Results.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadActionHandler.java
---
(0074940)
hudsonbot (developer)
2015-02-25 21:22

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/96ba7b028cb7 [^]
Maturity status: Test
(0074944)
hudsonbot (developer)
2015-02-25 21:22

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/96ba7b028cb7 [^]
Maturity status: Test
(0076190)
hgbot (developer)
2015-04-01 08:05

 Repository: erp/backports/3.0PR15Q2
Changeset: 0b5abcbe72aef40665525b17f8434d740a86ade0
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Mon Feb 23 17:47:46 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/0b5abcbe72aef40665525b17f8434d740a86ade0 [^]

Fixes bug 29030: Match Statement does not fail when a line throws an exception

In Matching Algorithm in Match Statement, if a line to be matched fails for any reason (period closed for example) a rollback occurs. This rollback was not being properly managed in Matching Algorithm after the refactor of Match Statement window, so the process was failing instead of skipping that line and going forward. Now it skips and the process finished successfully.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadActionHandler.java
---
(0076191)
hgbot (developer)
2015-04-01 08:05

 Repository: erp/backports/3.0PR15Q2
Changeset: 50ed7c83fab78e919b455848f43c2972789a52a0
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Tue Feb 24 19:00:32 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/50ed7c83fab78e919b455848f43c2972789a52a0 [^]

Related to bug 29030: Code review.

Fixed the copyright.
Add a clear on every 100 iterations of bankLinesSR Scrollable Results.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadActionHandler.java
---
(0076284)
priyam (administrator)
2015-04-01 08:47

 closed again, as the status changes due to merge of tag 15Q1.2 to backport repo Q2

- Issue History
Date Modified Username Field Change
2015-02-23 17:33 umartirena New Issue
2015-02-23 17:33 umartirena Assigned To => Sandrahuguet
2015-02-23 17:33 umartirena Modules => Core
2015-02-23 17:33 umartirena Triggers an Emergency Pack => No
2015-02-24 18:11 hgbot Checkin
2015-02-24 18:11 hgbot Note Added: 0074875
2015-02-24 18:11 hgbot Status new => resolved
2015-02-24 18:11 hgbot Resolution open => fixed
2015-02-24 18:11 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a169e46939dbb740c385be6a202791fbe70e3c9e [^]
2015-02-24 18:41 umartirena Regression date => 2014-09-23
2015-02-24 18:41 umartirena Regression introduced in release => 3.0PR14Q4
2015-02-24 18:41 umartirena Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^]
2015-02-24 19:13 hgbot Checkin
2015-02-24 19:13 hgbot Note Added: 0074881
2015-02-25 21:22 hudsonbot Checkin
2015-02-25 21:22 hudsonbot Note Added: 0074940
2015-02-25 21:22 hudsonbot Checkin
2015-02-25 21:22 hudsonbot Note Added: 0074944
2015-02-26 18:12 umartirena Steps to Reproduce Updated View Revisions
2015-02-26 18:17 Sandrahuguet Review Assigned To => Sandrahuguet
2015-02-26 18:17 Sandrahuguet Status resolved => closed
2015-02-26 18:17 Sandrahuguet Fixed in Version => 3.0PR15Q2
2015-02-26 18:17 Sandrahuguet Assigned To Sandrahuguet => umartirena
2015-03-24 17:12 aferraz Relationship added caused by 0029390
2015-04-01 08:05 hgbot Checkin
2015-04-01 08:05 hgbot Note Added: 0076190
2015-04-01 08:05 hgbot Status closed => resolved
2015-04-01 08:05 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/a169e46939dbb740c385be6a202791fbe70e3c9e [^] => http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/0b5abcbe72aef40665525b17f8434d740a86ade0 [^]
2015-04-01 08:05 hgbot Checkin
2015-04-01 08:05 hgbot Note Added: 0076191
2015-04-01 08:47 priyam Status resolved => closed
2015-04-01 08:47 priyam Note Added: 0076284

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker