Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029030Openbravo ERP09. Financial managementpublic2015-02-23 17:332015-04-01 08:47
Reporterumartirena 
Assigned Toumartirena 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR15Q2 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date2014-09-23
Regression introduced in release3.0PR14Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^]
Triggers an Emergency PackNo
Summary0029030: Match Statement Matching Algorithm fails under certain circumstances
DescriptionMatch Statement Matching Algorithm fails when a bank statement line gives an error when trying to be matched. The process when a line triggers an error should skip that line and continue with the rest of the lines until finishing the process. In this case, the process is failing and the algorithm stops.
Steps To ReproduceInstall "Invoice Matching Algorithm" module.
Go to Enterprise module management and install the dataset of the module.
Go to Financial Account window:
 * Edit "Cuenta de Banco" and assign in Matching Algorithm "Advanced Matching Algorithm".
 * Go to "Imported Bank Statement" tab and create a header:
  - Put a name and set Import Date and Transaction Date: 03/01/2015.
 * Add 2 lines:
  - Transaction Date: 03/01/2015
  - Set a Reference No.
  - Set a Business Partner.
  - Set a GL Item.
  - One with Deposit Amount 35 and the other with Withdrawal Amount 30.
 * Process The Bank Statement.

Go to Open/Close Period Control window.
 * Filter by:
   - Year 2015
   - Name Ene-15
   - Org: F&B España
 * Click on Close Period.

Go back to Financial Account window:
 * Select "Cuenta de Banco"
 * Click on Match Statement.

Realize that "Error: Session is closed!" error is obtained, when the process should theoretically finish without matching anything.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 00293903.0PR14Q4 closed Sandrahuguet Reconciliation refactor project 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-02-23 17:33umartirenaNew Issue
2015-02-23 17:33umartirenaAssigned To => Sandrahuguet
2015-02-23 17:33umartirenaModules => Core
2015-02-23 17:33umartirenaTriggers an Emergency Pack => No
2015-02-24 18:11hgbotCheckin
2015-02-24 18:11hgbotNote Added: 0074875
2015-02-24 18:11hgbotStatusnew => resolved
2015-02-24 18:11hgbotResolutionopen => fixed
2015-02-24 18:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a169e46939dbb740c385be6a202791fbe70e3c9e [^]
2015-02-24 18:41umartirenaRegression date => 2014-09-23
2015-02-24 18:41umartirenaRegression introduced in release => 3.0PR14Q4
2015-02-24 18:41umartirenaRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^]
2015-02-24 19:13hgbotCheckin
2015-02-24 19:13hgbotNote Added: 0074881
2015-02-25 21:22hudsonbotCheckin
2015-02-25 21:22hudsonbotNote Added: 0074940
2015-02-25 21:22hudsonbotCheckin
2015-02-25 21:22hudsonbotNote Added: 0074944
2015-02-26 18:12umartirenaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7794#r7794
2015-02-26 18:17SandrahuguetReview Assigned To => Sandrahuguet
2015-02-26 18:17SandrahuguetStatusresolved => closed
2015-02-26 18:17SandrahuguetFixed in Version => 3.0PR15Q2
2015-02-26 18:17SandrahuguetAssigned ToSandrahuguet => umartirena
2015-03-24 17:12aferrazRelationship addedcaused by 0029390
2015-04-01 08:05hgbotCheckin
2015-04-01 08:05hgbotNote Added: 0076190
2015-04-01 08:05hgbotStatusclosed => resolved
2015-04-01 08:05hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/a169e46939dbb740c385be6a202791fbe70e3c9e [^] => http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/0b5abcbe72aef40665525b17f8434d740a86ade0 [^]
2015-04-01 08:05hgbotCheckin
2015-04-01 08:05hgbotNote Added: 0076191
2015-04-01 08:47priyamStatusresolved => closed
2015-04-01 08:47priyamNote Added: 0076284

Notes
(0074875)
hgbot   
2015-02-24 18:11   
Repository: erp/devel/pi
Changeset: a169e46939dbb740c385be6a202791fbe70e3c9e
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Mon Feb 23 17:47:46 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a169e46939dbb740c385be6a202791fbe70e3c9e [^]

Fixes bug 29030: Match Statement does not fail when a line throws an exception

In Matching Algorithm in Match Statement, if a line to be matched fails for any reason (period closed for example) a rollback occurs. This rollback was not being properly managed in Matching Algorithm after the refactor of Match Statement window, so the process was failing instead of skipping that line and going forward. Now it skips and the process finished successfully.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadActionHandler.java
---
(0074881)
hgbot   
2015-02-24 19:13   
Repository: erp/devel/pi
Changeset: f24821411d25df6c674fed910a827788cf6fd52b
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Tue Feb 24 19:00:32 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f24821411d25df6c674fed910a827788cf6fd52b [^]

Related to bug 29030: Code review.

Fixed the copyright.
Add a clear on every 100 iterations of bankLinesSR Scrollable Results.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadActionHandler.java
---
(0074940)
hudsonbot   
2015-02-25 21:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/96ba7b028cb7 [^]
Maturity status: Test
(0074944)
hudsonbot   
2015-02-25 21:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/96ba7b028cb7 [^]
Maturity status: Test
(0076190)
hgbot   
2015-04-01 08:05   
Repository: erp/backports/3.0PR15Q2
Changeset: 0b5abcbe72aef40665525b17f8434d740a86ade0
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Mon Feb 23 17:47:46 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/0b5abcbe72aef40665525b17f8434d740a86ade0 [^]

Fixes bug 29030: Match Statement does not fail when a line throws an exception

In Matching Algorithm in Match Statement, if a line to be matched fails for any reason (period closed for example) a rollback occurs. This rollback was not being properly managed in Matching Algorithm after the refactor of Match Statement window, so the process was failing instead of skipping that line and going forward. Now it skips and the process finished successfully.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadActionHandler.java
---
(0076191)
hgbot   
2015-04-01 08:05   
Repository: erp/backports/3.0PR15Q2
Changeset: 50ed7c83fab78e919b455848f43c2972789a52a0
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Tue Feb 24 19:00:32 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q2/rev/50ed7c83fab78e919b455848f43c2972789a52a0 [^]

Related to bug 29030: Code review.

Fixed the copyright.
Add a clear on every 100 iterations of bankLinesSR Scrollable Results.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadActionHandler.java
---
(0076284)
priyam   
2015-04-01 08:47   
closed again, as the status changes due to merge of tag 15Q1.2 to backport repo Q2