Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0028416 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Modules] Service Contract Management | major | always | 2014-12-15 18:44 | 2015-01-22 12:19 | |||
Reporter | maite | View Status | public | |||||
Assigned To | reinaldoguerra | |||||||
Priority | urgent | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | 82111de13167 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Regression date | ||||||||
Regression introduced by commit | ||||||||
Regression level | ||||||||
Review Assigned To | vmromanos | |||||||
Regression introduced in release | ||||||||
Summary | 0028416: When creating invoice lines only "sales" taxes are being considered | |||||||
Description | When creating invoice lines only "sales" taxes are being considered | |||||||
Steps To Reproduce | Review "createInvoiceTempLines" method in StandardContractInvoiceProcess.java and realize that in line 690, when C_GETTAX is invoked, last parameter is always "true" Instead of that, following value should be sent: invoicePlanItem.getProject().getOBCNTRContractType().isSalesContract() https://code.openbravo.com/erp/pmods/org.openbravo.contract.services/diff/f75230c5cb74/src/org/openbravo/contract/services/process/billing/StandardContractInvoiceProcess.java [^] | |||||||
Tags | No tags attached. | |||||||
Attached Files | 28416(1).diff [^] (1,932 bytes) 2015-01-16 02:59 [Show Content] | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0073561) reinaldoguerra (developer) 2015-01-16 02:58 |
Test plan used: Review "createInvoiceTempLines" method in StandardContractInvoiceProcess.java of Service Contract Management module, and realize that in line 690, when C_GETTAX is invoked, last parameter is now: invoicePlanItem.getProject().getOBCNTRContractType().isSalesContract() instead of the true static boolean's value. Also the exception launched when no taxRate is obtained, was modified to concatenate the isSalesContract value at the end of the output message. See attached diff file. |
(0073716) hgbot (developer) 2015-01-22 12:17 |
Repository: erp/pmods/org.openbravo.contract.services Changeset: 82111de13167a4544288bd77ac8c5113e3246757 Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com> Date: Thu Jan 15 20:31:18 2015 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/82111de13167a4544288bd77ac8c5113e3246757 [^] Fixed bug 28416: When creating invoice lines only "sales" taxes are considered StandardContractInvoiceProcess java class, was changed to take into account a sales contract boolean's value, instead of a static true value, when C_GETTAX is invoked, depending on contract type. Now sales or purchase taxes are considered, when creating invoice lines method is called on Standard Contract Invoice Process. --- M src/org/openbravo/contract/services/process/billing/StandardContractInvoiceProcess.java --- |
(0073717) vmromanos (manager) 2015-01-22 12:19 |
Code review OK Published new version 1.2.16 |
Issue History | |||
Date Modified | Username | Field | Change |
2014-12-15 18:44 | maite | New Issue | |
2014-12-15 18:44 | maite | Assigned To | => vmromanos |
2014-12-15 18:44 | maite | Resolution time | => 1421276400 |
2014-12-15 18:47 | maite | Issue Monitored: networkb | |
2015-01-15 19:39 | reinaldoguerra | Assigned To | vmromanos => reinaldoguerra |
2015-01-15 19:39 | reinaldoguerra | Status | new => scheduled |
2015-01-16 02:58 | reinaldoguerra | Note Added: 0073561 | |
2015-01-16 02:59 | reinaldoguerra | File Added: 28416(1).diff | |
2015-01-22 12:17 | hgbot | Checkin | |
2015-01-22 12:17 | hgbot | Note Added: 0073716 | |
2015-01-22 12:17 | hgbot | Status | scheduled => resolved |
2015-01-22 12:17 | hgbot | Resolution | open => fixed |
2015-01-22 12:17 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/82111de13167a4544288bd77ac8c5113e3246757 [^] |
2015-01-22 12:19 | vmromanos | Review Assigned To | => vmromanos |
2015-01-22 12:19 | vmromanos | Note Added: 0073717 | |
2015-01-22 12:19 | vmromanos | Status | resolved => closed |
Copyright © 2000 - 2009 MantisBT Group |