Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028416ModulesService Contract Managementpublic2014-12-15 18:442015-01-22 12:19
Reportermaite 
Assigned Toreinaldoguerra 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Support ticket
OBNetwork customer
Regression introduced in release
Summary0028416: When creating invoice lines only "sales" taxes are being considered
DescriptionWhen creating invoice lines only "sales" taxes are being considered
Steps To ReproduceReview "createInvoiceTempLines" method in StandardContractInvoiceProcess.java and realize that in line 690, when C_GETTAX is invoked, last parameter is always "true"

Instead of that, following value should be sent:
invoicePlanItem.getProject().getOBCNTRContractType().isSalesContract()

https://code.openbravo.com/erp/pmods/org.openbravo.contract.services/diff/f75230c5cb74/src/org/openbravo/contract/services/process/billing/StandardContractInvoiceProcess.java [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 28416(1).diff (1,932) 2015-01-16 02:59
https://issues.openbravo.com/file_download.php?file_id=7695&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-12-15 18:44maiteNew Issue
2014-12-15 18:44maiteAssigned To => vmromanos
2014-12-15 18:44maiteResolution time => 1421276400
2014-12-15 18:47maiteIssue Monitored: networkb
2015-01-15 19:39reinaldoguerraAssigned Tovmromanos => reinaldoguerra
2015-01-15 19:39reinaldoguerraStatusnew => scheduled
2015-01-16 02:58reinaldoguerraNote Added: 0073561
2015-01-16 02:59reinaldoguerraFile Added: 28416(1).diff
2015-01-22 12:17hgbotCheckin
2015-01-22 12:17hgbotNote Added: 0073716
2015-01-22 12:17hgbotStatusscheduled => resolved
2015-01-22 12:17hgbotResolutionopen => fixed
2015-01-22 12:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/82111de13167a4544288bd77ac8c5113e3246757 [^]
2015-01-22 12:19vmromanosReview Assigned To => vmromanos
2015-01-22 12:19vmromanosNote Added: 0073717
2015-01-22 12:19vmromanosStatusresolved => closed

Notes
(0073561)
reinaldoguerra   
2015-01-16 02:58   
Test plan used:
Review "createInvoiceTempLines" method in StandardContractInvoiceProcess.java of Service Contract Management module, and realize that in line 690, when C_GETTAX is invoked, last parameter is now: invoicePlanItem.getProject().getOBCNTRContractType().isSalesContract() instead of the true static boolean's value.
Also the exception launched when no taxRate is obtained, was modified to concatenate the isSalesContract value at the end of the output message. See attached diff file.
(0073716)
hgbot   
2015-01-22 12:17   
Repository: erp/pmods/org.openbravo.contract.services
Changeset: 82111de13167a4544288bd77ac8c5113e3246757
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Thu Jan 15 20:31:18 2015 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.contract.services/rev/82111de13167a4544288bd77ac8c5113e3246757 [^]

Fixed bug 28416: When creating invoice lines only "sales" taxes are considered

StandardContractInvoiceProcess java class, was changed to take into account a sales contract boolean's value, instead of a static true value, when C_GETTAX is invoked, depending on contract type.
Now sales or purchase taxes are considered, when creating invoice lines method is called on Standard Contract Invoice Process.

---
M src/org/openbravo/contract/services/process/billing/StandardContractInvoiceProcess.java
---
(0073717)
vmromanos   
2015-01-22 12:19   
Code review OK
Published new version 1.2.16