Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0027350
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminoralways2014-08-16 14:082014-09-15 09:19
ReporterOrekariaView Statuspublic 
Assigned ToOrekaria 
PrioritynormalResolutionfixedFixed in VersionRR14Q4
StatusclosedFix in branchpiFixed in SCM revision66dd67e41557
ProjectionnoneETAnoneTarget VersionRR14Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0027350: Stabilization: Checking if the HookManager is available is not necessary

DescriptionStabilization: Checking if the HookManager is available is not necessary
Steps To ReproduceVerify that 4 files in the returns module have this check:

  if (OB.MobileApp.model.hookManager) {

Verify that in the same module, this line in modalReturnLines.js does not check if the HookManager is available, invalidating the other checks in the modules:

  OB.UTIL.HookManager.callbackExecutor(me.args.args, me.args.callbacks);

Verify that in the private modules are also this checks
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks feature request 0027329 newRetail Stabilization: Overhaul the loading process (since the url is entered until the webpos has loaded) 
blocks defect 0027349RR14Q4 closedOrekaria [API Deprecation] The HookManager does not have to depend on the OB.MobileApp.model object 

-  Notes
(0069397)
hgbot (developer)
2014-08-16 14:16

 Repository: erp/pmods/org.openbravo.retail.returns
Changeset: c997a76903ce632503cbf2d50e5123197cf7d189
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 16 14:15:47 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/c997a76903ce632503cbf2d50e5123197cf7d189 [^]

Fixes issue 27350: Removed the check to see if the HookManager is available, because is not neccessary in a standard module

---
M web/org.openbravo.retail.returns/js/hookGroupedProductPreCreateLine.js
M web/org.openbravo.retail.returns/js/hookRenderOrderLine.js
M web/org.openbravo.retail.returns/js/hookReturnChangeQty.js
M web/org.openbravo.retail.returns/js/hookReturnPaidOrder.js
---
(0069407)
hgbot (developer)
2014-08-16 17:52

 Repository: erp/pmods/org.openbravo.retail.taxexempt
Changeset: f39a1edc33b6a26d4b4f2f78ed75463095dd8032
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 16 17:44:53 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.taxexempt/rev/f39a1edc33b6a26d4b4f2f78ed75463095dd8032 [^]

Fixes issue 27350: Removed the check to see if the HookManager is available, because is not necessary

---
M web/org.openbravo.retail.taxexempt/js/hookFindTaxRate.js
M web/org.openbravo.retail.taxexempt/js/hookRenderOrderLine.js
---
(0069561)
hgbot (developer)
2014-08-21 11:03

 Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 66dd67e415576f94f96bd9d8d9f9e541a0a03da8
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Aug 21 11:03:36 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/66dd67e415576f94f96bd9d8d9f9e541a0a03da8 [^]

Fixes issue 27350: Removed the check to see if the HookManager is available, because is not longer neccessary (giftcards)

---
M web/org.openbravo.retail.giftcards/js/components/GiftCardCancel.js
M web/org.openbravo.retail.giftcards/js/components/lineproperties.js
---
(0070118)
mtaal (manager)
2014-09-15 09:19

 Reviewed

- Issue History
Date Modified Username Field Change
2014-08-16 14:08 Orekaria New Issue
2014-08-16 14:08 Orekaria Assigned To => Orekaria
2014-08-16 14:08 Orekaria Triggers an Emergency Pack => No
2014-08-16 14:08 Orekaria Relationship added blocks 0027329
2014-08-16 14:09 Orekaria Relationship added blocks 0027349
2014-08-16 14:10 Orekaria Summary Stabilization: Checking if the HookManager is available in a standard module has is not neccessary => Stabilization: Checking if the HookManager is available in a standard module is not neccessary
2014-08-16 14:10 Orekaria Description Updated View Revisions
2014-08-16 14:13 Orekaria Steps to Reproduce Updated View Revisions
2014-08-16 14:16 hgbot Checkin
2014-08-16 14:16 hgbot Note Added: 0069397
2014-08-16 14:16 hgbot Status new => resolved
2014-08-16 14:16 hgbot Resolution open => fixed
2014-08-16 14:16 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/c997a76903ce632503cbf2d50e5123197cf7d189 [^]
2014-08-16 17:41 Orekaria Status resolved => new
2014-08-16 17:41 Orekaria Resolution fixed => open
2014-08-16 17:42 Orekaria Summary Stabilization: Checking if the HookManager is available in a standard module is not neccessary => Stabilization: Checking if the HookManager is available is not necessary
2014-08-16 17:42 Orekaria Description Updated View Revisions
2014-08-16 17:42 Orekaria Steps to Reproduce Updated View Revisions
2014-08-16 17:52 hgbot Checkin
2014-08-16 17:52 hgbot Note Added: 0069407
2014-08-16 17:52 hgbot Status new => resolved
2014-08-16 17:52 hgbot Resolution open => fixed
2014-08-16 17:52 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/c997a76903ce632503cbf2d50e5123197cf7d189 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.taxexempt/rev/f39a1edc33b6a26d4b4f2f78ed75463095dd8032 [^]
2014-08-21 10:53 Orekaria Status resolved => new
2014-08-21 10:53 Orekaria Resolution fixed => open
2014-08-21 10:58 hgbot Checkin
2014-08-21 10:58 hgbot Note Added: 0069559
2014-08-21 10:58 hgbot Status new => resolved
2014-08-21 10:58 hgbot Resolution open => fixed
2014-08-21 10:58 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.taxexempt/rev/f39a1edc33b6a26d4b4f2f78ed75463095dd8032 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/93ee8bb7c11d7b74fea8ee85a62325fd9bddea74 [^]
2014-08-21 10:59 hgbot Checkin
2014-08-21 10:59 hgbot Note Added: 0069560
2014-08-21 11:00 Orekaria Status resolved => new
2014-08-21 11:00 Orekaria Resolution fixed => open
2014-08-21 11:00 Orekaria Note Deleted: 0069559
2014-08-21 11:00 Orekaria Note Deleted: 0069560
2014-08-21 11:03 hgbot Checkin
2014-08-21 11:03 hgbot Note Added: 0069561
2014-08-21 11:03 hgbot Status new => resolved
2014-08-21 11:03 hgbot Resolution open => fixed
2014-08-21 11:03 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/93ee8bb7c11d7b74fea8ee85a62325fd9bddea74 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/66dd67e415576f94f96bd9d8d9f9e541a0a03da8 [^]
2014-08-25 13:10 Orekaria Status resolved => new
2014-08-25 13:10 Orekaria Resolution fixed => open
2014-08-25 13:10 Orekaria Status new => acknowledged
2014-08-25 13:12 Orekaria Status acknowledged => scheduled
2014-08-25 13:12 Orekaria fix_in_branch => pi
2014-09-02 21:49 Orekaria Status scheduled => resolved
2014-09-02 21:49 Orekaria Fixed in Version => RR14Q4
2014-09-02 21:49 Orekaria Resolution open => fixed
2014-09-15 09:19 mtaal Note Added: 0070118
2014-09-15 09:19 mtaal Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker