Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027350Retail ModulesWeb POSpublic2014-08-16 14:082014-09-15 09:19
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR14Q4Fixed in VersionRR14Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027350: Stabilization: Checking if the HookManager is available is not necessary
DescriptionStabilization: Checking if the HookManager is available is not necessary
Steps To ReproduceVerify that 4 files in the returns module have this check:

  if (OB.MobileApp.model.hookManager) {

Verify that in the same module, this line in modalReturnLines.js does not check if the HookManager is available, invalidating the other checks in the modules:

  OB.UTIL.HookManager.callbackExecutor(me.args.args, me.args.callbacks);

Verify that in the private modules are also this checks
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks feature request 0027329 new Retail Stabilization: Overhaul the loading process (since the url is entered until the webpos has loaded) 
blocks defect 0027349RR14Q4 closed Orekaria [API Deprecation] The HookManager does not have to depend on the OB.MobileApp.model object 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-08-16 14:08OrekariaNew Issue
2014-08-16 14:08OrekariaAssigned To => Orekaria
2014-08-16 14:08OrekariaTriggers an Emergency Pack => No
2014-08-16 14:08OrekariaRelationship addedblocks 0027329
2014-08-16 14:09OrekariaRelationship addedblocks 0027349
2014-08-16 14:10OrekariaSummaryStabilization: Checking if the HookManager is available in a standard module has is not neccessary => Stabilization: Checking if the HookManager is available in a standard module is not neccessary
2014-08-16 14:10OrekariaDescription Updatedbug_revision_view_page.php?rev_id=6296#r6296
2014-08-16 14:13OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6298#r6298
2014-08-16 14:16hgbotCheckin
2014-08-16 14:16hgbotNote Added: 0069397
2014-08-16 14:16hgbotStatusnew => resolved
2014-08-16 14:16hgbotResolutionopen => fixed
2014-08-16 14:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/c997a76903ce632503cbf2d50e5123197cf7d189 [^]
2014-08-16 17:41OrekariaStatusresolved => new
2014-08-16 17:41OrekariaResolutionfixed => open
2014-08-16 17:42OrekariaSummaryStabilization: Checking if the HookManager is available in a standard module is not neccessary => Stabilization: Checking if the HookManager is available is not necessary
2014-08-16 17:42OrekariaDescription Updatedbug_revision_view_page.php?rev_id=6310#r6310
2014-08-16 17:42OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6311#r6311
2014-08-16 17:52hgbotCheckin
2014-08-16 17:52hgbotNote Added: 0069407
2014-08-16 17:52hgbotStatusnew => resolved
2014-08-16 17:52hgbotResolutionopen => fixed
2014-08-16 17:52hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/c997a76903ce632503cbf2d50e5123197cf7d189 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.taxexempt/rev/f39a1edc33b6a26d4b4f2f78ed75463095dd8032 [^]
2014-08-21 10:53OrekariaStatusresolved => new
2014-08-21 10:53OrekariaResolutionfixed => open
2014-08-21 10:58hgbotCheckin
2014-08-21 10:58hgbotNote Added: 0069559
2014-08-21 10:58hgbotStatusnew => resolved
2014-08-21 10:58hgbotResolutionopen => fixed
2014-08-21 10:58hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.taxexempt/rev/f39a1edc33b6a26d4b4f2f78ed75463095dd8032 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/93ee8bb7c11d7b74fea8ee85a62325fd9bddea74 [^]
2014-08-21 10:59hgbotCheckin
2014-08-21 10:59hgbotNote Added: 0069560
2014-08-21 11:00OrekariaStatusresolved => new
2014-08-21 11:00OrekariaResolutionfixed => open
2014-08-21 11:00OrekariaNote Deleted: 0069559
2014-08-21 11:00OrekariaNote Deleted: 0069560
2014-08-21 11:03hgbotCheckin
2014-08-21 11:03hgbotNote Added: 0069561
2014-08-21 11:03hgbotStatusnew => resolved
2014-08-21 11:03hgbotResolutionopen => fixed
2014-08-21 11:03hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/93ee8bb7c11d7b74fea8ee85a62325fd9bddea74 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/66dd67e415576f94f96bd9d8d9f9e541a0a03da8 [^]
2014-08-25 13:10OrekariaStatusresolved => new
2014-08-25 13:10OrekariaResolutionfixed => open
2014-08-25 13:10OrekariaStatusnew => acknowledged
2014-08-25 13:12OrekariaStatusacknowledged => scheduled
2014-08-25 13:12Orekariafix_in_branch => pi
2014-09-02 21:49OrekariaStatusscheduled => resolved
2014-09-02 21:49OrekariaFixed in Version => RR14Q4
2014-09-02 21:49OrekariaResolutionopen => fixed
2014-09-15 09:19mtaalNote Added: 0070118
2014-09-15 09:19mtaalStatusresolved => closed

Notes
(0069397)
hgbot   
2014-08-16 14:16   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: c997a76903ce632503cbf2d50e5123197cf7d189
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 16 14:15:47 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/c997a76903ce632503cbf2d50e5123197cf7d189 [^]

Fixes issue 27350: Removed the check to see if the HookManager is available, because is not neccessary in a standard module

---
M web/org.openbravo.retail.returns/js/hookGroupedProductPreCreateLine.js
M web/org.openbravo.retail.returns/js/hookRenderOrderLine.js
M web/org.openbravo.retail.returns/js/hookReturnChangeQty.js
M web/org.openbravo.retail.returns/js/hookReturnPaidOrder.js
---
(0069407)
hgbot   
2014-08-16 17:52   
Repository: erp/pmods/org.openbravo.retail.taxexempt
Changeset: f39a1edc33b6a26d4b4f2f78ed75463095dd8032
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat Aug 16 17:44:53 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.taxexempt/rev/f39a1edc33b6a26d4b4f2f78ed75463095dd8032 [^]

Fixes issue 27350: Removed the check to see if the HookManager is available, because is not necessary

---
M web/org.openbravo.retail.taxexempt/js/hookFindTaxRate.js
M web/org.openbravo.retail.taxexempt/js/hookRenderOrderLine.js
---
(0069561)
hgbot   
2014-08-21 11:03   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 66dd67e415576f94f96bd9d8d9f9e541a0a03da8
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Aug 21 11:03:36 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/66dd67e415576f94f96bd9d8d9f9e541a0a03da8 [^]

Fixes issue 27350: Removed the check to see if the HookManager is available, because is not longer neccessary (giftcards)

---
M web/org.openbravo.retail.giftcards/js/components/GiftCardCancel.js
M web/org.openbravo.retail.giftcards/js/components/lineproperties.js
---
(0070118)
mtaal   
2014-09-15 09:19   
Reviewed