0027099: Incorrect "Used Credit" amount when running "Reverse Payment" process from a payment that generated credit

Description

Incorrect "Used Credit" amount when running "Reverse Payment" process from a payment that generated credit

Steps To Reproduce

0. Enable "Reverse Payment" functionality for Payment In window (http://wiki.openbravo.com/wiki/Projects:Reversepayment/User_Manual [^])
1. Register Sales Invoice for any Org and BP with total amount=10
2. Register Payment In of amount=15. Pay previous invoice and generate credit for 5 EUR
3. Run "Reverse Payment" process from previous payment. Payment with following details should be created:
  - Payment with amount= -15 and Used Credit=5
    - Payment detail referencing previous invoice with amount=-10 (with refund field=N)
    - Payment detail not referencing anything with amount =-5 (with refund field=Y)

Depending on how details are considered payment will be created with:
- Used Credit=5 --> in case detail with refund=Y is considered --> CORRECT
- Used Credit=0 --> in case detail with refund=N is considered --> INCORRECT

Proposed Solution

Problem is in FIN_PaymentProcess.java file, when variable "isRefund" is going to be calculated (line 137):

if (payment.getFINPaymentDetailList().size() > 0
              && payment.getFINPaymentDetailList().get(0).isRefund()) {
            isRefund = true;
          }

Not only first detail should be considered (as it could be detail with refund=N) but all details should be considered in order to calculate value for isRefund variable

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

0025730

3.0PR14Q3

closed

pramakrishnan

Sometimes when reverting a payment out with generated credit Used Credit Source tab is not filled

Notes
(0068670) maite (developer) 2014-07-16 17:25	modulescript is required in order to fix erroneous data

(0071466) maite (developer) 2014-11-06 17:38	problem solved with 25730 commit

Issue History
Date Modified	Username	Field	Change
2014-07-16 17:22	maite	New Issue
2014-07-16 17:22	maite	Assigned To	=> dmiguelez
2014-07-16 17:22	maite	Modules	=> Core
2014-07-16 17:22	maite	Triggers an Emergency Pack	=> No
2014-07-16 17:25	maite	Resolution time	=> 1408485600
2014-07-16 17:25	maite	Note Added: 0068670
2014-07-16 17:25	maite	Issue Monitored: networkb
2014-09-01 18:48	AtulOpenbravo	Assigned To	dmiguelez => AtulOpenbravo
2014-09-01 18:49	AtulOpenbravo	Status	new => scheduled
2014-09-01 18:49	AtulOpenbravo	fix_in_branch	=> pi
2014-10-02 11:02	jonalegriaesarte	Target Version	3.0PR14Q4 => 3.0PR15Q1
2014-10-02 11:02	jonalegriaesarte	fix_in_branch	pi =>
2014-10-16 15:34	vmromanos	Relationship added	related to 0025730
2014-11-06 17:38	maite	Note Added: 0071466
2014-11-06 17:38	maite	Status	scheduled => resolved
2014-11-06 17:38	maite	Fixed in SCM revision	=> .
2014-11-06 17:38	maite	Resolution	open => fixed
2014-11-06 17:38	maite	Status	resolved => closed