0027099: Incorrect "Used Credit" amount when running "Reverse Payment" process from a payment that generated credit

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0027099

Openbravo ERP

Z. Others

public

2014-07-16 17:22

2014-11-06 17:38

Reporter

maite

Assigned To

AtulOpenbravo

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

3.0PR15Q1

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

OBPS

Web browser

Modules

Core

Support ticket

29875

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0027099: Incorrect "Used Credit" amount when running "Reverse Payment" process from a payment that generated credit

Description

Incorrect "Used Credit" amount when running "Reverse Payment" process from a payment that generated credit

Steps To Reproduce

0. Enable "Reverse Payment" functionality for Payment In window (http://wiki.openbravo.com/wiki/Projects:Reversepayment/User_Manual [^])
1. Register Sales Invoice for any Org and BP with total amount=10
2. Register Payment In of amount=15. Pay previous invoice and generate credit for 5 EUR
3. Run "Reverse Payment" process from previous payment. Payment with following details should be created:
  - Payment with amount= -15 and Used Credit=5
    - Payment detail referencing previous invoice with amount=-10 (with refund field=N)
    - Payment detail not referencing anything with amount =-5 (with refund field=Y)

Depending on how details are considered payment will be created with:
- Used Credit=5 --> in case detail with refund=Y is considered --> CORRECT
- Used Credit=0 --> in case detail with refund=N is considered --> INCORRECT

Proposed Solution

Problem is in FIN_PaymentProcess.java file, when variable "isRefund" is going to be calculated (line 137):

if (payment.getFINPaymentDetailList().size() > 0
              && payment.getFINPaymentDetailList().get(0).isRefund()) {
            isRefund = true;
          }

Not only first detail should be considered (as it could be detail with refund=N) but all details should be considered in order to calculate value for isRefund variable

Additional Information