Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0027024 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 07. Sales management | major | have not tried | 2014-07-07 10:36 | 2014-08-14 16:15 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | vmromanos | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | 085ea1fce739 | |||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | rafaroda | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0027024: Unneeded updates to c_order whenever c_orderline is modified | |||||||
| Description | Whenever any change is done in an order line, its order's totalLines and grandTotal columns are updated regardless these values are modified. This causes performance degradation because: 1. Unnecessary updates 2. These updates cause triggers in c_order to be executed | |||||||
| Steps To Reproduce | See steps in issue 0027023 | |||||||
| Proposed Solution | Smarter logic in c_orderline_trg2 to do do update only when required. | |||||||
| Tags | Performance | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0068809) hgbot (developer) 2014-07-22 15:12 |
Repository: erp/devel/pi Changeset: 085ea1fce739489f26d85c05d89b6e8ed7ec23e4 Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Tue Jul 22 10:23:09 2014 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/085ea1fce739489f26d85c05d89b6e8ed7ec23e4 [^] Fixed bug 27023 Fixed bug 27024: Performance improvements on C_ORDERLINE_TRG2 --- M src-db/database/model/triggers/C_ORDERLINE_TRG2.xml --- |
|
(0069074) dmitry_mezentsev (developer) 2014-08-04 16:36 |
The issues is not closed for 13 days now!!! |
|
(0069212) hudsonbot (developer) 2014-08-08 18:53 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4450016dee64 [^] Maturity status: Test |
|
(0069375) rafaroda (developer) 2014-08-14 16:15 |
Code reviewed fix in C_ORDERLINE_TRG2 and checked functionally that c_orderlinetax_trg trigger is only executed when Order Quantity, Net Unit Price, Tax or Net List Price fields are directly or indirectly changed in Order Line. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2014-07-07 10:36 | alostale | New Issue | |
| 2014-07-07 10:36 | alostale | Assigned To | => eduardo_Argal |
| 2014-07-07 10:36 | alostale | Modules | => Core |
| 2014-07-07 10:36 | alostale | Triggers an Emergency Pack | => No |
| 2014-07-07 10:37 | alostale | Relationship added | related to 0027023 |
| 2014-07-07 10:37 | alostale | Tag Attached: Performance | |
| 2014-07-07 13:33 | jpcalvente | Issue Monitored: jpcalvente | |
| 2014-07-21 16:35 | jonalegriaesarte | Regression date | => 2014-08-07 |
| 2014-07-21 16:37 | jonalegriaesarte | Resolution time | => 1407362400 |
| 2014-07-21 16:37 | jonalegriaesarte | Regression date | 2014-08-07 => |
| 2014-07-21 16:55 | vmromanos | Status | new => scheduled |
| 2014-07-21 16:55 | vmromanos | Assigned To | eduardo_Argal => vmromanos |
| 2014-07-21 16:55 | vmromanos | fix_in_branch | => pi |
| 2014-07-22 15:12 | hgbot | Checkin | |
| 2014-07-22 15:12 | hgbot | Note Added: 0068809 | |
| 2014-07-22 15:12 | hgbot | Status | scheduled => resolved |
| 2014-07-22 15:12 | hgbot | Resolution | open => fixed |
| 2014-07-22 15:12 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/085ea1fce739489f26d85c05d89b6e8ed7ec23e4 [^] |
| 2014-07-23 08:26 | alostale | Relationship added | blocks 0027160 |
| 2014-07-23 10:59 | mtaal | Issue Monitored: mtaal | |
| 2014-08-04 16:36 | dmitry_mezentsev | Note Added: 0069074 | |
| 2014-08-08 18:53 | hudsonbot | Checkin | |
| 2014-08-08 18:53 | hudsonbot | Note Added: 0069212 | |
| 2014-08-14 16:15 | rafaroda | Review Assigned To | => rafaroda |
| 2014-08-14 16:15 | rafaroda | Note Added: 0069375 | |
| 2014-08-14 16:15 | rafaroda | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |