Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027024Openbravo ERP07. Sales managementpublic2014-07-07 10:362014-08-14 16:15
Reporteralostale 
Assigned Tovmromanos 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Torafaroda
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027024: Unneeded updates to c_order whenever c_orderline is modified
DescriptionWhenever any change is done in an order line, its order's totalLines and grandTotal columns are updated regardless these values are modified.

This causes performance degradation because:
1. Unnecessary updates
2. These updates cause triggers in c_order to be executed
Steps To ReproduceSee steps in issue 0027023
Proposed SolutionSmarter logic in c_orderline_trg2 to do do update only when required.
Additional Information
TagsPerformance
Relationships
related to defect 0027023 closed vmromanos Order line taxes are regenerated on all order line changes 
blocks defect 0027160 closed eduardo_Argal C_Order_Post poor performance 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-07-07 10:36alostaleNew Issue
2014-07-07 10:36alostaleAssigned To => eduardo_Argal
2014-07-07 10:36alostaleOBNetwork customer => No
2014-07-07 10:36alostaleModules => Core
2014-07-07 10:36alostaleTriggers an Emergency Pack => No
2014-07-07 10:37alostaleOBNetwork customerNo => Yes
2014-07-07 10:37alostaleRelationship addedrelated to 0027023
2014-07-07 10:37alostaleTag Attached: Performance
2014-07-07 13:33jpcalventeIssue Monitored: jpcalvente
2014-07-21 16:35jonalegriaesarteRegression date => 2014-08-07
2014-07-21 16:37jonalegriaesarteResolution time => 1407362400
2014-07-21 16:37jonalegriaesarteRegression date2014-08-07 =>
2014-07-21 16:55vmromanosStatusnew => scheduled
2014-07-21 16:55vmromanosAssigned Toeduardo_Argal => vmromanos
2014-07-21 16:55vmromanosfix_in_branch => pi
2014-07-22 15:12hgbotCheckin
2014-07-22 15:12hgbotNote Added: 0068809
2014-07-22 15:12hgbotStatusscheduled => resolved
2014-07-22 15:12hgbotResolutionopen => fixed
2014-07-22 15:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/085ea1fce739489f26d85c05d89b6e8ed7ec23e4 [^]
2014-07-23 08:26alostaleRelationship addedblocks 0027160
2014-07-23 10:59mtaalIssue Monitored: mtaal
2014-08-04 16:36dmitry_mezentsevNote Added: 0069074
2014-08-08 18:53hudsonbotCheckin
2014-08-08 18:53hudsonbotNote Added: 0069212
2014-08-14 16:15rafarodaReview Assigned To => rafaroda
2014-08-14 16:15rafarodaNote Added: 0069375
2014-08-14 16:15rafarodaStatusresolved => closed

Notes
(0068809)
hgbot   
2014-07-22 15:12   
Repository: erp/devel/pi
Changeset: 085ea1fce739489f26d85c05d89b6e8ed7ec23e4
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Jul 22 10:23:09 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/085ea1fce739489f26d85c05d89b6e8ed7ec23e4 [^]

Fixed bug 27023 Fixed bug 27024: Performance improvements on C_ORDERLINE_TRG2

---
M src-db/database/model/triggers/C_ORDERLINE_TRG2.xml
---
(0069074)
dmitry_mezentsev   
2014-08-04 16:36   
The issues is not closed for 13 days now!!!
(0069212)
hudsonbot   
2014-08-08 18:53   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4450016dee64 [^]
Maturity status: Test
(0069375)
rafaroda   
2014-08-14 16:15   
Code reviewed fix in C_ORDERLINE_TRG2 and checked functionally that c_orderlinetax_trg trigger is only executed when Order Quantity, Net Unit Price, Tax or Net List Price fields are directly or indirectly changed in Order Line.