Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0026664 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] A. Platform | minor | have not tried | 2014-05-22 14:52 | 2016-12-22 12:54 | |||
Reporter | alostale | View Status | public | |||||
Assigned To | alostale | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR16Q4 | |||
Status | closed | Fix in branch | Fixed in SCM revision | d0b7ee93f8e7 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | caristu | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0026664: Useless ConnectionProvider caching in ApplicationDictionaryCachedStructures | |||||||
Description | ApplicationDictionaryCachedStructures is caching DalConnectionProvider for ComboTableData, which retains DAl's StatefulPersintanceContext. Caching of DalConnectionProvider can be avoided. Reducing in this manner the total amount of memory retained per session. | |||||||
Steps To Reproduce | * With no modules in development execute 4 times https://code.openbravo.com/erp/devel/pi-performance/file/274220fc729c/FICnewAllHeaderTabs.jmx [^] jMeter test case * Obtain a JVM memory dump See org.apache.catalina.session.StandardManager is retaining 4 org.apache.catalina.session.StandardSession instances having each of them org.hibernate.engine.StatefulPersistenceContext instances up to ~5MB each. These 20MB (4x5MB) are useless and could be not cached. | |||||||
Proposed Solution | See attached patch. Though it requires to be properly tested, it apparently works. Applying this patch these 20MB are reduced from retained memory. | |||||||
Tags | Performance | |||||||
Attached Files | conn-adcs.diff [^] (876 bytes) 2014-05-22 14:54 [Show Content] | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |||||||||||||||
|
Notes | |
(0088490) hgbot (developer) 2016-07-14 15:45 |
Repository: erp/devel/pi Changeset: d0b7ee93f8e78e1e14df9f3539032b3b8458eb90 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Mon Jul 11 13:25:10 2016 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/d0b7ee93f8e78e1e14df9f3539032b3b8458eb90 [^] fixed bug 26664: useless ConnectionProvider caching in ADCS ConnectionProvider was cached in ADCS through cached ComboTableData instances. This retained a significant amount of memory. Now it is not cached anymore and obtained from DAL connection when needed. --- M src/org/openbravo/erpCommon/utility/ComboTableData.java --- |
(0088658) caristu (developer) 2016-07-26 09:32 |
Code reviewed |
(0089014) hudsonbot (developer) 2016-08-11 18:40 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^] Maturity status: Test |
Issue History | |||
Date Modified | Username | Field | Change |
2014-05-22 14:52 | alostale | New Issue | |
2014-05-22 14:52 | alostale | Assigned To | => AugustoMauch |
2014-05-22 14:52 | alostale | Modules | => Core |
2014-05-22 14:52 | alostale | Triggers an Emergency Pack | => No |
2014-05-22 14:52 | alostale | Tag Attached: Performance | |
2014-05-22 14:52 | alostale | Relationship added | related to 0024421 |
2014-05-22 14:54 | alostale | File Added: conn-adcs.diff | |
2015-01-05 11:14 | shuehner | Issue Monitored: shuehner | |
2015-01-07 09:50 | alostale | Target Version | => 3.0PR15Q2 |
2015-02-24 17:18 | alostale | Priority | normal => urgent |
2015-02-24 17:18 | alostale | Status | new => acknowledged |
2015-03-11 08:11 | alostale | Target Version | 3.0PR15Q2 => |
2015-03-17 14:37 | alostale | Assigned To | AugustoMauch => platform |
2015-11-11 11:37 | alostale | Priority | urgent => normal |
2016-07-14 15:44 | alostale | Assigned To | platform => alostale |
2016-07-14 15:45 | alostale | Review Assigned To | => caristu |
2016-07-14 15:45 | hgbot | Checkin | |
2016-07-14 15:45 | hgbot | Note Added: 0088490 | |
2016-07-14 15:45 | hgbot | Status | acknowledged => resolved |
2016-07-14 15:45 | hgbot | Resolution | open => fixed |
2016-07-14 15:45 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/d0b7ee93f8e78e1e14df9f3539032b3b8458eb90 [^] |
2016-07-26 09:32 | caristu | Note Added: 0088658 | |
2016-07-26 09:32 | caristu | Status | resolved => closed |
2016-07-26 09:32 | caristu | Fixed in Version | => 3.0PR16Q4 |
2016-08-11 18:40 | hudsonbot | Checkin | |
2016-08-11 18:40 | hudsonbot | Note Added: 0089014 | |
2016-12-22 12:54 | alostale | Relationship added | related to 0034813 |
Copyright © 2000 - 2009 MantisBT Group |