Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0025219 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | always | 2013-11-26 18:09 | 2013-11-28 19:57 | |||
| Reporter | gorkaion | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | 3.0MP30 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 758083712c64 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Linux 32 bit | Database | PostgreSQL | Java version | 1.5.0_15 | |||
| OS Version | Gentoo | Database version | Ant version | 1.7.0 | ||||
| Product Version | 3.0MP29.1 | SCM revision | ||||||
| Merge Request Status | ||||||||
| Review Assigned To | alostale | |||||||
| OBNetwork customer | OBPS | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0025219: XSQL in PG not ready for procedures with 2 or more out parameters | |||||||
| Description | The ReservationUtils.reallocateStock() method calls a stored procedure with 2 out parameters. This method fails when using postgresql. There are 2 utility methods to call stored procedures from java: Xsql: fails in postgresql with 2 or more out parameters CallStoredProcedure: fails in any database with 2 or more parameters. As xsql is a legacy process CallStoredProcedure should be adapted to allow 2 or more out parameters. | |||||||
| Steps To Reproduce | Modify ReservationUtils.reallocateStock() method to use CallStoredProcedure.call instead of xsql method. Create a java process that uses this method. There is a process in Warehouse Picking module (version 1.4.1 or newer) that uses this method. Ping me for details on this module to reproduce the error using it. | |||||||
| Proposed Solution | Modify ReservationUtils.reallocateStock() to use CallStoredProcedure. Modify CallStoredProcedure.call() to allow 2 or more out parameters. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
Notes |
|
|
(0062385) gorkaion (viewer) 2013-11-26 18:48 |
The xsql case can be adapted with the attached patch. Note that the patch has not been properly tested. |
|
(0062397) alostale (viewer) 2013-11-27 11:07 |
Applying proposed patch that fixes xsql instead of CallStoredProcedure |
|
(0062399) hgbot (developer) 2013-11-27 11:20 |
Repository: erp/devel/pi Changeset: 758083712c6440637a7314822213f6ede6afc9ff Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Wed Nov 27 11:18:18 2013 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/758083712c6440637a7314822213f6ede6afc9ff [^] fixed bug 25219: support for more than 1 out param in PG xsql for stored procs --- M src-core/src/org/openbravo/database/RDBMSIndependent.java --- |
|
(0062400) alostale (viewer) 2013-11-27 11:20 |
Tested with existent xsql calls to procedures with 1 and more out params |
|
(0062464) hudsonbot (viewer) 2013-11-28 19:57 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ce703e5082ac [^] Maturity status: Test |
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2013-11-26 18:09 | gorkaion | New Issue | |
| 2013-11-26 18:09 | gorkaion | Assigned To | => AugustoMauch |
| 2013-11-26 18:09 | gorkaion | Modules | => Core |
| 2013-11-26 18:09 | gorkaion | OBNetwork customer | => Yes |
| 2013-11-26 18:09 | gorkaion | Triggers an Emergency Pack | => No |
| 2013-11-26 18:48 | gorkaion | Note Added: 0062385 | |
| 2013-11-26 18:48 | gorkaion | File Added: xsqloutparameter.diff | |
| 2013-11-27 11:06 | alostale | Assigned To | AugustoMauch => alostale |
| 2013-11-27 11:07 | alostale | Note Added: 0062397 | |
| 2013-11-27 11:07 | alostale | Summary | CallStoredProcedure not ready for procedures with 2 or more out parameters => XSQL in PG not ready for procedures with 2 or more out parameters |
| 2013-11-27 11:20 | hgbot | Checkin | |
| 2013-11-27 11:20 | hgbot | Note Added: 0062399 | |
| 2013-11-27 11:20 | hgbot | Status | new => resolved |
| 2013-11-27 11:20 | hgbot | Resolution | open => fixed |
| 2013-11-27 11:20 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/758083712c6440637a7314822213f6ede6afc9ff [^] |
| 2013-11-27 11:20 | alostale | Note Added: 0062400 | |
| 2013-11-27 11:20 | alostale | Review Assigned To | => alostale |
| 2013-11-27 11:20 | alostale | Status | resolved => closed |
| 2013-11-27 11:20 | alostale | Fixed in Version | => 3.0MP30 |
| 2013-11-28 19:57 | hudsonbot | Checkin | |
| 2013-11-28 19:57 | hudsonbot | Note Added: 0062464 | |
| Copyright © 2000 - 2009 MantisBT Group |