Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0025219 | Openbravo ERP | A. Platform | public | 2013-11-26 18:09 | 2013-11-28 19:57 |
|
| Reporter | gorkaion | |
| Assigned To | alostale | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 20 | OS Version | Gentoo |
| Product Version | 3.0MP29.1 | |
| Target Version | | Fixed in Version | 3.0MP30 | |
| Merge Request Status | |
| Review Assigned To | alostale |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0025219: XSQL in PG not ready for procedures with 2 or more out parameters |
| Description | The ReservationUtils.reallocateStock() method calls a stored procedure with 2 out parameters. This method fails when using postgresql.
There are 2 utility methods to call stored procedures from java:
Xsql: fails in postgresql with 2 or more out parameters
CallStoredProcedure: fails in any database with 2 or more parameters.
As xsql is a legacy process CallStoredProcedure should be adapted to allow 2 or more out parameters. |
| Steps To Reproduce | Modify ReservationUtils.reallocateStock() method to use CallStoredProcedure.call instead of xsql method.
Create a java process that uses this method.
There is a process in Warehouse Picking module (version 1.4.1 or newer) that uses this method. Ping me for details on this module to reproduce the error using it. |
| Proposed Solution | Modify ReservationUtils.reallocateStock() to use CallStoredProcedure.
Modify CallStoredProcedure.call() to allow 2 or more out parameters. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  xsqloutparameter.diff (1,088) 2013-11-26 18:48
https://issues.openbravo.com/file_download.php?file_id=6519&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2013-11-26 18:09 | gorkaion | New Issue | |
| 2013-11-26 18:09 | gorkaion | Assigned To | => AugustoMauch |
| 2013-11-26 18:09 | gorkaion | Modules | => Core |
| 2013-11-26 18:09 | gorkaion | Triggers an Emergency Pack | => No |
| 2013-11-26 18:48 | gorkaion | Note Added: 0062385 | |
| 2013-11-26 18:48 | gorkaion | File Added: xsqloutparameter.diff | |
| 2013-11-27 11:06 | alostale | Assigned To | AugustoMauch => alostale |
| 2013-11-27 11:07 | alostale | Note Added: 0062397 | |
| 2013-11-27 11:07 | alostale | Summary | CallStoredProcedure not ready for procedures with 2 or more out parameters => XSQL in PG not ready for procedures with 2 or more out parameters |
| 2013-11-27 11:20 | hgbot | Checkin | |
| 2013-11-27 11:20 | hgbot | Note Added: 0062399 | |
| 2013-11-27 11:20 | hgbot | Status | new => resolved |
| 2013-11-27 11:20 | hgbot | Resolution | open => fixed |
| 2013-11-27 11:20 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/758083712c6440637a7314822213f6ede6afc9ff [^] |
| 2013-11-27 11:20 | alostale | Note Added: 0062400 | |
| 2013-11-27 11:20 | alostale | Review Assigned To | => alostale |
| 2013-11-27 11:20 | alostale | Status | resolved => closed |
| 2013-11-27 11:20 | alostale | Fixed in Version | => 3.0MP30 |
| 2013-11-28 19:57 | hudsonbot | Checkin | |
| 2013-11-28 19:57 | hudsonbot | Note Added: 0062464 | |
|
Notes |
|
|
|
|
The xsql case can be adapted with the attached patch. Note that the patch has not been properly tested. |
|
|
|
|
|
Applying proposed patch that fixes xsql instead of CallStoredProcedure |
|
|
|
(0062399)
|
|
hgbot
|
|
2013-11-27 11:20
|
|
|
|
|
|
|
Tested with existent xsql calls to procedures with 1 and more out params |
|
|
|
|
|