Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0024894
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2013-10-07 12:302013-10-17 18:29
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in VersionRMP28
StatusclosedFix in branchFixed in SCM revisionc30be3b0899a
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2012-11-20
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e38e7591c56f2b591fd93272d07e136ca2b2e41e [^]
Triggers an Emergency PackNo
Summary

0024894: promotions code is executed twice

DescriptionCode that calculates promotions is executed twice.

The problem is caused because the event that triggers it to be executed listens to line modifications in qty, gross and net. Whenever qty is modified gross is always updated making it to be executed twice.
Steps To ReproduceWith developers tool opened:
add a product that participates in a promotion: check how the code is executed twice
Proposed SolutionThe correct events to listen to should be price instead of gross or net. Because when price is edited promotions should be recalculated.
TagsPerformance
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0022350RMP17 closedmigueldejuana In Receipt to Return, changing price doesn't work well 

-  Notes
(0061572)
alostale (viewer)
2013-10-07 12:32

 When reviewing this issue, check 0022350
(0061573)
hgbot (developer)
2013-10-07 12:34

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c30be3b0899ae95890a224739c223e81a1f16f62
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Oct 07 12:33:48 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c30be3b0899ae95890a224739c223e81a1f16f62 [^]

fixed bug 24894: promotions code is executed twice

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0061596)
guilleaer (viewer)
2013-10-07 18:06

 verified
(0061610)
hgbot (developer)
2013-10-08 11:42

 Repository: erp/pmods/org.openbravo.retail.posterminal-levelpricing
Changeset: c30be3b0899ae95890a224739c223e81a1f16f62
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Oct 07 12:33:48 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-levelpricing/rev/c30be3b0899ae95890a224739c223e81a1f16f62 [^]

fixed bug 24894: promotions code is executed twice

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0061612)
guilleaer (viewer)
2013-10-08 11:44

 reclosing
(0061704)
hgbot (developer)
2013-10-16 13:38

 Repository: erp/pmods/org.openbravo.retail.posterminal.cirque
Changeset: c30be3b0899ae95890a224739c223e81a1f16f62
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Oct 07 12:33:48 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/c30be3b0899ae95890a224739c223e81a1f16f62 [^]

fixed bug 24894: promotions code is executed twice

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0061783)
guilleaer (viewer)
2013-10-17 18:29

 reclosed

- Issue History
Date Modified Username Field Change
2013-10-07 12:30 alostale New Issue
2013-10-07 12:30 alostale Assigned To => alostale
2013-10-07 12:30 alostale OBNetwork customer => No
2013-10-07 12:30 alostale Triggers an Emergency Pack => No
2013-10-07 12:31 alostale Tag Attached: Performance
2013-10-07 12:31 alostale Relationship added related to 0022350
2013-10-07 12:32 alostale Review Assigned To => marvintm
2013-10-07 12:32 alostale Regression level => Production - Confirmed Stable
2013-10-07 12:32 alostale Regression date => 2012-11-20
2013-10-07 12:32 alostale Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e38e7591c56f2b591fd93272d07e136ca2b2e41e [^]
2013-10-07 12:32 alostale Note Added: 0061572
2013-10-07 12:34 hgbot Checkin
2013-10-07 12:34 hgbot Note Added: 0061573
2013-10-07 12:34 hgbot Status new => resolved
2013-10-07 12:34 hgbot Resolution open => fixed
2013-10-07 12:34 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c30be3b0899ae95890a224739c223e81a1f16f62 [^]
2013-10-07 18:06 guilleaer Review Assigned To marvintm => guilleaer
2013-10-07 18:06 guilleaer Note Added: 0061596
2013-10-07 18:06 guilleaer Status resolved => closed
2013-10-07 18:06 guilleaer Fixed in Version => RMP28
2013-10-08 11:42 hgbot Checkin
2013-10-08 11:42 hgbot Note Added: 0061610
2013-10-08 11:42 hgbot Status closed => resolved
2013-10-08 11:42 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c30be3b0899ae95890a224739c223e81a1f16f62 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-levelpricing/rev/c30be3b0899ae95890a224739c223e81a1f16f62 [^]
2013-10-08 11:44 guilleaer Note Added: 0061612
2013-10-08 11:44 guilleaer Status resolved => closed
2013-10-16 13:38 hgbot Checkin
2013-10-16 13:38 hgbot Note Added: 0061704
2013-10-16 13:38 hgbot Status closed => resolved
2013-10-16 13:38 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-levelpricing/rev/c30be3b0899ae95890a224739c223e81a1f16f62 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/c30be3b0899ae95890a224739c223e81a1f16f62 [^]
2013-10-17 18:29 guilleaer Note Added: 0061783
2013-10-17 18:29 guilleaer Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker