Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024894Retail ModulesWeb POSpublic2013-10-07 12:302013-10-17 18:29
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRMP28 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2012-11-20
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e38e7591c56f2b591fd93272d07e136ca2b2e41e [^]
Triggers an Emergency PackNo
Summary0024894: promotions code is executed twice
DescriptionCode that calculates promotions is executed twice.

The problem is caused because the event that triggers it to be executed listens to line modifications in qty, gross and net. Whenever qty is modified gross is always updated making it to be executed twice.
Steps To ReproduceWith developers tool opened:
add a product that participates in a promotion: check how the code is executed twice
Proposed SolutionThe correct events to listen to should be price instead of gross or net. Because when price is edited promotions should be recalculated.
Additional Information
TagsPerformance
Relationships
related to defect 0022350RMP17 closed migueldejuana In Receipt to Return, changing price doesn't work well 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-10-07 12:30alostaleNew Issue
2013-10-07 12:30alostaleAssigned To => alostale
2013-10-07 12:30alostaleOBNetwork customer => No
2013-10-07 12:30alostaleTriggers an Emergency Pack => No
2013-10-07 12:31alostaleTag Attached: Performance
2013-10-07 12:31alostaleRelationship addedrelated to 0022350
2013-10-07 12:32alostaleReview Assigned To => marvintm
2013-10-07 12:32alostaleRegression level => Production - Confirmed Stable
2013-10-07 12:32alostaleRegression date => 2012-11-20
2013-10-07 12:32alostaleRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e38e7591c56f2b591fd93272d07e136ca2b2e41e [^]
2013-10-07 12:32alostaleNote Added: 0061572
2013-10-07 12:34hgbotCheckin
2013-10-07 12:34hgbotNote Added: 0061573
2013-10-07 12:34hgbotStatusnew => resolved
2013-10-07 12:34hgbotResolutionopen => fixed
2013-10-07 12:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c30be3b0899ae95890a224739c223e81a1f16f62 [^]
2013-10-07 18:06guilleaerReview Assigned Tomarvintm => guilleaer
2013-10-07 18:06guilleaerNote Added: 0061596
2013-10-07 18:06guilleaerStatusresolved => closed
2013-10-07 18:06guilleaerFixed in Version => RMP28
2013-10-08 11:42hgbotCheckin
2013-10-08 11:42hgbotNote Added: 0061610
2013-10-08 11:42hgbotStatusclosed => resolved
2013-10-08 11:42hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c30be3b0899ae95890a224739c223e81a1f16f62 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-levelpricing/rev/c30be3b0899ae95890a224739c223e81a1f16f62 [^]
2013-10-08 11:44guilleaerNote Added: 0061612
2013-10-08 11:44guilleaerStatusresolved => closed
2013-10-16 13:38hgbotCheckin
2013-10-16 13:38hgbotNote Added: 0061704
2013-10-16 13:38hgbotStatusclosed => resolved
2013-10-16 13:38hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-levelpricing/rev/c30be3b0899ae95890a224739c223e81a1f16f62 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/c30be3b0899ae95890a224739c223e81a1f16f62 [^]
2013-10-17 18:29guilleaerNote Added: 0061783
2013-10-17 18:29guilleaerStatusresolved => closed

Notes
(0061572)
alostale   
2013-10-07 12:32   
When reviewing this issue, check 0022350
(0061573)
hgbot   
2013-10-07 12:34   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c30be3b0899ae95890a224739c223e81a1f16f62
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Oct 07 12:33:48 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c30be3b0899ae95890a224739c223e81a1f16f62 [^]

fixed bug 24894: promotions code is executed twice

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0061596)
guilleaer   
2013-10-07 18:06   
verified
(0061610)
hgbot   
2013-10-08 11:42   
Repository: erp/pmods/org.openbravo.retail.posterminal-levelpricing
Changeset: c30be3b0899ae95890a224739c223e81a1f16f62
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Oct 07 12:33:48 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-levelpricing/rev/c30be3b0899ae95890a224739c223e81a1f16f62 [^]

fixed bug 24894: promotions code is executed twice

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0061612)
guilleaer   
2013-10-08 11:44   
reclosing
(0061704)
hgbot   
2013-10-16 13:38   
Repository: erp/pmods/org.openbravo.retail.posterminal.cirque
Changeset: c30be3b0899ae95890a224739c223e81a1f16f62
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Oct 07 12:33:48 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/c30be3b0899ae95890a224739c223e81a1f16f62 [^]

fixed bug 24894: promotions code is executed twice

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0061783)
guilleaer   
2013-10-17 18:29   
reclosed