Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0024378
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajorhave not tried2013-07-18 18:542013-08-26 12:23
ReporterjonalegriaesarteView Statuspublic 
Assigned Topramakrishnan 
PrioritynormalResolutionfixedFixed in Version3.0MP27
StatusclosedFix in branchpiFixed in SCM revisioncb5dd42e3937
ProjectionnoneETAnoneTarget Version3.0MP27
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tojonalegriaesarte
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0024378: Taxes are not correctly calculate in some cases

DescriptionTaxes are not correctly calculate in some cases
Steps To Reproduce- Change tarifa de ventas to price including taxes
- Create a new sales order with one line to the first product in the list
- Notice that the values calculated are:

Unit price = 1.27
Tax = 0.26
Gross = 1.53

Notice that: 1.27*1.21 (applying 21%) = 1.5367 (rounded) = 1.54

How it should work:

Gross = 1.53
Unit price = gross/taxrate = 1.26
Tax = gross - unit = 0.27
TagsMoved from MP26 to MP27
Attached Filespatch file icon tax-calculation.patch [^] (953 bytes) 2013-07-18 19:06 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00243853.0MP27 closedpramakrishnan Manual discounts are not properly applied in certain cases 
related to design defect 0032265 closedaferraz [SER QA 1434] Taxes at document level are not properly calculated in some cases 

-  Notes
(0060105)
gorkaion (developer)
2013-07-18 19:10
edited on: 2013-07-18 19:17

 Because how taxes are calculated there is always a chance of differences due to rounding.

However it is possible to reduce them. The C_GET_NET_PRICE_FROM_GROSS procedure calculates the net price from the gross price. To do this it calculates a Tax Amount. This tax amount is being rounded to the Price Precision. Changing this rounding to a higher number results in more accurate results. Attached a patch that rounds to at least 50 digits the tax amount. It has only be tested with the given example in Oracle.
(0060497)
hgbot (developer)
2013-08-05 11:17

 Repository: erp/devel/pi
Changeset: cb5dd42e39375802065ba6c031cdb3b81c6918fc
Author: Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan <at> openbravo.com>
Date: Sun Aug 04 18:01:41 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/cb5dd42e39375802065ba6c031cdb3b81c6918fc [^]

Fixes Issue 24378: Taxes are not correctly calculate in some cases

---
M src-db/database/model/functions/C_GET_NET_PRICE_FROM_GROSS.xml
---
(0060594)
pramakrishnan (developer)
2013-08-14 15:38

 Reopened to update review assigned to
(0060626)
hudsonbot (developer)
2013-08-16 20:31

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/59a1180e7f4f [^]

Maturity status: Test
(0060769)
jonalegriaesarte (reporter)
2013-08-26 12:23

 Working fine

- Issue History
Date Modified Username Field Change
2013-07-18 18:54 jonalegriaesarte New Issue
2013-07-18 18:54 jonalegriaesarte Assigned To => gorkaion
2013-07-18 18:54 jonalegriaesarte Modules => Core
2013-07-18 18:54 jonalegriaesarte Triggers an Emergency Pack => No
2013-07-18 19:06 gorkaion File Added: tax-calculation.patch
2013-07-18 19:10 gorkaion Note Added: 0060105
2013-07-18 19:10 gorkaion Assigned To gorkaion => dmiguelez
2013-07-18 19:17 gorkaion Note Edited: 0060105 View Revisions
2013-07-19 13:36 gorkaion Relationship added related to 0024385
2013-07-29 09:52 dmiguelez Assigned To dmiguelez => jonalegriaesarte
2013-08-01 09:51 jonalegriaesarte Target Version 3.0MP26 => 3.0MP27
2013-08-01 09:52 jonalegriaesarte Tag Attached: Moved from MP26 to MP27
2013-08-01 09:53 jonalegriaesarte Assigned To jonalegriaesarte => pramakrishnan
2013-08-04 09:48 pramakrishnan Status new => scheduled
2013-08-04 09:48 pramakrishnan fix_in_branch => pi
2013-08-05 11:17 hgbot Checkin
2013-08-05 11:17 hgbot Note Added: 0060497
2013-08-05 11:18 hgbot Status scheduled => resolved
2013-08-05 11:18 hgbot Resolution open => fixed
2013-08-05 11:18 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/cb5dd42e39375802065ba6c031cdb3b81c6918fc [^]
2013-08-14 15:38 pramakrishnan Note Added: 0060594
2013-08-14 15:38 pramakrishnan Status resolved => new
2013-08-14 15:38 pramakrishnan Resolution fixed => open
2013-08-14 15:38 pramakrishnan Review Assigned To => jonalegriaesarte
2013-08-14 15:38 pramakrishnan fix_in_branch pi =>
2013-08-14 15:39 pramakrishnan Status new => scheduled
2013-08-14 15:39 pramakrishnan fix_in_branch => pi
2013-08-14 15:39 pramakrishnan Status scheduled => resolved
2013-08-14 15:39 pramakrishnan Resolution open => fixed
2013-08-16 20:31 hudsonbot Checkin
2013-08-16 20:31 hudsonbot Note Added: 0060626
2013-08-26 12:23 jonalegriaesarte Note Added: 0060769
2013-08-26 12:23 jonalegriaesarte Status resolved => closed
2013-08-26 12:23 jonalegriaesarte Fixed in Version => 3.0MP27
2017-01-13 11:09 aferraz Relationship added related to 0032265

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker