Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0022767 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] 01. General setup | minor | always | 2013-01-10 12:56 | 2013-02-26 12:42 | |||
Reporter | ngarcia | View Status | public | |||||
Assigned To | AugustoMauch | |||||||
Priority | urgent | Resolution | fixed | Fixed in Version | 3.0MP21 | |||
Status | closed | Fix in branch | Fixed in SCM revision | 142b3bae0423 | ||||
Projection | none | ETA | none | Target Version | 3.0MP21 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | shankarb | |||||||
OBNetwork customer | OBPS | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | 18900 | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0022767: When saving a form personalization for the 2nd time the 'visible at' fields get empty | |||||||
Description | When saving a form personalization for the 2nd time the 'visible at' fields get empty | |||||||
Steps To Reproduce | As group admin role: Go to sales invoice window Add a form personalization to it Go to the Window Personalization window and check that the "Visible at" fields are filled Go to the sales invoice window and change the form personalization again Go to the Window Personalization window and notice that the "Visible at" fields are empty | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() | |||||||
![]() |
|
![]() |
|
(0056154) AugustoMauch (administrator) 2013-02-05 11:35 |
A patch for this issue has been attached. It will be pushed to pi once it is unfrozen for MP21. |
(0056218) jonalegriaesarte (viewer) 2013-02-06 11:45 |
Patch provided, changing the priority |
(0056436) hgbot (developer) 2013-02-14 12:13 |
Repository: erp/devel/pi Changeset: 27589dd53d4ca3d19df284c990c7bf1fdf7532f0 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Thu Feb 14 12:12:42 2013 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/27589dd53d4ca3d19df284c990c7bf1fdf7532f0 [^] Fixes issue 22767: Info is not lost when updating personalization settings When Windows Personalization is created, the 'Visible at' fields (organization, role, etc) are sent to the window personalizationa handler, where the personalization is created properly. The problem is that when an existing personalization is updated, the 'Visible at' fields were not being sent as parameters, and the window personalization handler was setting them to null. This has been fixed by only setting the 'Visible at' fields when the record is being created. When it is updated, the Visible at info should not be changed (see [1]), only the personalization data should be modified. [1] https://code.openbravo.com/erp/devel/pi/file/f721f5a384cb/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalize-form.js#l594 [^] --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/personalization/PersonalizationHandler.java --- |
(0056510) shankarb (viewer) 2013-02-18 10:36 |
The Visible at value in 'Window Personalization' window is not updated, if the level of the view is updated. Steps to reproduce. 1. Open Save View and create a view with Level 'User'. 2. In the 'Window Personalization' window the values of the view is set properly. 3. Open Save View again and choose the already created view and change the level to 'Client'. 4. Notice that it is not updated for the view in the Window Personalization window. The Visibility is still 'User'. |
(0056598) hudsonbot (viewer) 2013-02-20 04:50 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d828167a9e83 [^] Maturity status: Test |
(0056688) hgbot (developer) 2013-02-21 16:45 |
Repository: erp/devel/pi Changeset: 142b3bae0423b1cae7812cdec2974198cee215d7 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Thu Feb 21 16:44:32 2013 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/142b3bae0423b1cae7812cdec2974198cee215d7 [^] Fixes issue 22767: Info is not lost when updating personalization settings Fix has been refactored and improved: - When a personalization is going to be stored, the parameters carry a new parameter called applyLevelInformation. If the value of this parameter is false, th en the level information (client, organization, role and user) will not be fetched from the request, but from the existing personalization. The only point in which this parameter is false is when a Form personalization is updated. The changes made in the PersonalizationHandler class have been reverted, they are not needed anymore. --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/personalization/PersonalizationActionHandler.java M modules/org.openbravo.client.application/src/org/openbravo/client/application/personalization/PersonalizationHandler.java M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-manage-views.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalize-form.js --- |
(0056717) hudsonbot (viewer) 2013-02-22 07:57 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b99c43bfb674 [^] Maturity status: Test |
(0056768) shankarb (viewer) 2013-02-26 12:42 |
Code reviewed and tested in pi changeset 059d60b862a4 |
![]() |
|||
Date Modified | Username | Field | Change |
2013-01-10 12:56 | ngarcia | New Issue | |
2013-01-10 12:56 | ngarcia | Assigned To | => dmiguelez |
2013-01-10 12:56 | ngarcia | Modules | => Core |
2013-01-10 12:56 | ngarcia | OBNetwork customer | => Yes |
2013-01-10 12:56 | ngarcia | Support ticket | => 18900 |
2013-01-10 12:56 | ngarcia | Resolution time | => 1358204400 |
2013-01-10 12:56 | ngarcia | Triggers an Emergency Pack | => No |
2013-01-10 12:56 | ngarcia | Issue Monitored: networkb | |
2013-01-10 13:00 | ngarcia | Assigned To | dmiguelez => AugustoMauch |
2013-02-04 17:52 | alostale | Target Version | => 3.0MP20 |
2013-02-05 09:59 | AugustoMauch | File Added: issue22767.diff | |
2013-02-05 11:35 | AugustoMauch | Note Added: 0056154 | |
2013-02-05 11:36 | AugustoMauch | Status | new => scheduled |
2013-02-05 11:36 | AugustoMauch | fix_in_branch | => pi |
2013-02-05 11:36 | AugustoMauch | Target Version | 3.0MP20 => 3.0MP21 |
2013-02-05 11:36 | AugustoMauch | fix_in_branch | pi => |
2013-02-06 11:45 | jonalegriaesarte | Note Added: 0056218 | |
2013-02-06 11:45 | jonalegriaesarte | Priority | immediate => urgent |
2013-02-14 12:13 | AugustoMauch | Issue Monitored: shankarb | |
2013-02-14 12:13 | AugustoMauch | Review Assigned To | => shankarb |
2013-02-14 12:13 | hgbot | Checkin | |
2013-02-14 12:13 | hgbot | Note Added: 0056436 | |
2013-02-14 12:13 | hgbot | Status | scheduled => resolved |
2013-02-14 12:13 | hgbot | Resolution | open => fixed |
2013-02-14 12:13 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/27589dd53d4ca3d19df284c990c7bf1fdf7532f0 [^] |
2013-02-18 10:36 | shankarb | Note Added: 0056510 | |
2013-02-18 10:36 | shankarb | Status | resolved => new |
2013-02-18 10:36 | shankarb | Resolution | fixed => open |
2013-02-20 04:50 | hudsonbot | Checkin | |
2013-02-20 04:50 | hudsonbot | Note Added: 0056598 | |
2013-02-21 16:45 | hgbot | Checkin | |
2013-02-21 16:45 | hgbot | Note Added: 0056688 | |
2013-02-21 16:45 | hgbot | Status | new => resolved |
2013-02-21 16:45 | hgbot | Resolution | open => fixed |
2013-02-21 16:45 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/27589dd53d4ca3d19df284c990c7bf1fdf7532f0 [^] => http://code.openbravo.com/erp/devel/pi/rev/142b3bae0423b1cae7812cdec2974198cee215d7 [^] |
2013-02-22 07:57 | hudsonbot | Checkin | |
2013-02-22 07:57 | hudsonbot | Note Added: 0056717 | |
2013-02-26 12:42 | shankarb | Note Added: 0056768 | |
2013-02-26 12:42 | shankarb | Status | resolved => closed |
2013-02-26 12:42 | shankarb | Fixed in Version | => 3.0MP21 |
Copyright © 2000 - 2009 MantisBT Group |