Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022767Openbravo ERP01. General setuppublic2013-01-10 12:562013-02-26 12:42
Reporterngarcia 
Assigned ToAugustoMauch 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP21Fixed in Version3.0MP21 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket18900
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022767: When saving a form personalization for the 2nd time the 'visible at' fields get empty
DescriptionWhen saving a form personalization for the 2nd time the 'visible at' fields get empty
Steps To ReproduceAs group admin role:
   Go to sales invoice window
   Add a form personalization to it
   Go to the Window Personalization window and check that the "Visible at" fields are filled
   Go to the sales invoice window and change the form personalization again
   Go to the Window Personalization window and notice that the "Visible at" fields are empty
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff issue22767.diff (3,153) 2013-02-05 09:59
https://issues.openbravo.com/file_download.php?file_id=5933&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-01-10 12:56ngarciaNew Issue
2013-01-10 12:56ngarciaAssigned To => dmiguelez
2013-01-10 12:56ngarciaModules => Core
2013-01-10 12:56ngarciaOBNetwork customer => Yes
2013-01-10 12:56ngarciaSupport ticket => 18900
2013-01-10 12:56ngarciaResolution time => 1358204400
2013-01-10 12:56ngarciaTriggers an Emergency Pack => No
2013-01-10 12:56ngarciaIssue Monitored: networkb
2013-01-10 13:00ngarciaAssigned Todmiguelez => AugustoMauch
2013-02-04 17:52alostaleTarget Version => 3.0MP20
2013-02-05 09:59AugustoMauchFile Added: issue22767.diff
2013-02-05 11:35AugustoMauchNote Added: 0056154
2013-02-05 11:36AugustoMauchStatusnew => scheduled
2013-02-05 11:36AugustoMauchfix_in_branch => pi
2013-02-05 11:36AugustoMauchTarget Version3.0MP20 => 3.0MP21
2013-02-05 11:36AugustoMauchfix_in_branchpi =>
2013-02-06 11:45jonalegriaesarteNote Added: 0056218
2013-02-06 11:45jonalegriaesartePriorityimmediate => urgent
2013-02-14 12:13AugustoMauchIssue Monitored: shankarb
2013-02-14 12:13AugustoMauchReview Assigned To => shankarb
2013-02-14 12:13hgbotCheckin
2013-02-14 12:13hgbotNote Added: 0056436
2013-02-14 12:13hgbotStatusscheduled => resolved
2013-02-14 12:13hgbotResolutionopen => fixed
2013-02-14 12:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/27589dd53d4ca3d19df284c990c7bf1fdf7532f0 [^]
2013-02-18 10:36shankarbNote Added: 0056510
2013-02-18 10:36shankarbStatusresolved => new
2013-02-18 10:36shankarbResolutionfixed => open
2013-02-20 04:50hudsonbotCheckin
2013-02-20 04:50hudsonbotNote Added: 0056598
2013-02-21 16:45hgbotCheckin
2013-02-21 16:45hgbotNote Added: 0056688
2013-02-21 16:45hgbotStatusnew => resolved
2013-02-21 16:45hgbotResolutionopen => fixed
2013-02-21 16:45hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/27589dd53d4ca3d19df284c990c7bf1fdf7532f0 [^] => http://code.openbravo.com/erp/devel/pi/rev/142b3bae0423b1cae7812cdec2974198cee215d7 [^]
2013-02-22 07:57hudsonbotCheckin
2013-02-22 07:57hudsonbotNote Added: 0056717
2013-02-26 12:42shankarbNote Added: 0056768
2013-02-26 12:42shankarbStatusresolved => closed
2013-02-26 12:42shankarbFixed in Version => 3.0MP21

Notes
(0056154)
AugustoMauch   
2013-02-05 11:35   
A patch for this issue has been attached. It will be pushed to pi once it is unfrozen for MP21.
(0056218)
jonalegriaesarte   
2013-02-06 11:45   
Patch provided, changing the priority
(0056436)
hgbot   
2013-02-14 12:13   
Repository: erp/devel/pi
Changeset: 27589dd53d4ca3d19df284c990c7bf1fdf7532f0
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Feb 14 12:12:42 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/27589dd53d4ca3d19df284c990c7bf1fdf7532f0 [^]

Fixes issue 22767: Info is not lost when updating personalization settings

When Windows Personalization is created, the 'Visible at' fields (organization, role, etc) are sent to the window personalizationa handler, where the personalization is created properly. The problem is that when an existing personalization is updated, the 'Visible at' fields were not being sent as parameters, and the window personalization handler was setting them to null.

This has been fixed by only setting the 'Visible at' fields when the record is being created. When it is updated, the Visible at info should not be changed (see [1]), only the personalization data should be modified.

[1] https://code.openbravo.com/erp/devel/pi/file/f721f5a384cb/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalize-form.js#l594 [^]

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/personalization/PersonalizationHandler.java
---
(0056510)
shankarb   
2013-02-18 10:36   
The Visible at value in 'Window Personalization' window is not updated, if the level of the view is updated.

Steps to reproduce.
1. Open Save View and create a view with Level 'User'.
2. In the 'Window Personalization' window the values of the view is set properly.
3. Open Save View again and choose the already created view and change the level to 'Client'.
4. Notice that it is not updated for the view in the Window Personalization window. The Visibility is still 'User'.
(0056598)
hudsonbot   
2013-02-20 04:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d828167a9e83 [^]

Maturity status: Test
(0056688)
hgbot   
2013-02-21 16:45   
Repository: erp/devel/pi
Changeset: 142b3bae0423b1cae7812cdec2974198cee215d7
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Feb 21 16:44:32 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/142b3bae0423b1cae7812cdec2974198cee215d7 [^]

Fixes issue 22767: Info is not lost when updating personalization settings

Fix has been refactored and improved:
- When a personalization is going to be stored, the parameters carry a new parameter called applyLevelInformation. If the value of this parameter is false, th
en the level information (client, organization, role and user) will not be fetched from the request, but from the existing personalization. The only point in
which this parameter is false is when a Form personalization is updated.

The changes made in the PersonalizationHandler class have been reverted, they are not needed anymore.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/personalization/PersonalizationActionHandler.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/personalization/PersonalizationHandler.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-manage-views.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalize-form.js
---
(0056717)
hudsonbot   
2013-02-22 07:57   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b99c43bfb674 [^]

Maturity status: Test
(0056768)
shankarb   
2013-02-26 12:42   
Code reviewed and tested in pi changeset 059d60b862a4