Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0020819
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorsometimes2012-06-20 16:572012-06-27 05:28
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PriorityimmediateResolutionfixedFixed in Version3.0MP13
StatusclosedFix in branchFixed in SCM revision99602b3c2a17
ProjectionnoneETAnoneTarget Version3.0MP13
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression levelPre packaging ( pi )
Regression date2012-06-12
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/976c8398def2e80de470ab55db222555d88566d8 [^]
Triggers an Emergency PackNo
Summary

0020819: NullPointerException is thrown if a time is null

DescriptionIn the Process Request window, is a process has a time with value null, the getFieldProperties of TimeUIDefinition throws the following exception:

pro595dbc4c 1872929 [http-8880-4] ERROR org.openbravo.base.exception.OBException - Couldn't get data for column Finishes_Time
java.lang.NullPointerException
    at org.openbravo.client.kernel.reference.TimeUIDefinition.getFieldProperties(TimeUIDefinition.java:89)
    at org.openbravo.client.application.window.FormInitializationComponent.computeColumnValues(FormInitializationComponent.java:570)
    at org.openbravo.client.application.window.FormInitializationComponent.execute(FormInitializationComponent.java:227)
    at org.openbravo.client.kernel.BaseActionHandler.execute(BaseActionHandler.java:71)
    at org.openbravo.client.kernel.KernelServlet.processActionRequest(KernelServlet.java:193)
Steps To Reproduce- Open the Process Request window
- Open in form view a process whose Finish Time is null.
- Return to grid view. The exception will be thrown
Proposed SolutionReplace the columnValue.isEmpty() with StringUtils.isEmpty(columnValue). That way, the function will return true for a null columnValue, instead of throwing a NullPointerException.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0020684 closedAugustoMauch Incorrect time in process request with different timezones in client/server 

-  Notes
(0049955)
hgbot (developer)
2012-06-20 17:04

 Repository: erp/devel/pi
Changeset: 99602b3c2a1798756c847feeae94437babed2d9c
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Jun 20 17:03:55 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/99602b3c2a1798756c847feeae94437babed2d9c [^]

Fixes issue 20819. Related to issue 20684. NPE prevented.

A NullPointerException has been prevented by replacing columnValue.isEmpty() with StringUtils.isEmpty(columnValue), which returns true if columnValue is null, instead of throwing a NullPointerException.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/TimeUIDefinition.java
---
(0049986)
alostale (manager)
2012-06-21 15:46

 Code reviewed and verified on pi@20d1a6b019e0
(0050132)
hudsonbot (developer)
2012-06-27 05:28

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf3a7135839f [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-06-20 16:57 AugustoMauch New Issue
2012-06-20 16:57 AugustoMauch Assigned To => AugustoMauch
2012-06-20 16:57 AugustoMauch Modules => Core
2012-06-20 16:58 AugustoMauch Relationship added related to 0020684
2012-06-20 17:00 AugustoMauch Regression level => Pre packaging ( pi )
2012-06-20 17:00 AugustoMauch Regression date => 2012-06-12
2012-06-20 17:00 AugustoMauch Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/976c8398def2e80de470ab55db222555d88566d8 [^]
2012-06-20 17:04 hgbot Checkin
2012-06-20 17:04 hgbot Note Added: 0049955
2012-06-20 17:04 hgbot Status new => resolved
2012-06-20 17:04 hgbot Resolution open => fixed
2012-06-20 17:04 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/99602b3c2a1798756c847feeae94437babed2d9c [^]
2012-06-21 15:46 alostale Note Added: 0049986
2012-06-21 15:46 alostale Status resolved => closed
2012-06-21 15:46 alostale Fixed in Version => 3.0MP13
2012-06-27 05:28 hudsonbot Checkin
2012-06-27 05:28 hudsonbot Note Added: 0050132

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker