Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020819Openbravo ERPA. Platformpublic2012-06-20 16:572012-06-27 05:28
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PriorityimmediateSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP13Fixed in Version3.0MP13 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2012-06-12
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/976c8398def2e80de470ab55db222555d88566d8 [^]
Triggers an Emergency PackNo
Summary0020819: NullPointerException is thrown if a time is null
DescriptionIn the Process Request window, is a process has a time with value null, the getFieldProperties of TimeUIDefinition throws the following exception:

pro595dbc4c 1872929 [http-8880-4] ERROR org.openbravo.base.exception.OBException - Couldn't get data for column Finishes_Time
java.lang.NullPointerException
    at org.openbravo.client.kernel.reference.TimeUIDefinition.getFieldProperties(TimeUIDefinition.java:89)
    at org.openbravo.client.application.window.FormInitializationComponent.computeColumnValues(FormInitializationComponent.java:570)
    at org.openbravo.client.application.window.FormInitializationComponent.execute(FormInitializationComponent.java:227)
    at org.openbravo.client.kernel.BaseActionHandler.execute(BaseActionHandler.java:71)
    at org.openbravo.client.kernel.KernelServlet.processActionRequest(KernelServlet.java:193)
Steps To Reproduce- Open the Process Request window
- Open in form view a process whose Finish Time is null.
- Return to grid view. The exception will be thrown
Proposed SolutionReplace the columnValue.isEmpty() with StringUtils.isEmpty(columnValue). That way, the function will return true for a null columnValue, instead of throwing a NullPointerException.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0020684 closed AugustoMauch Incorrect time in process request with different timezones in client/server 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-06-20 16:57AugustoMauchNew Issue
2012-06-20 16:57AugustoMauchAssigned To => AugustoMauch
2012-06-20 16:57AugustoMauchModules => Core
2012-06-20 16:57AugustoMauchOBNetwork customer => No
2012-06-20 16:58AugustoMauchRelationship addedrelated to 0020684
2012-06-20 17:00AugustoMauchRegression level => Pre packaging ( pi )
2012-06-20 17:00AugustoMauchRegression date => 2012-06-12
2012-06-20 17:00AugustoMauchRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/976c8398def2e80de470ab55db222555d88566d8 [^]
2012-06-20 17:04hgbotCheckin
2012-06-20 17:04hgbotNote Added: 0049955
2012-06-20 17:04hgbotStatusnew => resolved
2012-06-20 17:04hgbotResolutionopen => fixed
2012-06-20 17:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/99602b3c2a1798756c847feeae94437babed2d9c [^]
2012-06-21 15:46alostaleNote Added: 0049986
2012-06-21 15:46alostaleStatusresolved => closed
2012-06-21 15:46alostaleFixed in Version => 3.0MP13
2012-06-27 05:28hudsonbotCheckin
2012-06-27 05:28hudsonbotNote Added: 0050132

Notes
(0049955)
hgbot   
2012-06-20 17:04   
Repository: erp/devel/pi
Changeset: 99602b3c2a1798756c847feeae94437babed2d9c
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Jun 20 17:03:55 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/99602b3c2a1798756c847feeae94437babed2d9c [^]

Fixes issue 20819. Related to issue 20684. NPE prevented.

A NullPointerException has been prevented by replacing columnValue.isEmpty() with StringUtils.isEmpty(columnValue), which returns true if columnValue is null, instead of throwing a NullPointerException.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/TimeUIDefinition.java
---
(0049986)
alostale   
2012-06-21 15:46   
Code reviewed and verified on pi@20d1a6b019e0
(0050132)
hudsonbot   
2012-06-27 05:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf3a7135839f [^]

Maturity status: Test