Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0020124
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2012-03-27 13:442012-04-02 06:12
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PriorityimmediateResolutionfixedFixed in Version3.0MP10
StatusclosedFix in branchFixed in SCM revisionbbc8472daf24
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020124: Usage audit is not working for fetch actions

DescriptionUsage audit is not working for fetch actions.

Regression introduced by an incorrect use of usage audit without dal added when fixing 0019895
Steps To ReproduceOpen any window and check usage is not audited.
TagsRegression QA
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0019895 closedalostale CPU spike during invoice header click 
related to feature request 0020132 closedalostale Add process time to usage audit 
blocks defect 00201023.0MP10 closedalostale The usage audit can not be disable 

-  Notes
(0046767)
hgbot (developer)
2012-03-27 13:49

Repository: erp/devel/pi
Changeset: bbc8472daf24a1aba962f3936d375bbfc3c0c9ae
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Mar 27 13:48:53 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/bbc8472daf24a1aba962f3936d375bbfc3c0c9ae [^]

fixed bug 20124: Usage audit is not working for fetch actions

  The fix includes:
    -Moved setting session info to DataSourceServlet.service. In this way it is
     possible to use HSAS auditing intead of invoking it directly from DataSourceServlet.service
     reducing one call per request.
    -For insert/update/delete don't set the complete session info again, as it is done in
     service, but just db info for audit trail if needed.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
M src-core/src/org/openbravo/database/SessionInfo.java
M src/org/openbravo/erpCommon/security/UsageAudit.java
---
(0046768)
alostale (manager)
2012-03-27 13:55

The fix does a small refactor in the way DataSourceServlet audits usage (see commit description). Test plan:
 *Usage audit still works:
   -Open a generated window and filter it: a fetch action should be audited for each datasource retrieval.
   -Insert/update and delete a record: these actions should be audited
   -Open a 2.50 process and execute it: DEFAULT and selected actions should be audited.
 *Audit trail still works: activate fully auditing for a table and check the following actions are properly audited including action, user and window.
   -Edit a record
   -Remove a record
   -Update a record
(0046803)
hgbot (developer)
2012-03-28 10:04

Repository: erp/devel/pi
Changeset: ef2879e82d2cd172621bcf518fc0b7c0b4652eea
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Mar 28 10:04:19 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ef2879e82d2cd172621bcf518fc0b7c0b4652eea [^]

related to bug 20124
 Proper setting of command for 2.50 windows:
  -Reset command ThreadLocal on request finalization
  -In HSAS, set command from vars if it is not already set

---
M src-core/src/org/openbravo/database/SessionInfo.java
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
---
(0047240)
hudsonbot (developer)
2012-04-02 06:12

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test
(0047251)
hudsonbot (developer)
2012-04-02 06:12

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-03-27 13:44 alostale New Issue
2012-03-27 13:44 alostale Assigned To => alostale
2012-03-27 13:44 alostale Modules => Core
2012-03-27 13:44 alostale Relationship added related to 0019895
2012-03-27 13:44 alostale Tag Attached: Regression QA
2012-03-27 13:49 hgbot Checkin
2012-03-27 13:49 hgbot Note Added: 0046767
2012-03-27 13:49 hgbot Status new => resolved
2012-03-27 13:49 hgbot Resolution open => fixed
2012-03-27 13:49 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bbc8472daf24a1aba962f3936d375bbfc3c0c9ae [^]
2012-03-27 13:50 alostale Relationship added blocks 0020102
2012-03-27 13:55 alostale Note Added: 0046768
2012-03-28 10:04 hgbot Checkin
2012-03-28 10:04 hgbot Note Added: 0046803
2012-03-28 10:35 alostale Relationship added related to 0020132
2012-03-28 16:13 marvintm Status resolved => closed
2012-03-28 16:13 marvintm Fixed in Version => 3.0MP10
2012-04-02 06:12 hudsonbot Checkin
2012-04-02 06:12 hudsonbot Note Added: 0047240
2012-04-02 06:12 hudsonbot Checkin
2012-04-02 06:12 hudsonbot Note Added: 0047251


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker