Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020124Openbravo ERPA. Platformpublic2012-03-27 13:442012-04-02 06:12
Reporteralostale 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP10 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020124: Usage audit is not working for fetch actions
DescriptionUsage audit is not working for fetch actions.

Regression introduced by an incorrect use of usage audit without dal added when fixing 0019895
Steps To ReproduceOpen any window and check usage is not audited.
Proposed Solution
Additional Information
TagsRegression QA
Relationships
related to design defect 0019895 closed alostale CPU spike during invoice header click 
related to feature request 0020132 closed alostale Add process time to usage audit 
blocks defect 00201023.0MP10 closed alostale The usage audit can not be disable 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-03-27 13:44alostaleNew Issue
2012-03-27 13:44alostaleAssigned To => alostale
2012-03-27 13:44alostaleModules => Core
2012-03-27 13:44alostaleOBNetwork customer => No
2012-03-27 13:44alostaleRelationship addedrelated to 0019895
2012-03-27 13:44alostaleTag Attached: Regression QA
2012-03-27 13:49hgbotCheckin
2012-03-27 13:49hgbotNote Added: 0046767
2012-03-27 13:49hgbotStatusnew => resolved
2012-03-27 13:49hgbotResolutionopen => fixed
2012-03-27 13:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bbc8472daf24a1aba962f3936d375bbfc3c0c9ae [^]
2012-03-27 13:50alostaleRelationship addedblocks 0020102
2012-03-27 13:55alostaleNote Added: 0046768
2012-03-28 10:04hgbotCheckin
2012-03-28 10:04hgbotNote Added: 0046803
2012-03-28 10:35alostaleRelationship addedrelated to 0020132
2012-03-28 16:13marvintmStatusresolved => closed
2012-03-28 16:13marvintmFixed in Version => 3.0MP10
2012-04-02 06:12hudsonbotCheckin
2012-04-02 06:12hudsonbotNote Added: 0047240
2012-04-02 06:12hudsonbotCheckin
2012-04-02 06:12hudsonbotNote Added: 0047251

Notes
(0046767)
hgbot   
2012-03-27 13:49   
Repository: erp/devel/pi
Changeset: bbc8472daf24a1aba962f3936d375bbfc3c0c9ae
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Mar 27 13:48:53 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/bbc8472daf24a1aba962f3936d375bbfc3c0c9ae [^]

fixed bug 20124: Usage audit is not working for fetch actions

  The fix includes:
    -Moved setting session info to DataSourceServlet.service. In this way it is
     possible to use HSAS auditing intead of invoking it directly from DataSourceServlet.service
     reducing one call per request.
    -For insert/update/delete don't set the complete session info again, as it is done in
     service, but just db info for audit trail if needed.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
M src-core/src/org/openbravo/database/SessionInfo.java
M src/org/openbravo/erpCommon/security/UsageAudit.java
---
(0046768)
alostale   
2012-03-27 13:55   
The fix does a small refactor in the way DataSourceServlet audits usage (see commit description). Test plan:
 *Usage audit still works:
   -Open a generated window and filter it: a fetch action should be audited for each datasource retrieval.
   -Insert/update and delete a record: these actions should be audited
   -Open a 2.50 process and execute it: DEFAULT and selected actions should be audited.
 *Audit trail still works: activate fully auditing for a table and check the following actions are properly audited including action, user and window.
   -Edit a record
   -Remove a record
   -Update a record
(0046803)
hgbot   
2012-03-28 10:04   
Repository: erp/devel/pi
Changeset: ef2879e82d2cd172621bcf518fc0b7c0b4652eea
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Mar 28 10:04:19 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ef2879e82d2cd172621bcf518fc0b7c0b4652eea [^]

related to bug 20124
 Proper setting of command for 2.50 windows:
  -Reset command ThreadLocal on request finalization
  -In HSAS, set command from vars if it is not already set

---
M src-core/src/org/openbravo/database/SessionInfo.java
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
---
(0047240)
hudsonbot   
2012-04-02 06:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test
(0047251)
hudsonbot   
2012-04-02 06:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test