Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0019854
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2012-02-23 16:092012-03-02 15:40
ReporterdbazView Statuspublic 
Assigned Todbaz 
PriorityurgentResolutionfixedFixed in Version3.0MP9
StatusclosedFix in branchpiFixed in SCM revisiona29dadb6f431
ProjectionnoneETAnoneTarget Version3.0MP9
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browserMozilla Firefox
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0019854: Problem with some processes when accessing the ERP from an external link

DescriptionProblem with some processes when accessing the ERP from an external link. It seems to happen only using Firefox.
Steps To ReproduceUse attached "example.html", configure it with your context, and use it to access the ERP.

Using FIREFOX and as "Openbravo Admin"
* Go to "Sales Invoice"
* Click "Reactivate" button of any completed sales invoice
* Click "OK" in the opened modal popup

Notice that the popup become white and the process is not executed.

PD about "example.html":
* Don't close/reload this window until you finish your tests!
* This page should be loaded from a different context than your Openbravo context (running it directly form any folder of your computer is enough, so there is no need of a special/dedicated server)
TagsNo tags attached.
Attached Fileshtml file icon example.html [^] (699 bytes) 2012-02-23 16:09
? file icon popup.bmp [^] (3,072,054 bytes) 2012-02-24 12:57

- Relationships [ Relation Graph ] [ Dependency Graph ]
has duplicate defect 0019038 closedalostale App opened with window.open or link from another domain makes popups not to work 

-  Notes
(0045414)
dbaz (developer)
2012-02-23 16:23
edited on: 2012-02-23 16:24

 The risk of the fix is medium, since it involves to a lot of classic processes configured in different way, so a complete test case is going to be provided.
The COMPLETE test case (the six points) MUST be run three times: in IE, Firefox and Chrome to ensure all browser's behavior is the same (and is the good one):

a) Open a process in a modal popup accessing the erp url directly:
As "Openbravo Admin":
* Go to "Sales Invoice"
* Click "Reactivate" button of any completed sales invoice
* Click "OK" in the opened modal popup
Ensure that the action is properly done

b) Open a process in a modal popup accessing the erp from attached example.html:
* The same than "a)" but accessing the erp from example.html


c) Open a process in a real browser popup accessing the erp url directly:
As "System":
* Go to "Preferences"
* Change the value "Y" to "N" in the record with Attribute "ModalModuleorg.openbravo.advpaymentmngt"
* Save
As "Openbravo Admin":
* Go to "Sales Invoice"
* Click "Reactivate" button of any completed sales invoice
* Click "OK" in the opened real browser popup
Ensure that the action is properly done

d) Open a process in a real browser popup accessing the erp from attached example.html:
* The same than "c)" but accessing the erp from example.html


e) Open a process in 2.50 classic way accessing the erp url directly:
To access the application in 2.50 classic way, you have to enter as is said in the last paragraph of:
http://wiki.openbravo.com/wiki/How_To_Switch_to_Classic_Mode [^]
As "Openbravo Admin":
* Go to "Sales Management" > "Transactions" > "Sales Invoice"
* Click "Reactivate" button of any completed sales invoice
* Click "OK" in the opened modal popup
Ensure that the action is properly done

f) Open a process in 2.50 classic way accessing the erp from attached example.html:
* The same than "e)" but accessing the erp from example.html (note that you should provide in it the classic path used in "e)")
(0045415)
hgbot (developer)
2012-02-23 16:35

 Repository: erp/devel/pi
Changeset: a29dadb6f4310e686feffc53c0e6fc8d96d1323a
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Thu Feb 23 16:34:47 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a29dadb6f4310e686feffc53c0e6fc8d96d1323a [^]

Fixed issue 19854: Processes now run ok if OB is loaded form an external link

---
M src/org/openbravo/base/secureApp/PopUp_Response.html
---
(0045423)
hgbot (developer)
2012-02-23 20:11

 Repository: erp/devel/pi
Changeset: 3cf10cdf730fe75eaa4c56a2dbc578182ec93c8a
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Thu Feb 23 20:10:39 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3cf10cdf730fe75eaa4c56a2dbc578182ec93c8a [^]

Related to issue 19854: reimplemented fix in a different way

---
M src/org/openbravo/base/secureApp/PopUp_Response.html
---
(0045442)
jecharri (developer)
2012-02-24 12:54

 Verified and it is working in the next browser:
-Firefox 10.0.2
-Chrome 16.0.912.77
-IE 8

In IE exist one problem when you try to go to window "Sales Invoice":
-"ModalModuleorg.openbravo.advpaymentmngt"= 'Y' or 'N'
-Open a process in a real browser popup accessing the erp from attached example.html

I have attached the popup with the error
(0045488)
jecharri (developer)
2012-02-27 21:40

 Verified in IE9 and it works perfect
(0045496)
alostale (manager)
2012-02-28 08:43

 Code review: just an small change, add a comment to the "} catch (e) {} " line to explain when the exception might be thrown and why it is ok not to do anything else.
(0045563)
hgbot (developer)
2012-02-29 00:35

 Repository: erp/devel/pi
Changeset: 3afb79bd373022e61052d79c65c9853e6d9e427b
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Wed Feb 29 00:35:04 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3afb79bd373022e61052d79c65c9853e6d9e427b [^]

Related to issue 19854: Clarification comment added

---
M src/org/openbravo/base/secureApp/PopUp_Response.html
---
(0045943)
hudsonbot (developer)
2012-03-02 15:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0045947)
hudsonbot (developer)
2012-03-02 15:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0045977)
hudsonbot (developer)
2012-03-02 15:40

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-02-23 16:09 dbaz New Issue
2012-02-23 16:09 dbaz Assigned To => dbaz
2012-02-23 16:09 dbaz File Added: example.html
2012-02-23 16:09 dbaz Web browser => Mozilla Firefox
2012-02-23 16:09 dbaz Modules => Core
2012-02-23 16:23 dbaz Note Added: 0045414
2012-02-23 16:24 dbaz Note Edited: 0045414 View Revisions
2012-02-23 16:24 dbaz Note Edited: 0045414 View Revisions
2012-02-23 16:24 dbaz Note Edited: 0045414 View Revisions
2012-02-23 16:35 hgbot Checkin
2012-02-23 16:35 hgbot Note Added: 0045415
2012-02-23 16:35 hgbot Status new => resolved
2012-02-23 16:35 hgbot Resolution open => fixed
2012-02-23 16:35 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a29dadb6f4310e686feffc53c0e6fc8d96d1323a [^]
2012-02-23 20:11 hgbot Checkin
2012-02-23 20:11 hgbot Note Added: 0045423
2012-02-24 12:54 jecharri Note Added: 0045442
2012-02-24 12:54 jecharri Status resolved => new
2012-02-24 12:54 jecharri Resolution fixed => open
2012-02-24 12:57 jecharri File Added: popup.bmp
2012-02-24 12:59 jecharri Status new => feedback
2012-02-24 13:11 jecharri Web browser Mozilla Firefox => Mozilla Firefox
2012-02-27 21:40 jecharri Status feedback => scheduled
2012-02-27 21:40 jecharri fix_in_branch => pi
2012-02-27 21:40 jecharri Status scheduled => resolved
2012-02-27 21:40 jecharri Fixed in Version => 3.0MP9
2012-02-27 21:40 jecharri Resolution open => fixed
2012-02-27 21:40 jecharri Note Added: 0045488
2012-02-27 21:40 jecharri Status resolved => closed
2012-02-28 08:41 alostale Relationship added has duplicate 0019038
2012-02-28 08:43 alostale Note Added: 0045496
2012-02-29 00:35 hgbot Checkin
2012-02-29 00:35 hgbot Note Added: 0045563
2012-03-02 15:39 hudsonbot Checkin
2012-03-02 15:39 hudsonbot Note Added: 0045943
2012-03-02 15:39 hudsonbot Checkin
2012-03-02 15:39 hudsonbot Note Added: 0045947
2012-03-02 15:40 hudsonbot Checkin
2012-03-02 15:40 hudsonbot Note Added: 0045977

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker