Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0019854 | Openbravo ERP | A. Platform | public | 2012-02-23 16:09 | 2012-03-02 15:40 |
|
| Reporter | dbaz | |
| Assigned To | dbaz | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | 3.0MP9 | Fixed in Version | 3.0MP9 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | Mozilla Firefox |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0019854: Problem with some processes when accessing the ERP from an external link |
| Description | Problem with some processes when accessing the ERP from an external link. It seems to happen only using Firefox. |
| Steps To Reproduce | Use attached "example.html", configure it with your context, and use it to access the ERP.
Using FIREFOX and as "Openbravo Admin"
* Go to "Sales Invoice"
* Click "Reactivate" button of any completed sales invoice
* Click "OK" in the opened modal popup
Notice that the popup become white and the process is not executed.
PD about "example.html":
* Don't close/reload this window until you finish your tests!
* This page should be loaded from a different context than your Openbravo context (running it directly form any folder of your computer is enough, so there is no need of a special/dedicated server) |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | has duplicate | defect | 0019038 | | closed | alostale | App opened with window.open or link from another domain makes popups not to work |
|
| Attached Files |  example.html (699) 2012-02-23 16:09
https://issues.openbravo.com/file_download.php?file_id=5021&type=bug
 popup.bmp (3,072,054) 2012-02-24 12:57
https://issues.openbravo.com/file_download.php?file_id=5024&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2012-02-23 16:09 | dbaz | New Issue | |
| 2012-02-23 16:09 | dbaz | Assigned To | => dbaz |
| 2012-02-23 16:09 | dbaz | File Added: example.html | |
| 2012-02-23 16:09 | dbaz | Web browser | => Mozilla Firefox |
| 2012-02-23 16:09 | dbaz | Modules | => Core |
| 2012-02-23 16:23 | dbaz | Note Added: 0045414 | |
| 2012-02-23 16:24 | dbaz | Note Edited: 0045414 | bug_revision_view_page.php?bugnote_id=0045414#r3203 |
| 2012-02-23 16:24 | dbaz | Note Edited: 0045414 | bug_revision_view_page.php?bugnote_id=0045414#r3204 |
| 2012-02-23 16:24 | dbaz | Note Edited: 0045414 | bug_revision_view_page.php?bugnote_id=0045414#r3205 |
| 2012-02-23 16:35 | hgbot | Checkin | |
| 2012-02-23 16:35 | hgbot | Note Added: 0045415 | |
| 2012-02-23 16:35 | hgbot | Status | new => resolved |
| 2012-02-23 16:35 | hgbot | Resolution | open => fixed |
| 2012-02-23 16:35 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/a29dadb6f4310e686feffc53c0e6fc8d96d1323a [^] |
| 2012-02-23 20:11 | hgbot | Checkin | |
| 2012-02-23 20:11 | hgbot | Note Added: 0045423 | |
| 2012-02-24 12:54 | jecharri | Note Added: 0045442 | |
| 2012-02-24 12:54 | jecharri | Status | resolved => new |
| 2012-02-24 12:54 | jecharri | Resolution | fixed => open |
| 2012-02-24 12:57 | jecharri | File Added: popup.bmp | |
| 2012-02-24 12:59 | jecharri | Status | new => feedback |
| 2012-02-24 13:11 | jecharri | Web browser | Mozilla Firefox => Mozilla Firefox |
| 2012-02-27 21:40 | jecharri | Status | feedback => scheduled |
| 2012-02-27 21:40 | jecharri | fix_in_branch | => pi |
| 2012-02-27 21:40 | jecharri | Status | scheduled => resolved |
| 2012-02-27 21:40 | jecharri | Fixed in Version | => 3.0MP9 |
| 2012-02-27 21:40 | jecharri | Resolution | open => fixed |
| 2012-02-27 21:40 | jecharri | Note Added: 0045488 | |
| 2012-02-27 21:40 | jecharri | Status | resolved => closed |
| 2012-02-28 08:41 | alostale | Relationship added | has duplicate 0019038 |
| 2012-02-28 08:43 | alostale | Note Added: 0045496 | |
| 2012-02-29 00:35 | hgbot | Checkin | |
| 2012-02-29 00:35 | hgbot | Note Added: 0045563 | |
| 2012-03-02 15:39 | hudsonbot | Checkin | |
| 2012-03-02 15:39 | hudsonbot | Note Added: 0045943 | |
| 2012-03-02 15:39 | hudsonbot | Checkin | |
| 2012-03-02 15:39 | hudsonbot | Note Added: 0045947 | |
| 2012-03-02 15:40 | hudsonbot | Checkin | |
| 2012-03-02 15:40 | hudsonbot | Note Added: 0045977 | |
|
Notes |
|
|
(0045414)
|
|
dbaz
|
2012-02-23 16:23
(edited on: 2012-02-23 16:24) |
|
The risk of the fix is medium, since it involves to a lot of classic processes configured in different way, so a complete test case is going to be provided.
The COMPLETE test case (the six points) MUST be run three times: in IE, Firefox and Chrome to ensure all browser's behavior is the same (and is the good one):
a) Open a process in a modal popup accessing the erp url directly:
As "Openbravo Admin":
* Go to "Sales Invoice"
* Click "Reactivate" button of any completed sales invoice
* Click "OK" in the opened modal popup
Ensure that the action is properly done
b) Open a process in a modal popup accessing the erp from attached example.html:
* The same than "a)" but accessing the erp from example.html
c) Open a process in a real browser popup accessing the erp url directly:
As "System":
* Go to "Preferences"
* Change the value "Y" to "N" in the record with Attribute "ModalModuleorg.openbravo.advpaymentmngt"
* Save
As "Openbravo Admin":
* Go to "Sales Invoice"
* Click "Reactivate" button of any completed sales invoice
* Click "OK" in the opened real browser popup
Ensure that the action is properly done
d) Open a process in a real browser popup accessing the erp from attached example.html:
* The same than "c)" but accessing the erp from example.html
e) Open a process in 2.50 classic way accessing the erp url directly:
To access the application in 2.50 classic way, you have to enter as is said in the last paragraph of:
http://wiki.openbravo.com/wiki/How_To_Switch_to_Classic_Mode [^]
As "Openbravo Admin":
* Go to "Sales Management" > "Transactions" > "Sales Invoice"
* Click "Reactivate" button of any completed sales invoice
* Click "OK" in the opened modal popup
Ensure that the action is properly done
f) Open a process in 2.50 classic way accessing the erp from attached example.html:
* The same than "e)" but accessing the erp from example.html (note that you should provide in it the classic path used in "e)")
|
|
|
|
(0045415)
|
|
hgbot
|
|
2012-02-23 16:35
|
|
|
|
|
(0045423)
|
|
hgbot
|
|
2012-02-23 20:11
|
|
|
|
|
|
Verified and it is working in the next browser:
-Firefox 10.0.2
-Chrome 16.0.912.77
-IE 8
In IE exist one problem when you try to go to window "Sales Invoice":
-"ModalModuleorg.openbravo.advpaymentmngt"= 'Y' or 'N'
-Open a process in a real browser popup accessing the erp from attached example.html
I have attached the popup with the error |
|
|
|
|
|
Verified in IE9 and it works perfect |
|
|
|
|
|
Code review: just an small change, add a comment to the "} catch (e) {} " line to explain when the exception might be thrown and why it is ok not to do anything else. |
|
|
|
(0045563)
|
|
hgbot
|
|
2012-02-29 00:35
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|