0018236: Display logic of tax category field in product tab gives jslint warning

Description

The tax category field (and in the product window has an display logic:
@IsSold@='Y' | @IsPurchased@='Y' & @IsSummary@='N'

This gives this jslint warning (note jslint warnings are displayed in the console if at least on module is in development):

Core.View:1302:117: The '&&' subexpression should be wrapped in parens. >> offending code: return !this.hiddenInForm && context && (currentValues.sale === true || currentValues.purchase === true && currentValues.summaryLevel === false);

Core.View:2191:97: The '&&' subexpression should be wrapped in parens. >> offending code: return context && (currentValues.sale === true || currentValues.purchase === true && currentValues.summaryLevel === false);

Steps To Reproduce

* Set at least one module in development
* Go to the product window and check the console

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0040314) hgbot (developer) 2011-08-18 14:12	Repository: erp/devel/pi Changeset: 8afb69d7545efb49ef1bc866d0e2086dcca9573a Author: Javier Etxarri <javier.echarri <at> openbravo.com> Date: Thu Aug 18 13:18:10 2011 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/8afb69d7545efb49ef1bc866d0e2086dcca9573a [^] Fixes issue 18236: Display logic of tax category field in product tab gives jslint warning --- M src-db/database/sourcedata/AD_FIELD.xml ---

(0040414) hudsonbot (viewer) 2011-08-22 18:39	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/30e6a459386a [^] Maturity status: Test

(0040625) jonalegriaesarte (viewer) 2011-08-31 13:36	Verified

Issue History
Date Modified	Username	Field	Change
2011-08-09 15:35	mtaal	New Issue
2011-08-09 15:35	mtaal	Assigned To	=> gorkaion
2011-08-09 15:35	mtaal	Modules	=> Core
2011-08-09 15:35	mtaal	OBNetwork customer	=> No
2011-08-10 08:57	gorkaion	Assigned To	gorkaion => jonalegriaesarte
2011-08-18 14:12	hgbot	Checkin
2011-08-18 14:12	hgbot	Note Added: 0040314
2011-08-18 14:12	hgbot	Status	new => resolved
2011-08-18 14:12	hgbot	Resolution	open => fixed
2011-08-18 14:12	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/8afb69d7545efb49ef1bc866d0e2086dcca9573a [^]
2011-08-22 18:39	hudsonbot	Checkin
2011-08-22 18:39	hudsonbot	Note Added: 0040414
2011-08-31 13:32	jonalegriaesarte	Assigned To	jonalegriaesarte => jecharri
2011-08-31 13:36	jonalegriaesarte	Note Added: 0040625
2011-08-31 13:36	jonalegriaesarte	Status	resolved => closed
2011-08-31 13:36	jonalegriaesarte	Fixed in Version	=> 3.0MP3