Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018236Openbravo ERP02. Master data managementpublic2011-08-09 15:352011-08-31 13:36
Reportermtaal 
Assigned Tojecharri 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP3Fixed in Version3.0MP3 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0018236: Display logic of tax category field in product tab gives jslint warning
DescriptionThe tax category field (and in the product window has an display logic:
@IsSold@='Y' | @IsPurchased@='Y' & @IsSummary@='N'

This gives this jslint warning (note jslint warnings are displayed in the console if at least on module is in development):

Core.View:1302:117: The '&&' subexpression should be wrapped in parens. >> offending code: return !this.hiddenInForm && context && (currentValues.sale === true || currentValues.purchase === true && currentValues.summaryLevel === false);

Core.View:2191:97: The '&&' subexpression should be wrapped in parens. >> offending code: return context && (currentValues.sale === true || currentValues.purchase === true && currentValues.summaryLevel === false);
Steps To Reproduce* Set at least one module in development
* Go to the product window and check the console
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-08-09 15:35mtaalNew Issue
2011-08-09 15:35mtaalAssigned To => gorkaion
2011-08-09 15:35mtaalModules => Core
2011-08-10 08:57gorkaionAssigned Togorkaion => jonalegriaesarte
2011-08-18 14:12hgbotCheckin
2011-08-18 14:12hgbotNote Added: 0040314
2011-08-18 14:12hgbotStatusnew => resolved
2011-08-18 14:12hgbotResolutionopen => fixed
2011-08-18 14:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8afb69d7545efb49ef1bc866d0e2086dcca9573a [^]
2011-08-22 18:39hudsonbotCheckin
2011-08-22 18:39hudsonbotNote Added: 0040414
2011-08-31 13:32jonalegriaesarteAssigned Tojonalegriaesarte => jecharri
2011-08-31 13:36jonalegriaesarteNote Added: 0040625
2011-08-31 13:36jonalegriaesarteStatusresolved => closed
2011-08-31 13:36jonalegriaesarteFixed in Version => 3.0MP3

Notes
(0040314)
hgbot   
2011-08-18 14:12   
Repository: erp/devel/pi
Changeset: 8afb69d7545efb49ef1bc866d0e2086dcca9573a
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Thu Aug 18 13:18:10 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8afb69d7545efb49ef1bc866d0e2086dcca9573a [^]

Fixes issue 18236: Display logic of tax category field in product tab gives jslint warning

---
M src-db/database/sourcedata/AD_FIELD.xml
---
(0040414)
hudsonbot   
2011-08-22 18:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/30e6a459386a [^]

Maturity status: Test
(0040625)
jonalegriaesarte   
2011-08-31 13:36   
Verified