Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0017508 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| design defect | [Openbravo ERP] A. Platform | major | always | 2011-06-06 13:23 | 2011-11-30 12:37 | |||
| Reporter | rgoris | View Status | public | |||||
| Assigned To | dbaz | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | c37e2e581482 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0017508: Section headers jump up and down when expanding and collapsing | |||||||
| Description | Sections are collapsed by default. When clicking on its headers, especially on smaller resolutions, the entire section jumps up or down when expanding and collapsing. This is confusing for the user and annoying when user just wants to peek into a section and collapse it directly afterwards (in two clicks) without moving the mouse. | |||||||
| Proposed Solution | Keep a section header in its place when expanding or collapsing | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  SEC_0000_Start.png [^] (61,266 bytes) 2011-06-06 13:23
SEC_0001_Moved.png [^] (67,299 bytes) 2011-06-06 13:24
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0038044) mtaal (manager) 2011-06-06 15:33 |
There are some complexities in this in that if the header is in the bottom of the form then expanding will make the form larger. The current logic will try to scroll to the end of the section to make sure that it is shown completely. When collapsing the section the opposite happens. See this code in the ob-formitem-section.js: this.form.parentElement.delayCall('scrollTo', [null, this.getTop()], 100); gr. Martin |
|
(0038049) rgoris (developer) 2011-06-06 16:01 |
Just FYI: use a long email thread in gmail and play with expanding and collapsing the emails one by one to see the ideal behavior. |
|
(0043210) rgoris (developer) 2011-11-25 11:54 edited on: 2011-11-25 12:03 |
Focus handling specs: 1) Focus must move to the section header on click 2) FOcus must remain on the section header after hitting space bar twice. This way the user can toggle the section (open and close) to view the insides. |
|
(0043381) hgbot (developer) 2011-11-27 22:47 |
Repository: erp/devel/pi Changeset: c37e2e581482995aab5f23a1a6fc4933420845c0 Author: David Baz Fayos <david.baz <at> openbravo.com> Date: Sun Nov 27 22:46:47 2011 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/c37e2e581482995aab5f23a1a6fc4933420845c0 [^] Fixed issue 17508: sections doesn't move anymore while expanding or collapsing --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-section.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-linked-items.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-notes.js --- |
|
(0043382) mtaal (manager) 2011-11-27 23:00 |
Reviewed the code change, looks fine to me |
|
(0043385) rgoris (developer) 2011-11-28 09:36 |
Tested on IE, FF, Safari and Chrome and it works as it should. |
|
(0043565) hudsonbot (developer) 2011-11-30 12:37 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/01809c7b3135 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-06-06 13:23 | rgoris | New Issue | |
| 2011-06-06 13:23 | rgoris | Assigned To | => mtaal |
| 2011-06-06 13:23 | rgoris | File Added: SEC_0000_Start.png | |
| 2011-06-06 13:23 | rgoris | Modules | => Core |
| 2011-06-06 13:24 | rgoris | File Added: SEC_0001_Moved.png | |
| 2011-06-06 15:33 | mtaal | Note Added: 0038044 | |
| 2011-06-06 15:33 | mtaal | Assigned To | mtaal => dbaz |
| 2011-06-06 15:33 | mtaal | Target Version | 3.0MP0 => 3.0MP1 |
| 2011-06-06 16:01 | rgoris | Note Added: 0038049 | |
| 2011-06-08 10:34 | rgoris | Status | new => scheduled |
| 2011-06-13 15:09 | dbaz | Priority | high => urgent |
| 2011-06-28 21:40 | dbaz | Target Version | 3.0MP1 => 3.0MP2 |
| 2011-07-20 12:28 | dbaz | Target Version | 3.0MP2 => 3.0MP3 |
| 2011-08-31 13:46 | dbaz | Target Version | 3.0MP3 => |
| 2011-10-28 20:57 | iciordia | Type | defect => design defect |
| 2011-11-25 11:54 | rgoris | Note Added: 0043210 | |
| 2011-11-25 12:03 | dbaz | Note Edited: 0043210 | View Revisions |
| 2011-11-27 22:47 | hgbot | Checkin | |
| 2011-11-27 22:47 | hgbot | Note Added: 0043381 | |
| 2011-11-27 22:47 | hgbot | Status | scheduled => resolved |
| 2011-11-27 22:47 | hgbot | Resolution | open => fixed |
| 2011-11-27 22:47 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/c37e2e581482995aab5f23a1a6fc4933420845c0 [^] |
| 2011-11-27 23:00 | mtaal | Note Added: 0043382 | |
| 2011-11-28 09:36 | rgoris | Note Added: 0043385 | |
| 2011-11-28 09:36 | rgoris | Status | resolved => closed |
| 2011-11-30 12:37 | hudsonbot | Checkin | |
| 2011-11-30 12:37 | hudsonbot | Note Added: 0043565 | |
| 2011-12-18 20:56 | dbaz | Relationship added | related to 0019327 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |