Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0017508Openbravo ERPA. Platformpublic2011-06-06 13:232011-11-30 12:37
Reporterrgoris 
Assigned Todbaz 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0017508: Section headers jump up and down when expanding and collapsing
DescriptionSections are collapsed by default. When clicking on its headers, especially on smaller resolutions, the entire section jumps up or down when expanding and collapsing. This is confusing for the user and annoying when user just wants to peek into a section and collapse it directly afterwards (in two clicks) without moving the mouse.
Steps To Reproduce
Proposed SolutionKeep a section header in its place when expanding or collapsing
Additional Information
TagsNo tags attached.
Relationships
related to defect 0019327 closed dbaz "Attachment" toolbar icon focus issues 
Attached Filespng SEC_0000_Start.png (61,266) 2011-06-06 13:23
https://issues.openbravo.com/file_download.php?file_id=4157&type=bug
png

png SEC_0001_Moved.png (67,299) 2011-06-06 13:24
https://issues.openbravo.com/file_download.php?file_id=4158&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-06-06 13:23rgorisNew Issue
2011-06-06 13:23rgorisAssigned To => mtaal
2011-06-06 13:23rgorisFile Added: SEC_0000_Start.png
2011-06-06 13:23rgorisModules => Core
2011-06-06 13:24rgorisFile Added: SEC_0001_Moved.png
2011-06-06 15:33mtaalNote Added: 0038044
2011-06-06 15:33mtaalAssigned Tomtaal => dbaz
2011-06-06 15:33mtaalTarget Version3.0MP0 => 3.0MP1
2011-06-06 16:01rgorisNote Added: 0038049
2011-06-08 10:34rgorisStatusnew => scheduled
2011-06-13 15:09dbazPriorityhigh => urgent
2011-06-28 21:40dbazTarget Version3.0MP1 => 3.0MP2
2011-07-20 12:28dbazTarget Version3.0MP2 => 3.0MP3
2011-08-31 13:46dbazTarget Version3.0MP3 =>
2011-10-28 20:57iciordiaTypedefect => design defect
2011-11-25 11:54rgorisNote Added: 0043210
2011-11-25 12:03dbazNote Edited: 0043210bug_revision_view_page.php?bugnote_id=0043210#r2949
2011-11-27 22:47hgbotCheckin
2011-11-27 22:47hgbotNote Added: 0043381
2011-11-27 22:47hgbotStatusscheduled => resolved
2011-11-27 22:47hgbotResolutionopen => fixed
2011-11-27 22:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c37e2e581482995aab5f23a1a6fc4933420845c0 [^]
2011-11-27 23:00mtaalNote Added: 0043382
2011-11-28 09:36rgorisNote Added: 0043385
2011-11-28 09:36rgorisStatusresolved => closed
2011-11-30 12:37hudsonbotCheckin
2011-11-30 12:37hudsonbotNote Added: 0043565
2011-12-18 20:56dbazRelationship addedrelated to 0019327

Notes
(0038044)
mtaal   
2011-06-06 15:33   
There are some complexities in this in that if the header is in the bottom of the form then expanding will make the form larger. The current logic will try to scroll to the end of the section to make sure that it is shown completely. When collapsing the section the opposite happens.

See this code in the ob-formitem-section.js:
        this.form.parentElement.delayCall('scrollTo', [null, this.getTop()], 100);


gr. Martin
(0038049)
rgoris   
2011-06-06 16:01   
Just FYI: use a long email thread in gmail and play with expanding and collapsing the emails one by one to see the ideal behavior.
(0043210)
rgoris   
2011-11-25 11:54   
(edited on: 2011-11-25 12:03)
Focus handling specs:

1) Focus must move to the section header on click
2) FOcus must remain on the section header after hitting space bar twice. This way the user can toggle the section (open and close) to view the insides.
(0043381)
hgbot   
2011-11-27 22:47   
Repository: erp/devel/pi
Changeset: c37e2e581482995aab5f23a1a6fc4933420845c0
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Sun Nov 27 22:46:47 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c37e2e581482995aab5f23a1a6fc4933420845c0 [^]

Fixed issue 17508: sections doesn't move anymore while expanding or collapsing

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-section.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-linked-items.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-notes.js
---
(0043382)
mtaal   
2011-11-27 23:00   
Reviewed the code change, looks fine to me
(0043385)
rgoris   
2011-11-28 09:36   
Tested on IE, FF, Safari and Chrome and it works as it should.
(0043565)
hudsonbot   
2011-11-30 12:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/01809c7b3135 [^]

Maturity status: Test