Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0015072
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 00. Application dictionaryminoralways2010-10-28 16:482012-04-02 06:10
ReporterazabaletaView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0MP10
StatusclosedFix in branchpiFixed in SCM revisiond14e8752f4e6
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.50MP22SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0015072: The display of help of edit of help is broken for module with baseLang != en_us

DescriptionI dont know more details about this bug. But according to Stefan this bug should be logged here in order to fix it when the time comes.

Regards,

Asier
Steps To Reproduce-Install Spanish translation pack
-Install Spanish module org.openbravo.test.spanishmod (attached)
-Install its English translation org.openbravo.test.spanishmod.enUS (attached)
-Login in Spanish
-Open "Test" window provided by the module and open help -> it should appear in Spanish
-Login in English
-Open "Test" window provided by the module and open help -> it should appear in English
Tagsdev-platform-quick-wins
Attached Files? file icon org.openbravo.test.spanishmod-0.0.0.obx [^] (8,293 bytes) 2012-03-30 12:01
? file icon org.openbravo.test.spanishmod.enUS-0.0.0.obx [^] (1,872 bytes) 2012-03-30 12:02

- Relationships Relation Graph ] Dependency Graph ]
related to defect 00150602.50MP26 closedalostale A user of OpenbravoERP that is not an admin can modify the help of the fields from the help popup. 
related to defect 00146333.0RC4 closedalostale Wrong behaviour when printing messages using OBError, when messages belong to a module whose language is different than English 

-  Notes
(0032313)
shuehner (administrator)
2010-10-28 16:51

Details: The code does read the base-table always with lang = en_US and uses the _TRL table only with different languages..

Assume a module with baseLangue = es_ES -> this will have:
base-table: es_ES
_TRL-table: en_US

Which will display the wrong language in that case..

Important: both display and update in that popup are wrong.
(0046485)
alostale (manager)
2012-03-16 08:58

Fixing display but not edit as editing must be completed re-checked and decided if should be maintained or not.

This fix does not add regression risk.
(0046487)
hgbot (developer)
2012-03-16 09:02

Repository: erp/devel/pi
Changeset: d14e8752f4e6a0f287b7e1f578cd148363a31123
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Mar 16 09:01:53 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d14e8752f4e6a0f287b7e1f578cd148363a31123 [^]

fixed bug 15072: Help not properly displayed for non en_US modules

  - Now it is always used the trl methods to retrieve help regardless context
    language or module base language, therefore base methods have been removed.
  - In trl methods additional * that were shown in case of no translation present
    have been removed.

---
M src/org/openbravo/erpCommon/ad_help/DisplayHelp_data.xsql
M src/org/openbravo/erpCommon/ad_help/HelpWindow.java
---
(0046989)
AugustoMauch (administrator)
2012-03-30 14:18

Code reviewed at verified in pi@01f4307bcdea
(0047155)
hudsonbot (developer)
2012-04-02 06:10

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2010-10-28 16:48 azabaleta New Issue
2010-10-28 16:48 azabaleta Assigned To => alostale
2010-10-28 16:51 shuehner Note Added: 0032313
2010-10-28 17:14 shuehner Issue Monitored: shuehner
2010-11-02 07:56 alostale Status new => scheduled
2010-11-02 07:58 alostale Relationship added related to 0015060
2010-11-17 13:19 shuehner Relationship added related to 0014633
2010-11-17 13:20 rafaroda Issue Monitored: rafaroda
2010-11-17 13:20 rafaroda Tag Attached: dev-platform-quick-wins
2012-03-16 08:58 alostale Note Added: 0046485
2012-03-16 09:02 hgbot Checkin
2012-03-16 09:02 hgbot Note Added: 0046487
2012-03-16 09:02 hgbot Status scheduled => resolved
2012-03-16 09:02 hgbot Resolution open => fixed
2012-03-16 09:02 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d14e8752f4e6a0f287b7e1f578cd148363a31123 [^]
2012-03-30 12:01 alostale Status resolved => new
2012-03-30 12:01 alostale Resolution fixed => open
2012-03-30 12:01 alostale File Added: org.openbravo.test.spanishmod-0.0.0.obx
2012-03-30 12:02 alostale File Added: org.openbravo.test.spanishmod.enUS-0.0.0.obx
2012-03-30 12:04 alostale Steps to Reproduce Updated View Revisions
2012-03-30 12:04 alostale Status new => scheduled
2012-03-30 12:04 alostale fix_in_branch => pi
2012-03-30 12:04 alostale Status scheduled => resolved
2012-03-30 12:04 alostale Resolution open => fixed
2012-03-30 14:18 AugustoMauch Note Added: 0046989
2012-03-30 14:18 AugustoMauch Status resolved => closed
2012-03-30 14:18 AugustoMauch Fixed in Version => 3.0MP10
2012-04-02 06:10 hudsonbot Checkin
2012-04-02 06:10 hudsonbot Note Added: 0047155


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker