Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0014047
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 03. Procurement managementmajoralways2010-07-26 16:042010-10-19 19:16
ReporterpsarobeView Statuspublic 
Assigned Todalsasua 
PriorityimmediateResolutionfixedFixed in Version2.50MP22
StatusclosedFix in branchFixed in SCM revision3af16d254adc
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.50MP20SCM revision 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0014047: Taxes in procurement invoice not properly calculate under some circunstances

DescriptionTaxes in procurement invoice are not properly calculate under the QA testing scenario.
That scenario has this org tree structure:
(*)
 |---Main
       |--- Spain
       |--- USA
Every organization has its own warehouse: Warehouse Spain and USA
In procurement invoice does not exist the warehouse so to calculate the destiny address what the application does is to take the warehouse from the session.
So if for any reason in the session the value is Warehouse USA (therefore the country address is USA) and you are creating the purchase invoice for the Org Spain and the country vendor is Spain instead of selecting the tax VAT 10%, is selecting the Exempt 10%
Steps To Reproduce1. Login as QAAdmin/QAAdmin
2. Ensure that the warehouse is Warehouse USA in the user info
3. Go to procurement management->Transactions->Purchase invoice
3. Click new and select bpartner Vendor A. Ensure the organization is Spain.Save
4. Move to lines and select product Raw materials A
5. Notice that the tax is Exempt 10% when it has to be VAT 10%
Proposed Solution1. It's ok that it takes the warehouse from the session but it has to validate that that warehouse belongs to the org tree branch of the invoice header.
2. If not then we should take a warehouse that belongs to it
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00149232.50MP23 closeddalsasua If there is not warehouse defined, taxes are not properly calculated 

-  Notes
(0029569)
hgbot (developer)
2010-07-26 19:41

 Repository: erp/devel/pi
Changeset: f1b53dfc9e0db9355313ca0fd3faa4f69b81bbb8
Author: David Alsasua <david.alsasua <at> openbravo.com>
Date: Mon Jul 26 19:27:40 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f1b53dfc9e0db9355313ca0fd3faa4f69b81bbb8 [^]

Fixes issue 14047.
Currently, callout in invoice line uses client warehouse set in context to retrieve client location, and uses it to select the appropriate tax rate.
Now, once the warehouse is retrieved, it is checked if the organization for which this warehouse is set, is in the same branch of the organizational tree. If not, chooses another warehouse: once set for an organization in the same branch of the tree of organizations.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java
M src/org/openbravo/erpCommon/ad_callouts/SL_Order_Product_data.xsql
A src/org/openbravo/erpCommon/businessUtility/Organization_data.xsql
---
(0029610)
hudsonbot (viewer)
2010-07-27 15:41

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/f1b53dfc9e0d [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/634cc0909ed2 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17922.obx [^]
(0030072)
hgbot (developer)
2010-08-17 14:18

 Repository: erp/devel/pi
Changeset: 64da2ed5a594ee8b9671d76bf01775fe5d98c636
Author: David Alsasua <david.alsasua <at> openbravo.com>
Date: Tue Aug 17 14:17:29 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/64da2ed5a594ee8b9671d76bf01775fe5d98c636 [^]

Fixes issue 14047

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java
R src/org/openbravo/erpCommon/businessUtility/Organization_data.xsql
---
(0030089)
hudsonbot (viewer)
2010-08-18 00:39

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/64da2ed5a594 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/2cad794ceb55 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18177.obx [^]
(0030185)
psarobe (viewer)
2010-08-20 13:14

 Still i can reproduce. I have updated the steps a little bit so it's easier to verify whether is properly fix or not
(0030189)
hgbot (developer)
2010-08-20 14:06

 Repository: erp/devel/pi
Changeset: 3af16d254adc81a08637c8a1c2b77fa4015bea8e
Author: David Alsasua <david.alsasua <at> openbravo.com>
Date: Fri Aug 20 14:06:10 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3af16d254adc81a08637c8a1c2b77fa4015bea8e [^]

Fixes issue 14047
Wrong logic applied with OrganizationStructureProvider usage. Now works as expected

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java
---
(0030206)
hudsonbot (viewer)
2010-08-21 00:06

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/3af16d254adc [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/eedf97667060 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18194.obx [^]
(0031158)
psarobe (viewer)
2010-09-16 13:44

 Tested working fine
(0031972)
dalsasua (viewer)
2010-10-19 13:42

 It seems that, if no warehouse is defined for the client, the callout fails. Let's test it also with no warehouse defined in the client.

- Issue History
Date Modified Username Field Change
2010-07-26 16:04 psarobe New Issue
2010-07-26 16:04 psarobe Assigned To => dalsasua
2010-07-26 16:04 psarobe OBNetwork customer => No
2010-07-26 16:05 psarobe Status new => scheduled
2010-07-26 16:05 psarobe fix_in_branch => pi
2010-07-26 16:07 psarobe fix_in_branch pi =>
2010-07-26 16:07 psarobe Proposed Solution updated
2010-07-26 19:41 hgbot Checkin
2010-07-26 19:41 hgbot Note Added: 0029569
2010-07-26 19:41 hgbot Status scheduled => resolved
2010-07-26 19:41 hgbot Resolution open => fixed
2010-07-26 19:41 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f1b53dfc9e0db9355313ca0fd3faa4f69b81bbb8 [^]
2010-07-27 15:41 hudsonbot Checkin
2010-07-27 15:41 hudsonbot Note Added: 0029610
2010-08-17 14:18 hgbot Checkin
2010-08-17 14:18 hgbot Note Added: 0030072
2010-08-17 14:18 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/f1b53dfc9e0db9355313ca0fd3faa4f69b81bbb8 [^] => http://code.openbravo.com/erp/devel/pi/rev/64da2ed5a594ee8b9671d76bf01775fe5d98c636 [^]
2010-08-18 00:39 hudsonbot Checkin
2010-08-18 00:39 hudsonbot Note Added: 0030089
2010-08-20 13:11 psarobe Steps to Reproduce Updated View Revisions
2010-08-20 13:14 psarobe Note Added: 0030185
2010-08-20 13:14 psarobe Status resolved => new
2010-08-20 13:14 psarobe Resolution fixed => open
2010-08-20 13:15 psarobe Status new => scheduled
2010-08-20 13:15 psarobe fix_in_branch => pi
2010-08-20 14:06 hgbot Checkin
2010-08-20 14:06 hgbot Note Added: 0030189
2010-08-20 14:06 hgbot Status scheduled => resolved
2010-08-20 14:06 hgbot Resolution open => fixed
2010-08-20 14:06 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/64da2ed5a594ee8b9671d76bf01775fe5d98c636 [^] => http://code.openbravo.com/erp/devel/pi/rev/3af16d254adc81a08637c8a1c2b77fa4015bea8e [^]
2010-08-21 00:06 hudsonbot Checkin
2010-08-21 00:06 hudsonbot Note Added: 0030206
2010-09-16 13:44 psarobe Note Added: 0031158
2010-09-16 13:44 psarobe Status resolved => closed
2010-09-16 13:44 psarobe Fixed in Version => 2.50MP22
2010-09-17 00:00 anonymous sf_bug_id 0 => 3068045
2010-10-19 13:42 dalsasua Note Added: 0031972
2010-10-19 13:42 dalsasua Status closed => new
2010-10-19 13:42 dalsasua Resolution fixed => open
2010-10-19 13:42 dalsasua Fixed in Version 2.50MP22 =>
2010-10-19 19:15 psarobe Status new => scheduled
2010-10-19 19:15 psarobe Status scheduled => resolved
2010-10-19 19:15 psarobe Resolution open => fixed
2010-10-19 19:15 psarobe Status resolved => closed
2010-10-19 19:16 psarobe Fixed in Version => 2.50MP22
2010-10-19 19:16 psarobe fix_in_branch pi =>
2010-10-19 19:22 psarobe Relationship added related to 0014923

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker