Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0010863 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] 09. Financial management | minor | always | 2009-10-05 12:47 | 2009-11-27 00:00 | |||
Reporter | networkb | View Status | public | |||||
Assigned To | vinothbabu | |||||||
Priority | high | Resolution | fixed | Fixed in Version | 2.50MP9 | |||
Status | closed | Fix in branch | pi | Fixed in SCM revision | e5eb5b4b64a7 | |||
Projection | none | ETA | none | Target Version | 2.50MP9 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | 2.50MP5 | SCM revision | ||||||
Merge Request Status | ||||||||
Review Assigned To | ||||||||
OBNetwork customer | OBPS | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0010863: Copy from Settlement do not check if mandatory fields are empty or not | |||||||
Description | When copy from settlement is used, and some lines are introduced in the second frame (after selecting a document to be copied), it is not checked if mandatory fields are filled or not (date, business partner) and amount has the properly format (. instead of ,). After clicking on OK, pop-up is closed and an error message appears. However, all lines to be copied have to be introduced again. | |||||||
Steps To Reproduce | Go to Financial management > transactions > manual settlement. (If there is no manual settlement checked as template, please, select one previosly). Generate a new one. Save it. Press Copy from Settlement. Enter From date (ie 01-01-2002) and To Date (ie 01-01-2010).Press Search. Select one record in the first frame. New line (or line) will appear in the second one. Remove date, business partner and enter as amount 10,22. Press Ok. An error message appears. | |||||||
Proposed Solution | Business partner, amount and date must be mandatories. Also, it must be checked if amount has the properly format. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
|
![]() |
|
(0021977) hgbot (developer) 2009-11-18 16:27 |
Repository: erp/devel/pi Changeset: fe2193a308d1b8722c85763566c3f3be249b08bc Author: Vinoth Babu <vinoth.babu <at> openbravo.com> Date: Wed Nov 18 20:55:55 2009 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/fe2193a308d1b8722c85763566c3f3be249b08bc [^] Fixes bug 10863 Copy from Settlement do not check if mandatory fields are empty or not --- M src/org/openbravo/erpCommon/ad_actionButton/CopyFromSettlement.java --- |
(0022000) sureshbabu (viewer) 2009-11-19 06:16 |
Vinoth, kindly let me know how we are verifying the amount format. in this case i tried to enter (10,00 instead of 10.00) 10,00 is taken as 1000.00. Also error messages appears when we keep the amount, date, debit and credit field as blank "ERROR: null value in column "amount" violates not-null constraint" "ERROR: null value in column "dateplanned" violates not-null constraint" ERROR: null value in column "amountdebit" violates not-null constraint ERROR: null value in column "amountcredit" violates not-null constraint are too technical, better change the above messages similar to message appears when BP is blank "The field Business partner is mandatory and cannot be left empty" |
(0022006) vinothbabu (viewer) 2009-11-19 08:39 |
It seems to be working fine in Oracle Environment but not working in postgres |
(0022027) networkb (viewer) 2009-11-19 16:25 |
I have checked the solution, and only BP is checked if it is mandatory or not. What about the rest? Please, see our proposed solution |
(0022040) sureshbabu (viewer) 2009-11-20 05:35 |
Hi Vinoth, As of now i will reopen the issue, and let me know once the issue works in both the environments and also please make sure the system works as per the proposed solution. |
(0022077) hgbot (developer) 2009-11-20 18:29 |
Repository: erp/devel/pi Changeset: e5eb5b4b64a7abfba5d85bb16d78d048026177e9 Author: Vinoth Babu <vinoth.babu <at> openbravo.com> Date: Fri Nov 20 22:56:49 2009 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/e5eb5b4b64a7abfba5d85bb16d78d048026177e9 [^] Fixes bug 10863 Copy from Settlement do not check if mandatory fields are empty or not --- M src/org/openbravo/erpCommon/ad_actionButton/CopyFromSettlement.java --- |
(0022129) sureshbabu (viewer) 2009-11-24 07:14 |
Tested in main context working fine |
![]() |
|||
Date Modified | Username | Field | Change |
2009-10-05 12:47 | networkb | New Issue | |
2009-10-05 12:47 | networkb | Assigned To | => rafaroda |
2009-10-05 12:47 | networkb | OBNetwork customer | => Yes |
2009-10-05 12:50 | networkb | Target Version | => 2.50MP8 |
2009-10-06 08:56 | rafaroda | Assigned To | rafaroda => dalsasua |
2009-10-06 08:56 | rafaroda | Priority | immediate => high |
2009-10-06 08:56 | rafaroda | Status | new => scheduled |
2009-10-22 10:06 | networkb | Target Version | 2.50MP8 => 2.50MP9 |
2009-11-12 06:47 | rajagopal | Assigned To | dalsasua => balamurugan |
2009-11-17 10:00 | vinothbabu | Assigned To | balamurugan => vinothbabu |
2009-11-18 16:27 | hgbot | Checkin | |
2009-11-18 16:27 | hgbot | Note Added: 0021977 | |
2009-11-18 16:27 | hgbot | Status | scheduled => resolved |
2009-11-18 16:27 | hgbot | Resolution | open => fixed |
2009-11-18 16:27 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/fe2193a308d1b8722c85763566c3f3be249b08bc [^] |
2009-11-19 06:06 | sureshbabu | Issue Monitored: sureshbabu | |
2009-11-19 06:16 | sureshbabu | Note Added: 0022000 | |
2009-11-19 08:39 | vinothbabu | Note Added: 0022006 | |
2009-11-19 16:25 | networkb | Note Added: 0022027 | |
2009-11-20 05:35 | sureshbabu | Note Added: 0022040 | |
2009-11-20 05:35 | sureshbabu | Status | resolved => new |
2009-11-20 05:35 | sureshbabu | Resolution | fixed => open |
2009-11-20 10:03 | rafaroda | Status | new => scheduled |
2009-11-20 10:03 | rafaroda | fix_in_branch | => pi |
2009-11-20 18:29 | hgbot | Checkin | |
2009-11-20 18:29 | hgbot | Note Added: 0022077 | |
2009-11-20 18:29 | hgbot | Status | scheduled => resolved |
2009-11-20 18:29 | hgbot | Resolution | open => fixed |
2009-11-20 18:29 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/fe2193a308d1b8722c85763566c3f3be249b08bc [^] => http://code.openbravo.com/erp/devel/pi/rev/e5eb5b4b64a7abfba5d85bb16d78d048026177e9 [^] |
2009-11-24 07:14 | sureshbabu | Note Added: 0022129 | |
2009-11-24 07:14 | sureshbabu | Status | resolved => closed |
2009-11-24 07:14 | sureshbabu | Fixed in Version | => 2.50MP9 |
2009-11-27 00:00 | anonymous | sf_bug_id | 0 => 2904741 |
Copyright © 2000 - 2009 MantisBT Group |