Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010863Openbravo ERP09. Financial managementpublic2009-10-05 12:472009-11-27 00:00
Reporternetworkb 
Assigned Tovinothbabu 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP5 
Target Version2.50MP9Fixed in Version2.50MP9 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0010863: Copy from Settlement do not check if mandatory fields are empty or not
DescriptionWhen copy from settlement is used, and some lines are introduced in the second frame (after selecting a document to be copied), it is not checked if mandatory fields are filled or not (date, business partner) and amount has the properly format (. instead of ,).

After clicking on OK, pop-up is closed and an error message appears. However, all lines to be copied have to be introduced again.
Steps To ReproduceGo to Financial management > transactions > manual settlement.
(If there is no manual settlement checked as template, please, select one previosly).
Generate a new one. Save it.
Press Copy from Settlement.
Enter From date (ie 01-01-2002) and To Date (ie 01-01-2010).Press Search.
Select one record in the first frame.
New line (or line) will appear in the second one.
Remove date, business partner and enter as amount 10,22.
Press Ok.
An error message appears.
Proposed SolutionBusiness partner, amount and date must be mandatories.
Also, it must be checked if amount has the properly format.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-10-05 12:47networkbNew Issue
2009-10-05 12:47networkbAssigned To => rafaroda
2009-10-05 12:50networkbTarget Version => 2.50MP8
2009-10-06 08:56rafarodaAssigned Torafaroda => dalsasua
2009-10-06 08:56rafarodaPriorityimmediate => high
2009-10-06 08:56rafarodaStatusnew => scheduled
2009-10-22 10:06networkbTarget Version2.50MP8 => 2.50MP9
2009-11-12 06:47rajagopalAssigned Todalsasua => balamurugan
2009-11-17 10:00vinothbabuAssigned Tobalamurugan => vinothbabu
2009-11-18 16:27hgbotCheckin
2009-11-18 16:27hgbotNote Added: 0021977
2009-11-18 16:27hgbotStatusscheduled => resolved
2009-11-18 16:27hgbotResolutionopen => fixed
2009-11-18 16:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/fe2193a308d1b8722c85763566c3f3be249b08bc [^]
2009-11-19 06:06sureshbabuIssue Monitored: sureshbabu
2009-11-19 06:16sureshbabuNote Added: 0022000
2009-11-19 08:39vinothbabuNote Added: 0022006
2009-11-19 16:25networkbNote Added: 0022027
2009-11-20 05:35sureshbabuNote Added: 0022040
2009-11-20 05:35sureshbabuStatusresolved => new
2009-11-20 05:35sureshbabuResolutionfixed => open
2009-11-20 10:03rafarodaStatusnew => scheduled
2009-11-20 10:03rafarodafix_in_branch => pi
2009-11-20 18:29hgbotCheckin
2009-11-20 18:29hgbotNote Added: 0022077
2009-11-20 18:29hgbotStatusscheduled => resolved
2009-11-20 18:29hgbotResolutionopen => fixed
2009-11-20 18:29hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/fe2193a308d1b8722c85763566c3f3be249b08bc [^] => http://code.openbravo.com/erp/devel/pi/rev/e5eb5b4b64a7abfba5d85bb16d78d048026177e9 [^]
2009-11-24 07:14sureshbabuNote Added: 0022129
2009-11-24 07:14sureshbabuStatusresolved => closed
2009-11-24 07:14sureshbabuFixed in Version => 2.50MP9
2009-11-27 00:00anonymoussf_bug_id0 => 2904741

Notes
(0021977)
hgbot   
2009-11-18 16:27   
Repository: erp/devel/pi
Changeset: fe2193a308d1b8722c85763566c3f3be249b08bc
Author: Vinoth Babu <vinoth.babu <at> openbravo.com>
Date: Wed Nov 18 20:55:55 2009 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/fe2193a308d1b8722c85763566c3f3be249b08bc [^]

Fixes bug 10863 Copy from Settlement do not check if mandatory fields are empty or not

---
M src/org/openbravo/erpCommon/ad_actionButton/CopyFromSettlement.java
---
(0022000)
sureshbabu   
2009-11-19 06:16   
Vinoth, kindly let me know how we are verifying the amount format. in this case i tried to enter (10,00 instead of 10.00) 10,00 is taken as 1000.00.

Also error messages appears when we keep the amount, date, debit and credit field as blank
"ERROR: null value in column "amount" violates not-null constraint"
"ERROR: null value in column "dateplanned" violates not-null constraint"
ERROR: null value in column "amountdebit" violates not-null constraint
ERROR: null value in column "amountcredit" violates not-null constraint

are too technical, better change the above messages similar to message appears when BP is blank
      
"The field Business partner is mandatory and cannot be left empty"
(0022006)
vinothbabu   
2009-11-19 08:39   
It seems to be working fine in Oracle Environment but not working in postgres
(0022027)
networkb   
2009-11-19 16:25   
I have checked the solution, and only BP is checked if it is mandatory or not.
What about the rest? Please, see our proposed solution
(0022040)
sureshbabu   
2009-11-20 05:35   
Hi Vinoth,

As of now i will reopen the issue, and let me know once the issue works in both the environments and also please make sure the system works as per the proposed solution.
(0022077)
hgbot   
2009-11-20 18:29   
Repository: erp/devel/pi
Changeset: e5eb5b4b64a7abfba5d85bb16d78d048026177e9
Author: Vinoth Babu <vinoth.babu <at> openbravo.com>
Date: Fri Nov 20 22:56:49 2009 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/e5eb5b4b64a7abfba5d85bb16d78d048026177e9 [^]

Fixes bug 10863 Copy from Settlement do not check if mandatory fields are empty or not

---
M src/org/openbravo/erpCommon/ad_actionButton/CopyFromSettlement.java
---
(0022129)
sureshbabu   
2009-11-24 07:14   
Tested in main context working fine